From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83A57C433B4 for ; Sat, 8 May 2021 09:13:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 214A96135D for ; Sat, 8 May 2021 09:13:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230257AbhEHJOL (ORCPT ); Sat, 8 May 2021 05:14:11 -0400 Received: from ivanoab7.miniserver.com ([37.128.132.42]:54650 "EHLO www.kot-begemot.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbhEHJOL (ORCPT ); Sat, 8 May 2021 05:14:11 -0400 Received: from tun252.jain.kot-begemot.co.uk ([192.168.18.6] helo=jain.kot-begemot.co.uk) by www.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfJ1F-0005ry-8y; Sat, 08 May 2021 09:13:05 +0000 Received: from madding.kot-begemot.co.uk ([192.168.3.98]) by jain.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lfJ1C-0005On-Md; Sat, 08 May 2021 10:13:04 +0100 Subject: Re: [PATCH 1/1] um: fix error return code in slip_open() To: Zhen Lei , Jeff Dike , Richard Weinberger , Andrew Morton , linux-um , linux-kernel References: <20210508031354.2127-1-thunder.leizhen@huawei.com> From: Anton Ivanov Organization: Cambridge Greys Message-ID: <70835fd6-69ba-8bff-65a1-aad83e400a52@cambridgegreys.com> Date: Sat, 8 May 2021 10:13:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210508031354.2127-1-thunder.leizhen@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Clacks-Overhead: GNU Terry Pratchett Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/05/2021 04:13, Zhen Lei wrote: > Fix to return a negative error code from the error handling case instead > of 0, as done elsewhere in this function. > > Fixes: a3c77c67a443 ("[PATCH] uml: slirp and slip driver cleanups and fixes") > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei > --- > arch/um/drivers/slip_user.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/um/drivers/slip_user.c b/arch/um/drivers/slip_user.c > index 482a19c5105c..7334019c9e60 100644 > --- a/arch/um/drivers/slip_user.c > +++ b/arch/um/drivers/slip_user.c > @@ -145,7 +145,8 @@ static int slip_open(void *data) > } > sfd = err; > > - if (set_up_tty(sfd)) > + err = set_up_tty(sfd); > + if (err) > goto out_close2; > > pri->slave = sfd; > Acked-By: anton.ivanov@cambridgegreys.com -- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/