mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Larry Finger" <Larry.Finger@lwfinger.net>,
	"Arnd Bergmann" <arnd@kernel.org>,
	"Dominik Brodowski" <linux@dominikbrodowski.net>,
	linux-kernel@vger.kernel.org
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Hartley Sweeten" <hsweeten@visionengravers.com>,
	"Ian Abbott" <abbotti@mev.co.uk>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Kevin Cernekee" <cernekee@gmail.com>,
	"Lukas Wunner" <lukas@wunner.de>,
	"Manuel Lauss" <manuel.lauss@gmail.com>,
	"Oliver Hartkopp" <socketcan@hartkopp.net>,
	"Olof Johansson" <olof@lixom.net>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>,
	"YOKOTA Hiroshi" <yokota@netlab.is.tsukuba.ac.jp>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-wireless@vger.kernel.org, Netdev <netdev@vger.kernel.org>
Subject: Re: [RFC 0/6] pcmcia: separate 16-bit support from cardbus
Date: Mon, 27 Feb 2023 22:30:08 +0100	[thread overview]
Message-ID: <7085019b-4fad-4d8d-89c0-1dd33fb27bb7@app.fastmail.com> (raw)
In-Reply-To: <e9f8501f-ede0-4d38-6585-d3dc2469d3fe@lwfinger.net>

On Mon, Feb 27, 2023, at 22:09, Larry Finger wrote:
> On 2/27/23 14:38, Arnd Bergmann wrote:
>> Is this the Cardbus or the PCMCIA version of the BCM4306 device? As far
>> as I understand this particular chip can be wired up either way inside
>> of the card, and the PowerBook G4 supports both types of devices.
>> 
>> If it's the PCMCIA version, then dropping support for it was the idea
>> of the patch series that we can debate, but if it was the Cardbus version
>> that broke, then this was likely a bug I introduced by accident.
>
> The BCM4306 is internal, and wired directly to the PCI bus. My understanding is 
> that the BCM4318 is a cardbus device. It definitely shows up in an lspci scan.

Ah right, I got confused because I had googled for BCM4306 for too long
trying to find out whether that might be used in combination with the
BCM63xx SoC support that patch 1 removed.

BCM4318 should definitely keep working after my series. My best guess
is that the problem is that I introduced an unnecessary dependency
between CONFIG_CARDBUS and CONFIG_PCI_HOTPLUG, so you'd need to
either undo the dependency or enable both in the local config.

If it's not that, then it's a bug in my changes that needs to be
fixed before they can be considered for integration. As long as
we are still debating whether the series makes sense at all,
I'm not worried about this.

      Arnd

  reply	other threads:[~2023-02-27 21:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 13:34 Arnd Bergmann
2023-02-27 13:34 ` [RFC 1/6] pccard: remove bcm63xx socket driver Arnd Bergmann
2023-02-27 21:33   ` Florian Fainelli
2023-03-14  8:53     ` Maxime Bizon
2023-02-27 13:34 ` [RFC 2/6] pccard: split cardbus support from pcmcia Arnd Bergmann
2023-02-27 13:34 ` [RFC 3/6] yenta_socket: copy pccard core code into driver Arnd Bergmann
2023-02-27 13:34 ` [RFC 4/6] yenta_socket: remove dead code Arnd Bergmann
2023-02-27 13:34 ` [RFC 5/6] pccard: drop remnants of cardbus support Arnd Bergmann
2023-02-27 13:34 ` [RFC 6/6] pci: hotplug: move cardbus code from drivers/pcmcia Arnd Bergmann
     [not found] ` <1daa9f1f-6a68-273f-0866-72a4496cd0db@hartkopp.net>
2023-02-27 19:53   ` [RFC 0/6] pcmcia: separate 16-bit support from cardbus Arnd Bergmann
2023-02-27 20:32     ` Oliver Hartkopp
2023-02-27 20:54       ` Marc Kleine-Budde
2023-02-27 20:15 ` Russell King (Oracle)
2023-02-27 21:04   ` Arnd Bergmann
2023-02-28 22:45   ` David Laight
2023-02-28 22:55     ` David Laight
2023-02-27 20:23 ` Larry Finger
2023-02-27 20:38   ` Arnd Bergmann
2023-02-27 20:59     ` Russell King (Oracle)
2023-02-27 21:09     ` Larry Finger
2023-02-27 21:30       ` Arnd Bergmann [this message]
2023-02-28  3:57         ` Larry Finger
2023-02-28  8:37           ` Arnd Bergmann
2023-03-01  1:13             ` Larry Finger
2023-03-01  8:01               ` Arnd Bergmann
2023-02-28 21:35 ` Ondrej Zary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7085019b-4fad-4d8d-89c0-1dd33fb27bb7@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=Larry.Finger@lwfinger.net \
    --cc=abbotti@mev.co.uk \
    --cc=arnd@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=cernekee@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=hsweeten@visionengravers.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=lukas@wunner.de \
    --cc=manuel.lauss@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=robert.jarzmik@free.fr \
    --cc=socketcan@hartkopp.net \
    --cc=yokota@netlab.is.tsukuba.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®