From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Tejun Heo <tj@kernel.org>,
Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
<linux-omap@vger.kernel.org>, <linux-fbdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] omapfb: omapfb-main: Remove deprecated create_singlethread_workqueue
Date: Wed, 10 Aug 2016 13:50:05 +0300 [thread overview]
Message-ID: <7085eecc-dbeb-0e0f-dc95-c33f2f72d5b0@ti.com> (raw)
In-Reply-To: <20160702113401.GD17431@htj.duckdns.org>
[-- Attachment #1.1: Type: text/plain, Size: 800 bytes --]
On 02/07/16 14:34, Tejun Heo wrote:
> On Sat, Jul 02, 2016 at 02:00:56PM +0530, Bhaktipriya Shridhar wrote:
>> The workqueue auto_update_work is involved in auto updating mode for
>> manual-update displays. omapfb driver uses a delayed work item to update
>> the display at a constant rate.
>>
>> Since these long-running work items aren't involved in memory reclaim in
>> any way, system_long_wq has been used.
>
> Can you please explain why this is long-running?
It shouldn't be long-running. update() should only start the transfer to
the display.
Although if something is not right (the user sets the auto-update
frequency to too high), the work could end up waiting for the previous
update to finish...
It's a debugging feature, so maybe that's not an issue.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-08-10 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-02 8:30 Bhaktipriya Shridhar
2016-07-02 11:34 ` Tejun Heo
2016-08-10 10:50 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7085eecc-dbeb-0e0f-dc95-c33f2f72d5b0@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=akpm@linux-foundation.org \
--cc=bhaktipriya96@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=plagnioj@jcrosoft.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®