From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29DCEC433B4 for ; Thu, 8 Apr 2021 19:25:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00075610FB for ; Thu, 8 Apr 2021 19:25:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232734AbhDHTZr (ORCPT ); Thu, 8 Apr 2021 15:25:47 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:41059 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231940AbhDHTZn (ORCPT ); Thu, 8 Apr 2021 15:25:43 -0400 Received: from mail-wr1-f70.google.com ([209.85.221.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lUaHS-0002d3-6P for linux-kernel@vger.kernel.org; Thu, 08 Apr 2021 19:25:30 +0000 Received: by mail-wr1-f70.google.com with SMTP id u10so1402431wrm.2 for ; Thu, 08 Apr 2021 12:25:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EW7d+9G4/kjjtpomgAZZU/CRnYFDop2X3n6Zj7v339I=; b=k80f2GdtF7ZhuNjDWb96iOEeTnDf9mpDEv5xbUyZrO1bsjTF4jcJzQNiFQLmXnL7+i czt3VuvUIe+yfsVOKx6C1gBKLvaGagSVqggh1rdy84vCNnKEwOFcN/LKr6TZzwO7D9AS kJC2V6eSrNmZbY36NRWtvHQbIkNBq1B1DDl3YsLKb6mUP4hpqIjDWPgLXKlbX7ywGTpw DHTGF52AWvD6N4wf4q9AYfd6rydEZ7VUUaFKpRC9EyoDvym4xVfXqwODfaL2088wtTCT G6tOFdsAkH3xRRqvhvC2zHhj4tN27nUuqX8Sq/C6/XzP+vknDpZ0j28uGkOOsQ9xN313 6KSQ== X-Gm-Message-State: AOAM531qVN9LBjknPr19h2jHPkKT39H+K1RW00JLz+j4oTR6Y/mZRT+W w3Gp5vx9oYwcXlv/TPKjDos1E1EVCItl43Dxo4Uni8Si7DAaSsfiDSawiWPJ8mJZ458DEkdgRcU 7iZ0caOpv5M2qeMF3eIK62RG6W4QShSfDsVSO4AlV0g== X-Received: by 2002:a5d:4f0e:: with SMTP id c14mr14193199wru.0.1617909929799; Thu, 08 Apr 2021 12:25:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3uC3t9Rn/hZil2QBwcuqL7F591JGwIex59HP2iZb5W4DsmO5gVtcusB8GA9Rzz/D/7bvgcg== X-Received: by 2002:a5d:4f0e:: with SMTP id c14mr14193176wru.0.1617909929665; Thu, 08 Apr 2021 12:25:29 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-192-147.adslplus.ch. [188.155.192.147]) by smtp.gmail.com with ESMTPSA id u17sm261604wmq.3.2021.04.08.12.25.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Apr 2021 12:25:29 -0700 (PDT) Subject: Re: New 'make dtbs_check W=1' warnings To: Arnd Bergmann , DTML , Rob Herring List-Id: Cc: Linus Walleij , Alexandre Belloni , Alexandre Torgue , Kevin Hilman , Linux Kernel Mailing List , Linux ARM , Tony Lindgren , Shawn Guo , Matthias Brugger , Bjorn Andersson , Geert Uytterhoeven , Nishanth Menon , Tero Kristo , SoC Team , Gregory Clement , Florian Fainelli References: From: Krzysztof Kozlowski Message-ID: <70873555-ab01-feb0-536b-d4b60ac89768@canonical.com> Date: Thu, 8 Apr 2021 21:25:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/04/2021 17:08, Arnd Bergmann wrote: > Greetings to all Arm platform maintainers, > > I've just gone through the DT merges I've received so far and, with a > little help from Rob, > managed to run 'make dtbs_check W=1' before and after, to see what > warnings we get. > The good news is that the number of warnings is going down, but > unfortunately there > is still an unmanageable amount of remaining warnings, and some new > ones crept in. > > I'm still working on my tooling for this, to catch these better, but > ideally I think we should > try to not introduce new warnings. I think some platforms are already > clean, and I did > not see any new warnings for mvebu, samsung and broadcom. There were a lot of > warnings from .dtsi files, and I probably did an incomplete job at > deduplicating those. > > See below for the other platforms, and the new warnings that I found. > If these are > valid, please send a fixup before the merge window, and let me know if > you have ideas > for how we should handle these in the future. > > For this merge window, I don't think any of them are show-stoppers (Rob, let me > know if you disagree), but in the long run we may want to gradually enforce > a rule about not merging changes that introduce any new warnings, in order to > have a chance of cleaning up the existing ones. +1 for such rule, although the best would be to get a report about new warnings on posted patches or shortly after applying, e.g. via 0-day kbuild robot. Best regards, Krzysztof