From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E84A2C432BE for ; Mon, 30 Aug 2021 07:57:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C3ADF6101B for ; Mon, 30 Aug 2021 07:57:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234464AbhH3H6O (ORCPT ); Mon, 30 Aug 2021 03:58:14 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:15231 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233318AbhH3H6N (ORCPT ); Mon, 30 Aug 2021 03:58:13 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4GyjMC0MjLz1DF2w; Mon, 30 Aug 2021 15:56:39 +0800 (CST) Received: from dggpemm500004.china.huawei.com (7.185.36.219) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 30 Aug 2021 15:57:09 +0800 Received: from [10.174.177.91] (10.174.177.91) by dggpemm500004.china.huawei.com (7.185.36.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Mon, 30 Aug 2021 15:57:09 +0800 Subject: Re: [PATCH -next v4 2/2] iommu/arm-smmu-v3: Add suspend and resume support From: Bixuan Cui To: , CC: , , , , , , , , , References: <20210830073858.47084-1-cuibixuan@huawei.com> <20210830073858.47084-2-cuibixuan@huawei.com> Message-ID: <7087f98c-a59e-00a3-2eae-958c25c1ac3c@huawei.com> Date: Mon, 30 Aug 2021 15:57:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20210830073858.47084-2-cuibixuan@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.91] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500004.china.huawei.com (7.185.36.219) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/30 15:38, Bixuan Cui wrote: > Changes in v4: > * Restore the arm_smmu_suspend() function code to the v2 version(Directly return 0 in it). Hello, I looked up the code of smmu.c and the manual of smmu v3. For the suspend is implemented by the external clock-gating, it is not clear what the SMMUv3 needs to do. Is it the same as that in smmu.c? I roll back the code here, and hope to get some advice. Thanks, Bixuan Cui