From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69009C43460 for ; Tue, 27 Apr 2021 03:31:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4562661166 for ; Tue, 27 Apr 2021 03:31:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234654AbhD0Dcc (ORCPT ); Mon, 26 Apr 2021 23:32:32 -0400 Received: from foss.arm.com ([217.140.110.172]:43432 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232295AbhD0Dcb (ORCPT ); Mon, 26 Apr 2021 23:32:31 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E125FD6E; Mon, 26 Apr 2021 20:31:48 -0700 (PDT) Received: from [10.163.75.249] (unknown [10.163.75.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 57C483F694; Mon, 26 Apr 2021 20:31:47 -0700 (PDT) From: Anshuman Khandual Subject: Re: [PATCH 6/6] mm: Constify page_count and page_ref_count To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Cc: Andrew Morton , linux-kernel@vger.kernel.org References: <20210416231531.2521383-1-willy@infradead.org> <20210416231531.2521383-7-willy@infradead.org> Message-ID: <708b4f1f-950f-c266-3067-b8f71b432266@arm.com> Date: Tue, 27 Apr 2021 09:02:39 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210416231531.2521383-7-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/17/21 4:45 AM, Matthew Wilcox (Oracle) wrote: > Now that compound_head() accepts a const struct page pointer, these two > functions can be marked as not modifying the page pointer they are passed. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/page_ref.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/page_ref.h b/include/linux/page_ref.h > index f3318f34fc54..7ad46f45df39 100644 > --- a/include/linux/page_ref.h > +++ b/include/linux/page_ref.h > @@ -62,12 +62,12 @@ static inline void __page_ref_unfreeze(struct page *page, int v) > > #endif > > -static inline int page_ref_count(struct page *page) > +static inline int page_ref_count(const struct page *page) > { > return atomic_read(&page->_refcount); > } > > -static inline int page_count(struct page *page) > +static inline int page_count(const struct page *page) > { > return atomic_read(&compound_head(page)->_refcount); > } > Reviewed-by: Anshuman Khandual