From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>,
Eva Rachel Retuya <eraretuya@gmail.com>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Cc: Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net,
gregkh@linuxfoundation.org, daniel.baluta@gmail.com,
amsfield22@gmail.com
Subject: Re: [PATCH v3 1/2] staging: iio: ad7606: replace range/range_available with corresponding scale
Date: Mon, 2 Jan 2017 19:42:47 +0100 [thread overview]
Message-ID: <708bad71-5496-d14f-caba-0df802582c88@metafoo.de> (raw)
In-Reply-To: <0f9108e2-35c3-ab0c-4ce0-242bdaba06c9@kernel.org>
On 12/30/2016 08:59 PM, Jonathan Cameron wrote:
> On 11/12/16 02:47, Eva Rachel Retuya wrote:
>> Eliminate the non-standard attributes in_voltage_range and
>> in_voltage_range_available. Implement in_voltage_scale_available in place
>> of these attributes and update the SCALE accordingly. The array
>> scale_avail is introduced to hold the available scale values.
>>
>> Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
> Looks good to me.
>
> Lars, if you have a minute to look over this as well that would
> be great.
I think this is OK as is, since it is an improvement over the current
situation. But there is still the open issue that we don't know the scale
setting if pin is hardwired. I'd like to see that addressed before the
driver is moved out of staging. Similar for the oversampling ratio.
Consider this Acked-by: Lars-Peter Clausen <lars@metafoo.de>
next prev parent reply other threads:[~2017-01-02 18:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-11 2:47 [PATCH v3 0/2] staging: iio: ad7606: move driver out of staging Eva Rachel Retuya
2016-12-11 2:47 ` [PATCH v3 1/2] staging: iio: ad7606: replace range/range_available with corresponding scale Eva Rachel Retuya
2016-12-30 19:59 ` Jonathan Cameron
2017-01-02 18:42 ` Lars-Peter Clausen [this message]
2016-12-11 2:47 ` [PATCH v3 2/2] staging: iio: ad7606: move out of staging Eva Rachel Retuya
2016-12-30 20:16 ` Jonathan Cameron
2017-01-02 18:33 ` Lars-Peter Clausen
2017-01-04 10:09 ` Eva Rachel Retuya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=708bad71-5496-d14f-caba-0df802582c88@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=amsfield22@gmail.com \
--cc=daniel.baluta@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=eraretuya@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®