From: Simon Budig <simon.budig@kernelconcepts.de>
To: Aniroop Mathur <aniroop.mathur@gmail.com>
Cc: Aniroop Mathur <a.mathur@samsung.com>,
daniel.wagener@kernelconcepts.de, LW@karo-electronics.de,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
SAMUEL SEQUEIRA <s.samuel@samsung.com>,
Rahul Mahale <r.mahale@samsung.com>
Subject: Re: [PATCH] Input: touchscreen: edt_ft5x06 - change msleep to usleep_range for small msecs
Date: Wed, 4 Jan 2017 19:19:56 +0100 [thread overview]
Message-ID: <708bb254-2830-63c6-f8c8-38fba0b8f988@kernelconcepts.de> (raw)
In-Reply-To: <CADYu309AZ_pj_ssVqPV+sXjW8fqMKTXwL_EoTBgLg2K1Ci614Q@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 774 bytes --]
On 03/12/16 19:17, Aniroop Mathur wrote:
> Since here we are using msleep(1) which is worse as it sleeps for
> minimum two jiffies so 20 ms on HZ=100 system and we are doing here
> 100 retries if register reading fails. So as you can deduce usleep_range
> will serve better here.
> Explained originally here why to not use msleep for 1-20ms:
> http://lkml.org/lkml/2007/8/3/250
Acked-by: Simon Budig <simon.budig@kernelconcepts.de>
Bye,
Simon
--
kernel concepts GmbH Simon Budig
Sieghuetter Hauptweg 48 simon.budig@kernelconcepts.de
D-57072 Siegen +49-271-771091-17
http://www.kernelconcepts.de/
HR Siegen, HR B 9613; Geschäftsführer: Nils Faerber, Ole Reinhardt
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2017-01-04 18:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 18:41 Aniroop Mathur
2016-11-29 20:54 ` Aniroop Mathur
2016-12-03 17:28 ` Simon Budig
2016-12-03 18:17 ` Aniroop Mathur
2017-01-04 18:19 ` Simon Budig [this message]
2017-01-04 18:58 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=708bb254-2830-63c6-f8c8-38fba0b8f988@kernelconcepts.de \
--to=simon.budig@kernelconcepts.de \
--cc=LW@karo-electronics.de \
--cc=a.mathur@samsung.com \
--cc=aniroop.mathur@gmail.com \
--cc=daniel.wagener@kernelconcepts.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=r.mahale@samsung.com \
--cc=s.samuel@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®