mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <noralf@tronnes.org>
To: Arnd Bergmann <arnd@arndb.de>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>
Cc: Lucas Stach <l.stach@pengutronix.de>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Sam Ravnborg <sam@ravnborg.org>,
	Souptick Joarder <jrdr.linux@gmail.com>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/imx: fix build failure without CONFIG_DRM_FBDEV_EMULATION
Date: Thu, 27 Sep 2018 13:21:15 +0200	[thread overview]
Message-ID: <70957313-2ec1-048f-d262-5ae8f96d9b8a@tronnes.org> (raw)
In-Reply-To: <20180926193846.2490574-1-arnd@arndb.de>


Den 26.09.2018 21.38, skrev Arnd Bergmann:
> The variable is declared in an #ifdef section, but the user is
> now unconditional, which leads to a build failure:
>
> drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind':
> drivers/gpu/drm/imx/imx-drm-core.c:264:6: error: 'legacyfb_depth' undeclared (first use in this function); did you mean 'lockdep_depth'?
>
> Remove the remaining #ifdef as well.
>
> Fixes: f53705fd9803 ("drm/imx: Use drm_fbdev_generic_setup()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Thanks for fixing my mistakes Arnd.
Applied to drm-misc-next.

Noralf.

>   drivers/gpu/drm/imx/imx-drm-core.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
> index a70f3131a377..0e6942f21a4e 100644
> --- a/drivers/gpu/drm/imx/imx-drm-core.c
> +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> @@ -35,10 +35,8 @@
>   
>   #define MAX_CRTC	4
>   
> -#if IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION)
>   static int legacyfb_depth = 16;
>   module_param(legacyfb_depth, int, 0444);
> -#endif
>   
>   DEFINE_DRM_GEM_CMA_FOPS(imx_drm_driver_fops);
>   


      reply	other threads:[~2018-09-27 11:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-26 19:38 Arnd Bergmann
2018-09-27 11:21 ` Noralf Trønnes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70957313-2ec1-048f-d262-5ae8f96d9b8a@tronnes.org \
    --to=noralf@tronnes.org \
    --cc=airlied@linux.ie \
    --cc=arnd@arndb.de \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jrdr.linux@gmail.com \
    --cc=l.stach@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®