Re: [PATCH 0/5] lib: devres: Add managed helpers for write-combine setup

[Thomas Zimmermann <tzimmermann@suse.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1389 bytes --]

Hi

Am 17.09.21 um 16:47 schrieb Hans de Goede:
> Hi,
> 
> On 9/16/21 8:15 PM, Thomas Zimmermann wrote:
>> Add devm_arch_phys_wc_add() and devm_arch_io_reserve_memtype_wc() for
>> automatic cleanup of writecombine setup.
>>
>> Several DRM drivers use the non-managed functions for setting their
>> framebuffer memory to write-combine access. Convert ast, mgag200 and
>> vboxvideo. Remove rsp clean-up code form drivers.
>>
>> Tested on mgag200 hardware.
>>
>> Thomas Zimmermann (5):
>>    lib: devres: Add managed arch_phys_wc_add()
>>    lib: devres: Add managed arch_io_reserve_memtype_wc()
>>    drm/ast: Use managed interfaces for framebuffer write combining
>>    drm/mgag200: Use managed interfaces for framebuffer write combining
>>    drm/vboxvideo: Use managed interfaces for framebuffer write combining
> 
> Thanks, the entire series looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 
> For the series.

Thanks. Let me know if I can review some DRM code for you, as Daniel 
suggested.

I'll wait a bit before merging the patches. Maybe devres devs want to 
comment.

Best regards
Thomas

> 
> Regards,
> 
> Hans
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]