From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07C0F3DA7ED for ; Wed, 18 Mar 2026 14:15:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773843336; cv=none; b=NiJSv35EDcOi4uM2LNKHSeyldM6M/6h2KxgRGrh0PAZYW09Q4lpZfZEo5qWtA6qW6z3wFdhhnlH9qbUtwNM5TRm4QyoT1Mo51PMaE8eTvNDvug8eO0zxRmJ1Kggj16dO5nqhNx2SF/TO/cjAIEa2Q0ywbOmzRpQtvrHhfiatYh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773843336; c=relaxed/simple; bh=Ptc2QynNW7iyUpE7OZ5J0jXqX6Hrgqnt15A0xLWasLc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RfE5CAu0+b3SHVvh1m15U7XyCSA8bSAXWROn5ayJZLL9a3UpPYr3be2ZZZpC+Mi8DNipMMLaCvZVgUcS8DiP+KmXz4gryZoEco8LCoe4xD//LmY7QbS13nv96/3cf3YoNre9rTYTTuKw8533k+xP2xkRw+CTBwZOMb8bnoVdaz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=njLZ3fzr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="njLZ3fzr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F646C2BC87; Wed, 18 Mar 2026 14:15:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773843335; bh=Ptc2QynNW7iyUpE7OZ5J0jXqX6Hrgqnt15A0xLWasLc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=njLZ3fzrrLmsX0DHIx+k1hMwTY5SkAcaZvF81uR54BLZ1dsypxged3NoZbA/yhNlz KN55ShOhtdHMyWSdVpcZf5/4yV6NESEg6olfr+t56X9lxv6rSdU7CiQtGoCBiHriga OG072IWvF0y1Qr+uyvxskkG1Kgt/vfkuNF9mHb9T7Ym0rKX9ZlgzVYVK2c16M1aeDc P1YUC6gngIJDYCbHe9B+1HGrTUB48Iorbyk9bI447R/Sj1tFAirTALiuHAZhiJRWek IxKJ+jiJob2dYWg8c9mIidCm50fe5jSEVw4nilL9MUOPrDuKAhRy0Si45p8pgA+j3S g6a9QIUELJq3A== Date: Wed, 18 Mar 2026 14:15:30 +0000 From: "Lorenzo Stoakes (Oracle)" To: "David Hildenbrand (Arm)" Cc: Andrew Morton , Rik van Riel , "Liam R . Howlett" , Vlastimil Babka , Harry Yoo , Jann Horn , Sasha Levin , Jiakai Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-hotfixes] mm/rmap: clear vma->anon_vma on error Message-ID: <709abbef-6038-47f8-8f06-b3e20d88878d@lucifer.local> References: <20260318122632.63404-1-ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 18, 2026 at 02:38:18PM +0100, David Hildenbrand (Arm) wrote: > On 3/18/26 14:03, Lorenzo Stoakes (Oracle) wrote: > > On Wed, Mar 18, 2026 at 01:52:44PM +0100, David Hildenbrand (Arm) wrote: > >> > >> Acked-by: David Hildenbrand (Arm) > >> > > > > Thanks! > > > >> LGTM. I was wondering whether anon_vma_clone() should take care of > >> setting up dst->anon_vma. It looks a bit odd in dup_anon_vma. > > > > Well in the fork case we don't want to set vma->anon_vma, as we use > > vma->anon_vma to denote whether or not we reused another anon_vma. For > > split + remap, we already duplicated it via vm_area_dup() -> > > vm_area_init_from(). > > > > But... now we have enum vma_operation threaded through here, we can just do > > that there like: > > > > /* dst is unfaulted, so inherit src's anon_vma. */ > > if (operation == VMA_OP_MERGE_UNFAULTED) > > dst->anon_vma = src->anon_vma; > > > > Exactly what I had in mind. That's fair, will send a separate patch for that! > > -- > Cheers, > > David Cheers, Lorenzo