From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: frank-w@public-files.de
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
"Sander Vanheule" <sander@svanheule.net>,
"René van Dorst" <opensource@vdorst.com>,
"Daniel Golle" <daniel@makrotopia.org>,
erkin.bozoglu@xeront.com,
"Sergio Paracuellos" <sergio.paracuellos@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: Aw: [RFC PATCH net-next] dt-bindings: net: dsa: mediatek,mt7530: completely rework binding
Date: Thu, 28 Jul 2022 01:04:14 +0300 [thread overview]
Message-ID: <709af825-7fde-d2c6-2237-3490163afa0e@arinc9.com> (raw)
In-Reply-To: <28a1620c-9771-f4dd-c432-4940d3b8f430@arinc9.com>
On 28.07.2022 00:46, Arınç ÜNAL wrote:
> On 28.07.2022 00:26, Frank Wunderlich wrote:
>> Am 27. Juli 2022 22:59:16 MESZ schrieb "Arınç ÜNAL"
>> <arinc.unal@arinc9.com>:
>>> On 27.07.2022 23:31, Frank Wunderlich wrote:
>>>>
>>
>>> I've seen this under mt7530_setup():
>>> The bit for MHWTRAP_P6_DIS is cleared to enable port 6 with the
>>> comment "Enable Port 6 only; P5 as GMAC5 which currently is not
>>> supported".
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/drivers/net/dsa/mt7530.c#n2189
>>>
>>
>> Later in same function it looks comment is obsolete.
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/drivers/net/dsa/mt7530.c#n2234
By the way, port 6 seems to be enabled even though port 5 is used as the
cpu port. Shouldn’t that be behind a check?
>>
>>
>> I know that rene added p5 support while phylink conversion,but not
>> sure it was complete.
>
> Thanks for pointing it out. I suppose it works fine since you tested it.
> I will update my patch to allow setting port 5 as cpu port along with
> splitting the patch.
>
> Arınç
next prev parent reply other threads:[~2022-07-27 22:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 12:24 Arınç ÜNAL
2022-07-27 10:29 ` Krzysztof Kozlowski
2022-07-30 8:24 ` Arınç ÜNAL
2022-08-01 17:54 ` Krzysztof Kozlowski
2022-07-27 20:31 ` Aw: " Frank Wunderlich
2022-07-27 20:59 ` Arınç ÜNAL
2022-07-27 21:26 ` Frank Wunderlich
2022-07-27 21:46 ` Arınç ÜNAL
2022-07-27 22:04 ` Arınç ÜNAL [this message]
2022-07-28 16:14 ` Daniel Golle
2022-07-30 9:15 ` Arınç ÜNAL
2022-07-30 9:30 ` DENG Qingfang
2022-07-30 9:35 ` Arınç ÜNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=709af825-7fde-d2c6-2237-3490163afa0e@arinc9.com \
--to=arinc.unal@arinc9.com \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=luizluca@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=opensource@vdorst.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sander@svanheule.net \
--cc=sean.wang@mediatek.com \
--cc=sergio.paracuellos@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®