From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8582C19759 for ; Thu, 1 Aug 2019 09:06:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C739720644 for ; Thu, 1 Aug 2019 09:06:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731055AbfHAJGC (ORCPT ); Thu, 1 Aug 2019 05:06:02 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:40700 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbfHAJGC (ORCPT ); Thu, 1 Aug 2019 05:06:02 -0400 Received: from mail-pg1-f199.google.com ([209.85.215.199]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1ht728-0007Tj-20 for linux-kernel@vger.kernel.org; Thu, 01 Aug 2019 09:06:00 +0000 Received: by mail-pg1-f199.google.com with SMTP id h3so44757813pgc.19 for ; Thu, 01 Aug 2019 02:05:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=CE/jIvfMb8MGoIQ8tRgk5BgnN9f/9L2WwMekkyWaOOI=; b=Bkt9Y3gkRSxC0CJNLMICB2hwsc5glSocnB8WIG4XccAerUaP18GJAPKbMkrQ9xJrMy gQF6xMk/rmiKljVV5wYkZyrx8upnWyXqB1PfMcxwVdT2VTZk82VRQt9JiWS54aS8cfrT EqNE8WRLwH0tLmu0Ff5xtBj6EBIbIvg8wE/z3ImM8GrFKt5A3eua3UMBKwAe7IujcIME OyAsP74BhMOJtZku30qxNGo7r3tYMRauDush+wKxLCwv5moVP4x3R/obtX4Cvde8uOEC K69Td+LNX1Btv1GbNDLYNqYf7xHbcjT+Ae1JQ7fXDPftqth+gr4mAziLzTUZPFU8irp0 tQmw== X-Gm-Message-State: APjAAAWPDk8oEl0DeOh3Gs2HILPBZXJiTJR9ScPDHldz/Mg6gpESe3M1 yUMMEJDfLHsLAllkrOJPQ1HhYbY+OmUjzgJ/TCV0U437Jc1/J9afSgXSOw8mKvydqvTUmOWJtdc mlxD4sw2V51bWwHu1080K5HdGOOPJWOHVBWI2+RnOOQ== X-Received: by 2002:a17:902:23:: with SMTP id 32mr37995693pla.34.1564650358686; Thu, 01 Aug 2019 02:05:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqwAXl4RJjTfmo0Fjo42W3mWvcZyKw/aanim8XYIpsdISoCCH8mQj5GW8+GFyrYPLhWNDtgylw== X-Received: by 2002:a17:902:23:: with SMTP id 32mr37995661pla.34.1564650358329; Thu, 01 Aug 2019 02:05:58 -0700 (PDT) Received: from 2001-b011-380f-37d3-ac53-c2c3-6814-e821.dynamic-ip6.hinet.net (2001-b011-380f-37d3-ac53-c2c3-6814-e821.dynamic-ip6.hinet.net. [2001:b011:380f:37d3:ac53:c2c3:6814:e821]) by smtp.gmail.com with ESMTPSA id s7sm3536097pjn.28.2019.08.01.02.05.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Aug 2019 02:05:57 -0700 (PDT) Content-Type: text/plain; charset=utf-8; delsp=yes; format=flowed Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems From: Kai-Heng Feng In-Reply-To: Date: Thu, 1 Aug 2019 17:05:54 +0800 Cc: Keith Busch , Mario Limonciello , "Rafael J. Wysocki" , Keith Busch , Christoph Hellwig , Sagi Grimberg , linux-nvme , Linux PM , Linux Kernel Mailing List , Rajat Jain Content-Transfer-Encoding: 8bit Message-Id: <70D536BE-8DC7-4CA2-84A9-AFB067BA520E@canonical.com> References: <4323ed84dd07474eab65699b4d007aaf@AUSX13MPC105.AMER.DELL.COM> <47415939.KV5G6iaeJG@kreacher> <20190730144134.GA12844@localhost.localdomain> <100ba4aff1c6434a81e47774ab4acddc@AUSX13MPC105.AMER.DELL.COM> <8246360B-F7D9-42EB-94FC-82995A769E28@canonical.com> <20190730191934.GD13948@localhost.localdomain> <7d3e0b8ba1444194a153c93faa1cabb3@AUSX13MPC105.AMER.DELL.COM> <20190730213114.GK13948@localhost.localdomain> <20190731221956.GB15795@localhost.localdomain> To: "Rafael J. Wysocki" X-Mailer: Apple Mail (2.3445.104.11) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org at 06:33, Rafael J. Wysocki wrote: > On Thu, Aug 1, 2019 at 12:22 AM Keith Busch wrote: >> On Wed, Jul 31, 2019 at 11:25:51PM +0200, Rafael J. Wysocki wrote: >>> A couple of remarks if you will. >>> >>> First, we don't know which case is the majority at this point. For >>> now, there is one example of each, but it may very well turn out that >>> the SK Hynix BC501 above needs to be quirked. >>> >>> Second, the reference here really is 5.2, so if there are any systems >>> that are not better off with 5.3-rc than they were with 5.2, well, we >>> have not made progress. However, if there are systems that are worse >>> off with 5.3, that's bad. In the face of the latest findings the only >>> way to avoid that is to be backwards compatible with 5.2 and that's >>> where my patch is going. That cannot be achieved by quirking all >>> cases that are reported as "bad", because there still may be >>> unreported ones. >> >> I have to agree. I think your proposal may allow PCI D3cold, > > Yes, it may. Somehow the 9380 with Toshiba NVMe never hits SLP_S0 with or without Rafael’s patch. But the “real” s2idle power consumption does improve with the patch. Can we use a DMI based quirk for this platform? It seems like a platform specific issue. > >> In which case we do need to reintroduce the HMB handling. > > Right. The patch alone doesn’t break HMB Toshiba NVMe I tested. But I think it’s still safer to do proper HMB handling. Kai-Heng