From: Markus Elfring <Markus.Elfring@web.de>
To: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>,
linux-clk@vger.kernel.org, Brian Masney <bmasney@redhat.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/7] clk: st: clkgen-pll: Fix a memory leak in clkgen_odf_register()
Date: Wed, 21 Jan 2026 10:30:42 +0100 [thread overview]
Message-ID: <70b3c173-34d7-408a-959a-5c8a7b1ed212@web.de> (raw)
In-Reply-To: <20260121012223.186199-2-lihaoxiang@isrc.iscas.ac.cn>
> If clk_register_composite() fails, call kfree() to release
> div and gate.
You may put such information also into a single text line.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc6#n659
How do you think about to avoid a bit of duplicate source code here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc6#n526
Regards,
Markus
next prev parent reply other threads:[~2026-01-21 9:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 1:22 [PATCH v2 0/7] clk: st: clkgen-pll: Add cleanup in clkgen_c32_pll_setup() and clkgen_odf_register() Haoxiang Li
2026-01-21 1:22 ` [PATCH v2 1/7] clk: st: clkgen-pll: Fix a memory leak in clkgen_odf_register() Haoxiang Li
2026-01-21 9:30 ` Markus Elfring [this message]
2026-01-21 1:22 ` [PATCH v2 2/7] clk: st: clkgen-pll: Rename clk variable in clkgen_c32_pll_setup() Haoxiang Li
2026-01-21 9:41 ` Markus Elfring
2026-01-21 1:22 ` [PATCH v2 3/7] " Haoxiang Li
2026-01-21 9:48 ` Markus Elfring
2026-01-22 23:37 ` Brian Masney
2026-01-21 1:22 ` [PATCH v2 4/7] clk: st: clkgen-pll: Add iounmap() " Haoxiang Li
2026-01-21 10:03 ` Markus Elfring
2026-01-21 1:22 ` [PATCH v2 5/7] clk: st: clkgen-pll: Add clk_unregister for pll_clk " Haoxiang Li
2026-01-21 1:22 ` [PATCH v2 6/7] clk: st: clkgen-pll: Remove redundant kfree() " Haoxiang Li
2026-01-21 1:22 ` [PATCH v2 7/7] clk: st: clkgen-pll: Add clk_unregister for odf_clk " Haoxiang Li
2026-01-21 10:15 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70b3c173-34d7-408a-959a-5c8a7b1ed212@web.de \
--to=markus.elfring@web.de \
--cc=bmasney@redhat.com \
--cc=lihaoxiang@isrc.iscas.ac.cn \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®