From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 495481D6AA for ; Thu, 4 Dec 2025 10:35:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764844546; cv=none; b=gFyoFwHpKe96yyNzyqdzBWAonQVBK1OunysB2xwK9MczewbCPZasQy7GDMGAyVdbNNz4io4kq57GF/PETFzJLwuh4DWjc24J9Ytu7REQ+gEfhBIK8kwRzw1H2sYChuTQRLiuChUVanu9WqdiQ0rXjppFHRL5LGlDCxJ+bqQzR5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764844546; c=relaxed/simple; bh=uFor36czUrjG0dgwIDCmf2o6kpsWmTe55mUkyQcjhkY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lpeGzau+0rhktrW/Cf+eflPYva42GpMd9LjkAcfPpNjGmsox04/JaSU8LJ/dtkRdKvhCDnNQC/LDuEmucmP1KRJoSUqG2bzEETuzZtVEBpt2eLy1lu1gxs8jJle6d/fXllFbK/RelugIvE2kGhU10S5LUhgFgmXlVZOawDilXeQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Fk1ePPHL; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=k1mJ0gBX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Fk1ePPHL"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="k1mJ0gBX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764844544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ozfZnozNInALPdRCnz4vV5+xZLy8wMlQy75f9uWAaQg=; b=Fk1ePPHLXOANu+Pr8YF+PZg1CgwCqY32FfwwWyWUs+uqsR8QxZwWi9FyfbEhSBXrEi+Xu5 54OPWhP+DYrr3cSa7dVrlDgTnmJVadIFNogzBtvDtQB6EItQu/gD7qNzOGOS6gr2p4jdUo 9cyTqq0rd27Jn5ldGnfp/DvWGrdPcpI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-BYkX5Q83O2OEI2qVWtq0DA-1; Thu, 04 Dec 2025 05:35:42 -0500 X-MC-Unique: BYkX5Q83O2OEI2qVWtq0DA-1 X-Mimecast-MFC-AGG-ID: BYkX5Q83O2OEI2qVWtq0DA_1764844542 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4792bd2c290so5661485e9.1 for ; Thu, 04 Dec 2025 02:35:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764844541; x=1765449341; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ozfZnozNInALPdRCnz4vV5+xZLy8wMlQy75f9uWAaQg=; b=k1mJ0gBXxT9lWsO0X4e+v1MBr/tr6YbWzFMtt/+dsX/Il3dy9tqL5tc/Glgi1e+T48 v5ZHhACLbvfs6DMn/gfc5fI3ijKzqzNxnzUzUkfGXXQDuyj1X4WwhR33kdl7TymekWFu 5ihoMQQ3xwXZa1fzaKfLs8Td4UngAR022O9JINIJzc/K/q2r+mYc9uC+Kxlsd8JxkJb6 I2UEIau8ZixJui/86zc4KsaVZkVQpUSd1xdAdRC5ZybGJbchUZASo8sN2qPh2x0lrKXx Whik4auwqTc/cVh4Z5i8syGYeV6Ncmxf3pRVEMpG8ATgP+YC9z9etQDvMklbMfZ3dNy7 +rrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764844541; x=1765449341; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ozfZnozNInALPdRCnz4vV5+xZLy8wMlQy75f9uWAaQg=; b=qQsNZnf8emVDT+u5tBGsoG0VcPJNiiuKfEAp8GhnY6ewCHhUVwL77798PwApbjiDVF qtJXI/38MJ2hcoW+g6eP4lBIysGxJxvvptHNftrPLlw55EOvxPxvGM4g11F29tmzNwp3 67YMBeP91G2Li0tFmhWgrDPjTq1HDPihtD2ENyrmMg12pm8/j7NHPPi4YsiKcYEbKm+B cFdBhxKMeswRpXug4bI4rrzrZlrRiXRa2mNCA1hXzBIAaAhjCok1BimEuzXPm0kbi4JR 4NGsV8qN7Pn76qDXQMaZlZNen9PCiMi3Ie/Po7h/b+vBOix6gL1Wi5grhj6fneMdNv7H 6Qqw== X-Forwarded-Encrypted: i=1; AJvYcCV0JFHCOxUP8dHY5VjgipvKUji95YO/UXMPQRbHQ64DhWhrbnMzZlPacniyM+P3XDT5kmc73PLlYdb77Lk=@vger.kernel.org X-Gm-Message-State: AOJu0YzZvhgg/+kYox6662ZJbWAXmZhMD6sF96pH0CQcB8enPTI6PK9T +W7/ze0Ks53zUNZduX4bqcOxN6N7F9uXr37AUnS+BC2JkKT0V5BdorJvsFDK5K8crmXKwzoWE01 L5QeGNg33G7cKzd+yUiddFZphVnx4tHNL/Xk3FDfRMsLX/2kkPMB1E8NFKm5mQH7YWg== X-Gm-Gg: ASbGnctHueNIAkfXs50RZECSyK24Y/ylxw3IZmbMwH9P3KuIAPNcW/KqIX/yHGxpG+W darCQTW2ykqUUztmzD/66MkkhSIYOzxB4CIBkYI71/HHApGkLL1dbircxM5M7hl++KDn1GGORlf CECZUBsTeozw8upPIOfM1w8YRbOWeW48o0JfMSUFrj+q+MIEkIa5om+87SaXJvLwHO2VunZZ7dn MgZe5fDm/8+7JrC5aBpknZrnvKpR+DhQplitktTVbWXGv4ijcURKBuoK7RQe6vEtT0eJkQ7sPxH VMquPQJiD6cX/SC1wUPezD36yrpQUogEL1XY13fQVdQwK/PJYONhUaR7uEgGayHvLGOKC+N1nNv cxfDozky4QLGc X-Received: by 2002:a05:600c:314b:b0:471:1717:411 with SMTP id 5b1f17b1804b1-4792af3d3c2mr56924095e9.24.1764844541671; Thu, 04 Dec 2025 02:35:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IE8gptBLReJPUISffURobPtpWsCKdYSKrcu6ukQl+6Of0teYy307j/lVeci1rwunYXMAOTS3Q== X-Received: by 2002:a05:600c:314b:b0:471:1717:411 with SMTP id 5b1f17b1804b1-4792af3d3c2mr56923735e9.24.1764844541179; Thu, 04 Dec 2025 02:35:41 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.24]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d331aeasm2391343f8f.37.2025.12.04.02.35.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 02:35:40 -0800 (PST) Message-ID: <70b71e0c-e1dc-4c9d-a75f-7adb9c92e394@redhat.com> Date: Thu, 4 Dec 2025 11:35:39 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] net: atm: implement pre_send to check input before sending To: Edward Adam Davis , horms@kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, syzbot+5dd615f890ddada54057@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com References: Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/1/25 5:31 AM, Edward Adam Davis wrote: > diff --git a/net/atm/lec.c b/net/atm/lec.c > index afb8d3eb2185..8a9660abd134 100644 > --- a/net/atm/lec.c > +++ b/net/atm/lec.c > @@ -340,6 +340,23 @@ static int lec_close(struct net_device *dev) > return 0; > } > > +static int lec_atm_pre_send(struct atm_vcc *vcc, struct sk_buff *skb) > +{ > + struct atmlec_msg *mesg; > + int sizeoftlvs; > + int msg_size = sizeof(struct atmlec_msg); Please respect the revers christmas tree above. > + > + if (skb->len < msg_size) > + return -EINVAL; > + > + mesg = (struct atmlec_msg *)skb->data; > + sizeoftlvs = mesg->sizeoftlvs; > + if (sizeoftlvs > 0 && !pskb_may_pull(skb, msg_size + sizeoftlvs)) AI based review noticed that negative `sizeoftlvs` values will foul the above check: https://netdev-ai.bots.linux.dev/ai-review.html?id=8b2b0db8-e11a-4215-85a6-a0735c7d908b AFAICS the lec code always interpret `sizeoftlvs` as u32, regardless of the type used by `struct atmlec_msg`. I suggest doing the same. /P