From: Bart Van Assche <bvanassche@acm.org>
To: Michael Bommarito <michael.bommarito@gmail.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] RDMA/srp: bound SRP_RSP sense copy by the received length
Date: Wed, 3 Jun 2026 10:13:31 -0700 [thread overview]
Message-ID: <70bff043-26cc-41b3-9d50-48356f85fc29@acm.org> (raw)
In-Reply-To: <20260602220457.2542840-1-michael.bommarito@gmail.com>
On 6/2/26 3:04 PM, Michael Bommarito wrote:
> + if (sizeof(*rsp) + (u64)resp_len + sense_len <= byte_len)
> + memcpy(scmnd->sense_buffer, rsp->data + resp_len,
> + min_t(u32, sense_len,
> + SCSI_SENSE_BUFFERSIZE));
The above min_t() probably can be changed into min(). Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2026-06-03 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 22:04 Michael Bommarito
2026-06-03 17:13 ` Bart Van Assche [this message]
2026-06-05 17:21 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70bff043-26cc-41b3-9d50-48356f85fc29@acm.org \
--to=bvanassche@acm.org \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michael.bommarito@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®