From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B093043E9DF for ; Thu, 4 Jun 2026 14:09:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780582170; cv=none; b=tAJp793dl46tIimZgNCiM2Rb8FXG7jnCSGbTjE5Yxc3Iixsot4n0lu57ulh5Sranef4Wuql64yXBO5Jv46PSE7D3hMFMI7jmUeZ8wiXAvZe5dj+NBfR4iNIja9W79sMAxO8+qbfeirySoEu1TY/0RYPP9FsAokwtAHq+By7j0mU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780582170; c=relaxed/simple; bh=U41qyEU8bgHGGMDvfSJ7vXc33RIhAeL6kaBV7Nf5dAA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=KdNovlFq6m725AAxOHDNHokM9V+e+DOG4P+eOsjpag2N6mJnqh/vl+/Tv0JYdy4EekiZ9R7WNkR9k5PRLVkQAW+6U0X2Ju9eBzKwpoY8gavxmOduYVaCZKcOeaShNLw42PO3KcGT3tceB7qDjXeeI7L38D7Jsc7fGyrAD4CiiTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com; spf=pass smtp.mailfrom=perches.com; arc=none smtp.client-ip=216.40.44.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=perches.com Received: from omf16.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D753D40763; Thu, 4 Jun 2026 14:09:27 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA id 4605720019; Thu, 4 Jun 2026 14:09:25 +0000 (UTC) Message-ID: <70c0c5d5e05363d4643cd1916750e03212ca761e.camel@perches.com> Subject: Re: [PATCH] checkpatch: Check WQ_PERCPU or WQ_UNBOUND presence in alloc_workqueue() users From: Joe Perches To: Marco Crivellari Cc: linux-kernel@vger.kernel.org, Andy Whitcroft , Dwaipayan Ray , Lukas Bulwahn , Tejun Heo , Frederic Weisbecker , Michal Hocko , Breno Leitao Date: Thu, 04 Jun 2026 07:09:24 -0700 In-Reply-To: References: <20260603140941.320063-1-marco.crivellari@suse.com> <8add4f780ec4861fba4e6bd77d50b384d32a642b.camel@perches.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Server: rspamout05 X-Rspamd-Queue-Id: 4605720019 X-Stat-Signature: di9jpnbkd8fipurbfbzuy1464ou5z4qp X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+Xfd/EcGQt4ZmCKnLNErpzezsKKwYJ+JA= X-HE-Tag: 1780582165-83921 X-HE-Meta: U2FsdGVkX18hAnaB9cMWn4g7vIEVhQdxx/pqKIfZ6oTvlFpD5y0vE/lOj+K0Olc/2+QY70DbmNE0mPSXdyY8cb/5P61AjB+gjfB2tImawqsghJ9Eskul4yAbJKzAVAZ+QpTTmaaqgSdhsS2jSV9Jyu/qJ7Y4ZkcSGlN4kckiKsEPOgfHQyuvfp+hmzQI1iK/x1eMfOyXbX3Eoj180GOxzEDAmFM+9aZDMZ3a01UmvwY39q6/R1ulFtsARsb6jq5zro8r2kHa16VmERIbpVyVteuuhyTryvDVMx/VltZHoeHjmm837QsZQVZ5kGIttUPvJ+hjOcZvWh3qdRE8DM6IXZjOCW1TUqnHUkfJ/fFEt+/Y4wV1vl6K1HE9nGftcRSC On Thu, 2026-06-04 at 11:31 +0200, Marco Crivellari wrote: > On Thu, Jun 4, 2026 at 7:08=E2=80=AFAM Joe Perches <[joe@perches.com](mai= lto:joe@perches.com)> wrote: > [...] > > OK but a couple comments: > >=20 > > Add devm_alloc_workqueue as well? >=20 > No I don't think it would be useful / needed. There is only 1 user of > that macro, devm_alloc_ordered_workqueue(), which already specifies > the WQ_UNBOUND flag and it is part of the workqueue code. drivers/power/supply/ipaq_micro_battery.c: mb->wq =3D devm_alloc_workq= ueue(&pdev->dev, "ipaq-battery-wq", Maybe there will be more.