From: Alex Hung <alex.hung@amd.com>
To: Xichao Zhao <zhao.xichao@vivo.com>,
harry.wentland@amd.com, sunpeng.li@amd.com,
alexander.deucher@amd.com, christian.koenig@amd.com,
airlied@gmail.com, simona@ffwll.ch
Cc: siqueira@igalia.com, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/amd/display: Clean up coding style
Date: Sun, 17 Aug 2025 18:01:30 -0600 [thread overview]
Message-ID: <70c3f221-04ca-4ae5-8726-7c5782641822@amd.com> (raw)
In-Reply-To: <20250731075450.626428-1-zhao.xichao@vivo.com>
Reviewed-by: Alex Hung <alex.hung@amd.com>
On 7/31/25 01:54, Xichao Zhao wrote:
> Adjust whitespace around operators to improve code readability
> and comply with kernel coding style guidelines.
>
> These changes are purely stylistic and introduce no
> functional modifications.
>
> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
> ---
> .../amd/display/dc/link/protocols/link_dp_capability.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> index e0c4416993d9..caddb7dfb133 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> @@ -1525,8 +1525,8 @@ bool read_is_mst_supported(struct dc_link *link)
> return false;
> }
>
> - rev.raw = 0;
> - cap.raw = 0;
> + rev.raw = 0;
> + cap.raw = 0;
>
> st = core_link_read_dpcd(link, DP_DPCD_REV, &rev.raw,
> sizeof(rev));
> @@ -2125,13 +2125,13 @@ void detect_edp_sink_caps(struct dc_link *link)
> &backlight_adj_cap, sizeof(backlight_adj_cap));
>
> link->dpcd_caps.dynamic_backlight_capable_edp =
> - (backlight_adj_cap & DP_EDP_DYNAMIC_BACKLIGHT_CAP) ? true:false;
> + (backlight_adj_cap & DP_EDP_DYNAMIC_BACKLIGHT_CAP) ? true : false;
>
> core_link_read_dpcd(link, DP_EDP_GENERAL_CAP_1,
> &general_edp_cap, sizeof(general_edp_cap));
>
> link->dpcd_caps.set_power_state_capable_edp =
> - (general_edp_cap & DP_EDP_SET_POWER_CAP) ? true:false;
> + (general_edp_cap & DP_EDP_SET_POWER_CAP) ? true : false;
>
> set_default_brightness_aux(link);
>
prev parent reply other threads:[~2025-08-18 0:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 7:54 Xichao Zhao
2025-08-18 0:01 ` Alex Hung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70c3f221-04ca-4ae5-8726-7c5782641822@amd.com \
--to=alex.hung@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=sunpeng.li@amd.com \
--cc=zhao.xichao@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®