From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "elaine.zhang" <zhangqing@rock-chips.com>, heiko@sntech.de
Cc: rui.zhang@intel.com, edubezval@gmail.com, robh+dt@kernel.org,
mark.rutland@arm.com, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
xxx@rock-chips.com, xf@rock-chips.com, huangtao@rock-chips.com
Subject: Re: [PATCH v2 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error
Date: Tue, 30 Apr 2019 11:44:49 +0200 [thread overview]
Message-ID: <70cc3a91-8f5d-da48-a815-eaf2670f9a93@linaro.org> (raw)
In-Reply-To: <8d41ea98-e0e8-60c8-3237-ade5d0d169bf@rock-chips.com>
On 29/04/2019 11:51, elaine.zhang wrote:
[ ... ]
> pinctrl select to gpio mode when tsadc suspend and shutdown.
>
> When suspend, tsadc is disabled, the otp_pin should revert to the
> default gpio state.
>
>>
>>> return 0;
>>> }
>>> @@ -1383,7 +1413,8 @@ static int __maybe_unused
>>> rockchip_thermal_resume(struct device *dev)
>>> for (i = 0; i < thermal->chip->chn_num; i++)
>>> rockchip_thermal_toggle_sensor(&thermal->sensors[i], true);
>>> - pinctrl_pm_select_default_state(dev);
>>> + if (thermal->tshut_mode == TSHUT_MODE_GPIO)
>>> + pinctrl_select_state(thermal->pinctrl, thermal->otp_state);
>> And then
>> pinctrl_select_state(thermal->pinctrl, thermal->pinctrl_state);
>
> pinctrl select to otp mode when tsadc resume.
Ok, thanks for clarifying.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2019-04-30 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 10:12 [PATCH v2 0/3] thermal: rockchip: fix up thermal driver Elaine Zhang
2019-04-25 10:12 ` [PATCH v2 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error Elaine Zhang
2019-04-28 12:45 ` Daniel Lezcano
2019-04-29 9:51 ` elaine.zhang
2019-04-30 9:44 ` Daniel Lezcano [this message]
2019-04-25 10:12 ` [PATCH v2 2/3] dt-bindings: rockchip-thermal: Support the PX30 SoC compatible Elaine Zhang
2019-04-25 10:12 ` [PATCH v2 3/3] thermal: rockchip: Support the PX30 SoC in thermal driver Elaine Zhang
2019-04-25 10:12 ` [PATCH v3 0/4] clk: rockchip: support clock controller for px30 SoC Elaine Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70cc3a91-8f5d-da48-a815-eaf2670f9a93@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=xf@rock-chips.com \
--cc=xxx@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®