mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Alastair D'Silva <alastair@d-silva.org>,
	<linux-wireless@vger.kernel.org>,
	Ping-Ke Shih <pkshih@realtek.com>, Kalle Valo <kvalo@kernel.org>
Cc: Luka Gejak <luka.gejak@linux.dev>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Ulf Hansson <ulfh@kernel.org>, <linux-kernel@vger.kernel.org>,
	Alastair D'Silva <alastair@d-silva.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH rtw-next v11 1/4] wifi: rtw88: sdio: Handle allocation and read errors in rtw_sdio_rxfifo_recv
Date: Wed, 18 Nov 2026 09:58:53 +0800	[thread overview]
Message-ID: <70dc30d9-a615-4a0a-9ee6-228d079c1bf5@RTKEXHMBS05.realtek.com.tw> (raw)
In-Reply-To: <20261117101347.2157211-2-alastair@d-silva.org>

Alastair D'Silva <alastair@d-silva.org> wrote:

> When dev_alloc_skb() or rtw_sdio_read_port() fails, rtw_sdio_rxfifo_recv()
> returns without reading data. Because it returned void, the caller still
> counted rx_len against the loop budget while leaving data stranded in the
> FIFO.
> 
> Return an error code from rtw_sdio_rxfifo_recv() on failure and break out
> of the receive loop in the caller immediately.
> 
> Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets")
> Cc: stable@vger.kernel.org
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
> Signed-off-by: Alastair D'Silva <alastair@d-silva.org>

4 patch(es) applied to rtw-next branch of rtw.git, thanks.

2fc87b00daf2 wifi: rtw88: sdio: Handle allocation and read errors in rtw_sdio_rxfifo_recv
07eb79021ca5 wifi: rtw88: sdio: Track running state and cancel TX worker on stop
a468dc94161a wifi: rtw88: sdio: Fix unhandled RX request interrupt storm
6f51fced1eaf wifi: rtw88: sdio: Split rtw_sdio_rx_isr into 8051 and 3081 variants

---
https://github.com/pkshih/rtw.git


  reply	other threads:[~2026-11-18  1:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 10:13 [PATCH rtw-next v11 0/4] wifi: rtw88: sdio: Fix unhandled RX request interrupt storm Alastair D'Silva
2026-11-17 10:13 ` [PATCH rtw-next v11 1/4] wifi: rtw88: sdio: Handle allocation and read errors in rtw_sdio_rxfifo_recv Alastair D'Silva
2026-11-18  1:58   ` Ping-Ke Shih [this message]
2026-11-17 10:13 ` [PATCH rtw-next v11 2/4] wifi: rtw88: sdio: Track running state and cancel TX worker on stop Alastair D'Silva
2026-11-17 10:13 ` [PATCH rtw-next v11 3/4] wifi: rtw88: sdio: Fix unhandled RX request interrupt storm Alastair D'Silva
2026-11-17 10:13 ` [PATCH rtw-next v11 4/4] wifi: rtw88: sdio: Split rtw_sdio_rx_isr into 8051 and 3081 variants Alastair D'Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70dc30d9-a615-4a0a-9ee6-228d079c1bf5@RTKEXHMBS05.realtek.com.tw \
    --to=pkshih@realtek.com \
    --cc=alastair@d-silva.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luka.gejak@linux.dev \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=stable@vger.kernel.org \
    --cc=ulfh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®