From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6EA6ECDE43 for ; Fri, 19 Oct 2018 12:02:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7602921479 for ; Fri, 19 Oct 2018 12:02:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7602921479 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=opensource.cirrus.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727650AbeJSUIm (ORCPT ); Fri, 19 Oct 2018 16:08:42 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:41016 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727282AbeJSUIl (ORCPT ); Fri, 19 Oct 2018 16:08:41 -0400 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.0.23/8.16.0.23) with SMTP id w9JBhmI3015908; Fri, 19 Oct 2018 07:02:47 -0500 Authentication-Results: ppops.net; spf=none smtp.mailfrom=rf@opensource.cirrus.com Received: from mail4.cirrus.com ([87.246.98.35]) by mx0a-001ae601.pphosted.com with ESMTP id 2n3e40s0cp-1; Fri, 19 Oct 2018 07:02:46 -0500 Received: from EX17.ad.cirrus.com (unknown [172.20.9.81]) by mail4.cirrus.com (Postfix) with ESMTP id BE6D2611C8B8; Fri, 19 Oct 2018 07:05:37 -0500 (CDT) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.408.0; Fri, 19 Oct 2018 13:02:44 +0100 Received: from [198.90.251.121] (edi-sw-dsktp006.ad.cirrus.com [198.90.251.121]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id w9JC2jW4010962; Fri, 19 Oct 2018 13:02:45 +0100 Subject: Re: [PATCH v3 4/5] regulator: lochnagar: Add support for the Cirrus Logic Lochnagar To: Mark Brown , Charles Keepax CC: , , , , , , , , , , , References: <20181019095003.26046-1-ckeepax@opensource.cirrus.com> <20181019095003.26046-4-ckeepax@opensource.cirrus.com> <20181019112622.GB5895@sirena.org.uk> From: Richard Fitzgerald Message-ID: <70dcdc5d-73c2-d26f-6228-4bb0bb8ef612@opensource.cirrus.com> Date: Fri, 19 Oct 2018 13:02:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20181019112622.GB5895@sirena.org.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810190107 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/10/18 12:26, Mark Brown wrote: > On Fri, Oct 19, 2018 at 10:50:02AM +0100, Charles Keepax wrote: > > Please do not submit new versions of already applied patches, please > submit incremental updates to the existing code. Modifying existing > commits creates problems for other users building on top of those > commits so it's best practice to only change pubished git commits if > absolutely essential. > >> +++ b/drivers/regulator/lochnagar-regulator.c >> @@ -0,0 +1,255 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Lochnagar regulator driver > > Please don't mix C and C++ comments like this in the same block, just > have it be a C++ block so it looks consistent. > Most SPDX headers on C files that I've looked at have it this way with a C++ style comment above a C-style comment, though some don't. license-rules.rst doesn't define how or if a SPDX comment line should be merged with the following file header comment. I've had a bunch of patches in different subsystems all accepted with this mixed format (copied from existing files). Doing the same as existing files sounds reasonable but often isn't in the Linux kernel. It's a common problem/barrier to kernel programming that existing code isn't a guide and there isn't a consistent style across the kernel so one never really knows what the coding style is until you've pushed a patch and annoyed a maintainer. And then you adopt that style on your next patch and annoy different maintainer. Maybe someone should update license-rules.rst to make a definite statement of the style instead of leaving it to become another style that varies across the kernel and between files.