From: Dmitry Antipov <dmantipov@yandex.ru>
To: Fedor Pchelkin <pchelkin@ispras.ru>,
Christian Lamparter <chunkeey@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Christian Lamparter <chunkeey@googlemail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: carl9170: do not ping device which has failed to load firmware
Date: Mon, 16 Jun 2025 13:01:32 +0300 [thread overview]
Message-ID: <70de6013-a5db-45c6-8288-e7b211a55a1e@yandex.ru> (raw)
In-Reply-To: <3qom4fkg7kp4l3bcgrbivmm2yi2wqrmso7rb5qe3xffjj3k7hz@nc7gx4atzfyq>
On 6/15/25 10:54 PM, Fedor Pchelkin wrote:
> So it looks like ar->registered being false here is a "correct" failure
> condition, i.e. it can be expected when the certain phase of the driver
> initialization fails and should be handled without any WARNs.
Looking through Documentation/process/coding-style.rst, it may be
better to use pr_warn_once() instead; anyway I would prefer leave
the final decision to the maintainer.
Dmitry
next prev parent reply other threads:[~2025-06-16 10:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <12719f87-ce87-4614-a34e-5f05efd55121@gmail.com>
2025-06-15 19:54 ` Fedor Pchelkin
2025-06-16 10:01 ` Dmitry Antipov [this message]
2025-06-16 16:55 ` Christian Lamparter
2025-06-16 18:12 ` [PATCH v2] " Dmitry Antipov
2025-06-17 6:18 ` Christian Lamparter
2025-06-17 23:32 ` Jeff Johnson
[not found] <y4ufvifcearf75qds5hlro3rfiadwfwlixz5xg3w6jjozk5sdg@7yyfsdvyehon>
2025-06-14 16:33 ` [PATCH] " Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70de6013-a5db-45c6-8288-e7b211a55a1e@yandex.ru \
--to=dmantipov@yandex.ru \
--cc=chunkeey@gmail.com \
--cc=chunkeey@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pchelkin@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®