mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@kernel.org>
To: x86@kernel.org
Cc: david@saggiorato.net, Borislav Petkov <bp@alien8.de>,
	Brian Gerst <brgerst@gmail.com>,
	linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>
Subject: [PATCH 2/3] x86/boot: Fix another __read_cr4() case on 486
Date: Wed, 28 Sep 2016 12:34:15 -0700	[thread overview]
Message-ID: <70dfb68f8f312764d5f6aca6e2aa6d7dc76df6e4.1475091074.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1475091074.git.luto@kernel.org>
In-Reply-To: <cover.1475091074.git.luto@kernel.org>

The condition for reading CR4 was wrong: there are some CPUs with
CPUID but not CR4.  Rather than trying to make the condition exact,
using __read_cr4_safe().

Reported-by: david@saggiorato.net
Fixes: 18bc7bd523e0 ("x86/boot: Synchronize trampoline_cr4_features and mmu_cr4_features directly")
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
 arch/x86/kernel/setup.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 0fa60f5f5a16..5930a4d191b4 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -1137,9 +1137,13 @@ void __init setup_arch(char **cmdline_p)
 	 * auditing all the early-boot CR4 manipulation would be needed to
 	 * rule it out.
 	 */
-	if (boot_cpu_data.cpuid_level >= 0)
-		/* A CPU has %cr4 if and only if it has CPUID. */
-		mmu_cr4_features = __read_cr4();
+	if (boot_cpu_data.cpuid_level >= 0) {
+		/*
+		 * CPUs without CPUID don't have CR4.  CPUs with CPUID
+		 * usually have CR4.
+		 */
+		mmu_cr4_features = __read_cr4_safe();
+	}
 
 	memblock_set_current_limit(get_max_mapped());
 
-- 
2.7.4

  parent reply	other threads:[~2016-09-28 19:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 19:34 [PATCH 0/3] CR4 fixes (some are urgent) Andy Lutomirski
2016-09-28 19:34 ` [PATCH 1/3] x86/init: Fix cr4_init_shadow() on CR4-less machines Andy Lutomirski
2016-09-29 11:44   ` Borislav Petkov
2016-09-29 18:21   ` [tip:x86/urgent] " tip-bot for Andy Lutomirski
2016-09-28 19:34 ` Andy Lutomirski [this message]
2016-09-29 11:48   ` [PATCH 2/3] x86/boot: Fix another __read_cr4() case on 486 Borislav Petkov
2016-09-29 19:09     ` Andy Lutomirski
2016-09-28 19:34 ` [PATCH 3/3] x86/asm: Get rid of __read_cr4_safe() Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70dfb68f8f312764d5f6aca6e2aa6d7dc76df6e4.1475091074.git.luto@kernel.org \
    --to=luto@kernel.org \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=david@saggiorato.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®