From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755593AbdDMBDv (ORCPT ); Wed, 12 Apr 2017 21:03:51 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:53085 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754767AbdDMBDt (ORCPT ); Wed, 12 Apr 2017 21:03:49 -0400 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a59-f79166d0000017ce-8b-58eece729cb3 Subject: Re: [PATCH 1/2] phy: qcom-usb-hs: Replace the extcon API To: kishon@ti.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, chanwoo@kernel.org From: Chanwoo Choi Organization: Samsung Electronics Message-id: <70e6a8f3-4426-4b63-75a2-e55616ec33f3@samsung.com> Date: Thu, 13 Apr 2017 10:03:46 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 In-reply-to: <1490675909-2533-1-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLKsWRmVeSWpSXmKPExsWy7bCmpm7RuXcRBjdWqFpMvHGFxeLC0x42 i02Pr7FaXN41h82BxWPTqk42j81L6j2O39jO5PF5k1wAS1SqTUZqYkpqkUJqXnJ+SmZeuq2S d3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QRiWFssScUqBQQGJxsZK+nU1RfmlJqkJG fnGJrVK0oaGRnqGBuZ6RkZGeiXGslZEpUElCasaD1a9YCibxV9zcOJuxgXElTxcjB4eEgInE oYNSXYycQKaYxIV769m6GLk4hASWMkrs2fWNHcJpZ5KY8/EfI0SVicT11S9ZIRLLGSVmXtzI DpLgFRCU+DH5HguIzSygKbF193qo7nuMEh3/1jOBJIQFHCV2bjzOBrJaBKjh0ydGiPoYiTWr ulhBbDYBLYn9L26wgdj8AooSV388ZoSYbyexeXMj2BgWAVWJzRMuMoOMERWIkOg/ow4S5hRw lVg8eRbUSHmJzWveMoOcICEwmV3i5fR7TBAfy0psOsAMYbpIvJ5qC/GWsMSr41vYIWxpib9L bzFCtLYzSmyeA/IWiNPBKHF/ZSMrRJWxxP0H95ghlvFJ9P5+AjWfV6KjTQiixENizYfXLBC2 o0Tbt7nQ0J0BDN2Ns5gnMCrMQgq6WUhBNwvJDwsYmVcxiqUWFOempxabFpjqFSfmFpfmpesl 5+duYgQnPa3IHYxXZgYdYhTgYFTi4d0Q/C5CiDWxrLgy9xCjBAezkghvxSmgEG9KYmVValF+ fFFpTmrxIUZTYFBOZJYSTc4HJuS8knhDE0sDE1MzYwNjQwtLJXFejZXXIoQE0hNLUrNTUwtS i2D6mDg4pRoYsyx6J/k0XnvTZP1V4Na/09fLl29/r9qzTILz9tugKdXHKxSn/Nm8NK23qsmh 3/feCZPOI3qfjoZsln73u9/k0s26Kb5XVZj/L3P8lNykqeKjaLkjSmxd/pO7RdMPvy5uiJS7 dsb+5/Te/FkLu3Qet5SIWp74M+mHyAfhWV83WKyfWJBmdim9UomlOCPRUIu5qDgRABE0L6mQ AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDIsWRmVeSWpSXmKPExsVy+t9jAd2ic+8iDM6vEbWYeOMKi8WFpz1s FpseX2O1uLxrDpsDi8emVZ1sHpuX1Hscv7GdyePzJrkAlig3m4zUxJTUIoXUvOT8lMy8dFul 0BA3XQslhbzE3FRbpQhd35AgJYWyxJxSIM/IAA04OAe4Byvp2yW4ZTxY/YqlYBJ/xc2Nsxkb GFfydDFyckgImEhcX/2SFcIWk7hwbz1bFyMXh5DAUkaJNbO+MoIkeAUEJX5MvscCYjMLqEtM mreIGaLoAaNEz8UNzCAJYQFHiZ0bjwN1c3CIADV8+sQIUTOLUaJ5z0eo5hiJ1glTmUBsNgEt if0vbrCB2PwCihJXfzyGWmYnsXlzI1gNi4CqxOYJF8HmiwpESNx62AE2h1PAVWLx5FmMEDPl JTavecs8gVFwFpJbZyG5dRaSsgWMzKsYJVILkguKk9JzjfJSy/WKE3OLS/PS9ZLzczcxgmPq mfQOxsO73A8xCnAwKvHwFki/ixBiTSwrrsw9xCjBwawkwltxCijEm5JYWZValB9fVJqTWnyI 0RTo4InMUqLJ+cB4zyuJNzQxNzE3NrAwt7Q0MVIS522c/SxcSCA9sSQ1OzW1ILUIpo+Jg1Oq gXHGG2b2Q787aibbsX9O5b/uuU3qsVfq5ylG0svUdz/NXfuvh/nK95BT1wIMI5dm/l8kVbso fvX+SAPt1y+u76r6dpkxma3oZPqiLazKM7eGff34OpP1p+BPQdUF97Oa7ZxfXDZrbapcO9Fh b+LadVy/7hp6dfneUFSrKX85/1dI+PTJE1vsWLYosRRnJBpqMRcVJwIADn2+ir8CAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170413010346epcas5p43d58eb2d0dbc5643e4c49deff919cabb X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170328043830epcas1p4069bda461ad648cfd6598905b7167e9f X-RootMTR: 20170328043830epcas1p4069bda461ad648cfd6598905b7167e9f References: <1490675909-2533-1-git-send-email-cw00.choi@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kishon, Could you please review these patches? On 2017년 03월 28일 13:38, Chanwoo Choi wrote: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - (deprecated) extcon_get_cable_state_() -> extcon_get_state() > > Cc: Kishon Vijay Abraham I > Signed-off-by: Chanwoo Choi > --- > drivers/phy/phy-qcom-usb-hs.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git a/drivers/phy/phy-qcom-usb-hs.c b/drivers/phy/phy-qcom-usb-hs.c > index 94dfbfd739c3..f630fa553b7d 100644 > --- a/drivers/phy/phy-qcom-usb-hs.c > +++ b/drivers/phy/phy-qcom-usb-hs.c > @@ -156,12 +156,12 @@ static int qcom_usb_hs_phy_power_on(struct phy *phy) > } > > if (uphy->vbus_edev) { > - state = extcon_get_cable_state_(uphy->vbus_edev, EXTCON_USB); > + state = extcon_get_state(uphy->vbus_edev, EXTCON_USB); > /* setup initial state */ > qcom_usb_hs_phy_vbus_notifier(&uphy->vbus_notify, state, > uphy->vbus_edev); > - ret = extcon_register_notifier(uphy->vbus_edev, EXTCON_USB, > - &uphy->vbus_notify); > + ret = devm_extcon_register_notifier(&ulpi->dev, uphy->vbus_edev, > + EXTCON_USB, &uphy->vbus_notify); > if (ret) > goto err_ulpi; > } > @@ -180,16 +180,8 @@ static int qcom_usb_hs_phy_power_on(struct phy *phy) > > static int qcom_usb_hs_phy_power_off(struct phy *phy) > { > - int ret; > struct qcom_usb_hs_phy *uphy = phy_get_drvdata(phy); > > - if (uphy->vbus_edev) { > - ret = extcon_unregister_notifier(uphy->vbus_edev, EXTCON_USB, > - &uphy->vbus_notify); > - if (ret) > - return ret; > - } > - > regulator_disable(uphy->v3p3); > regulator_disable(uphy->v1p8); > clk_disable_unprepare(uphy->sleep_clk); > -- Best Regards, Chanwoo Choi Samsung Electronics