From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31656C10DC1 for ; Fri, 8 Dec 2023 12:18:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233583AbjLHMSO convert rfc822-to-8bit (ORCPT ); Fri, 8 Dec 2023 07:18:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233394AbjLHMSJ (ORCPT ); Fri, 8 Dec 2023 07:18:09 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AAFBAD; Fri, 8 Dec 2023 04:18:14 -0800 (PST) Received: from kwepemi100025.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Smqss6lqGzsRwD; Fri, 8 Dec 2023 20:18:09 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by kwepemi100025.china.huawei.com (7.221.188.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 8 Dec 2023 20:18:11 +0800 Received: from dggpemm500006.china.huawei.com ([7.185.36.236]) by dggpemm500006.china.huawei.com ([7.185.36.236]) with mapi id 15.01.2507.035; Fri, 8 Dec 2023 20:18:10 +0800 From: "Gonglei (Arei)" To: Herbert Xu CC: "linux-crypto@vger.kernel.org" , "Michael S. Tsirkin" , Jason Wang , "virtualization@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , wangyangxin , "Halil Pasic" Subject: RE: [PATCH v2] crypto: virtio-crypto: Handle dataq logic with tasklet Thread-Topic: [PATCH v2] crypto: virtio-crypto: Handle dataq logic with tasklet Thread-Index: AdooOneOWI65hKIST2yjTeZdqptiyQBCQ+6AACMBjtA= Date: Fri, 8 Dec 2023 12:18:10 +0000 Message-ID: <70ea58a0776e4ba2a38658047d188688@huawei.com> References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.149.11] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Herbert Xu [mailto:herbert@gondor.apana.org.au] > Sent: Friday, December 8, 2023 11:28 AM > To: Gonglei (Arei) > Cc: linux-crypto@vger.kernel.org; Michael S. Tsirkin ; Jason > Wang ; virtualization@lists.linux-foundation.org; > linux-kernel@vger.kernel.org; wangyangxin ; > Halil Pasic > Subject: Re: [PATCH v2] crypto: virtio-crypto: Handle dataq logic with tasklet > > On Wed, Dec 06, 2023 at 11:52:51AM +0000, Gonglei (Arei) wrote: > > Doing ipsec produces a spinlock recursion warning. > > This is due to crypto_finalize_request() being called in the upper half. > > Move virtual data queue processing of virtio-crypto driver to tasklet. > > > > Fixes: dbaf0624ffa5 ("crypto: add virtio-crypto driver") > > Reported-by: Halil Pasic > > Signed-off-by: wangyangxin > > Signed-off-by: Gonglei > > --- > > v2: calling tasklet_kill() in virtcrypto_remove(), thanks for MST. > > > > drivers/crypto/virtio/virtio_crypto_common.h | 2 ++ > > drivers/crypto/virtio/virtio_crypto_core.c | 26 > ++++++++++++++++---------- > > 2 files changed, 18 insertions(+), 10 deletions(-) > > Your patch has already been merged. So please send this as an incremental > patch. > OK. No problem. Regards, -Gonglei > Thanks, > -- > Email: Herbert Xu Home Page: > http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt