From: Hannes Reinecke <hare@suse.de>
To: Mark O'Donovan <shiftee@posteo.net>, linux-kernel@vger.kernel.org
Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de,
axboe@kernel.dk, kbusch@kernel.org
Subject: Re: [PATCH v3 3/3] nvme-auth: always set valid seq_num in dhchap reply
Date: Wed, 25 Oct 2023 12:56:41 +0200 [thread overview]
Message-ID: <70ec751d-8aba-42b4-861c-e7e17c4a7476@suse.de> (raw)
In-Reply-To: <20231025105125.134443-4-shiftee@posteo.net>
On 10/25/23 12:51, Mark O'Donovan wrote:
> Currently a seqnum of zero is sent during uni-directional
> authentication. The zero value is reserved for the secure channel
> feature which is not yet implemented.
>
> Relevant extract from the spec:
> The value 0h is used to indicate that bidirectional authentication
> is not performed, but a challenge value C2 is carried in order to
> generate a pre-shared key (PSK) for subsequent establishment of a
> secure channel
>
> Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> ---
> v1: used incorrect prefix nvme-tcp
> v2: added spec extract to commit message
> v3: read the seq-num in nvme-target code
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
next prev parent reply other threads:[~2023-10-25 10:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 10:51 [PATCH v3 0/3] nvme-tcp: " Mark O'Donovan
2023-10-25 10:51 ` [PATCH v3 1/3] nvme-auth: auth success1 msg always includes resp Mark O'Donovan
2023-10-25 10:51 ` [PATCH v3 2/3] nvme-auth: add flag for bi-directional auth Mark O'Donovan
2023-10-25 10:56 ` Hannes Reinecke
2023-10-25 10:51 ` [PATCH v3 3/3] nvme-auth: always set valid seq_num in dhchap reply Mark O'Donovan
2023-10-25 10:56 ` Hannes Reinecke [this message]
2023-11-06 16:36 ` [PATCH v3 0/3] nvme-tcp: " Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70ec751d-8aba-42b4-861c-e7e17c4a7476@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shiftee@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®