Re: [PATCH 3/3] arm64: dts: nuvoton: Add initial support for MA35D1

[Jacky Huang <ychuang3@nuvoton.com>]

On 2022/4/6 下午 05:40, Arnd Bergmann wrote:
> On Wed, Apr 6, 2022 at 11:25 AM Jacky Huang <ychuang3@nuvoton.com> wrote:
>> On 2022/4/6 下午 03:14, Krzysztof Kozlowski wrote:
>>> On 06/04/2022 04:58, Jacky Huang wrote:
>>>> config ARCH_MA35D1
>>>>        bool "Nuvoton MA35D1 SOC Family"
>>> We do not add options for specific SoCs, but for entire families, so
>>> ARCH_NUVOTON is correct.
>> Yes, I would like to modify it as the following:
>>
>> config ARCH_NUVOTON
>>       bool "Nuvoton SoC Family"
>>       select PINCTRL
>>       select PINCTRL_MA35D1
>>       select PM
>>       select GPIOLIB
>>       select SOC_BUS
>>       help
>>         This enables support for Nuvoton MA35D1 ARMv8 SoC.
>>
>> (Currently, we have MA35D1 only in the support list for arm64 SoC.).
> You could reword this to "This enables support for Nuvoton ARMv8 SoCs
> such as the MA35D1", to prevent this from getting stale, or repeatedly
> updated when future SoCs are added.
>
> Another change you can consider is to remove the 'select PINCTRL_MA35D1'
> here and instead change the pinctrl Kconfig entry to
>
> config PINCTRL_MA35D1
>             bool "..."
>             depends on ARCH_NUVOTON || COMPILE_TEST
>             default ARCH_NUVOTON
>
> That way you get it default-enabled when ARCH_NUVOTON is
> turned on, or disabled in configurations without ARCH_NUVOTON,
> but can make a more fine-grained selection for a particular SoC
> if you get more than one such driver in the future.
>
>          Arnd

Yes, it looks better.
So, I will modify it as:

config ARCH_NUVOTON
     bool "Nuvoton SoC Family"
     select PINCTRL
     select PM
     select GPIOLIB
     select SOC_BUS
     help
       This enables support for Nuvoton MA35D1 ARMv8 SoC such as MA35D1.

And move PINCTRL_MA35D1 to pinctrl Kconfig when we submit the pictrl 
driver.

Thanks you.

Jacky