From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC43E3AFAF9 for ; Mon, 6 Jul 2026 04:02:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783310541; cv=none; b=Opczm1wU3kLqPQQrhlQ63CCASMAHmGCnAi1zDiGRjjSJkLg3ul3uVPPW05fzy+prx15XACcRjAtX57KAoTp1G94lBUKn/DQtaWFT13GnPTw8WXZz5XBgE3z8fDY6Es9ZxgUOSipQSiomvsNCYWuaUx9YO0q9NkmnxeHJ0unmssg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783310541; c=relaxed/simple; bh=/zEYG/OBL95Gx+ohWenrEwBrbR/oRwYUWrQ9Ykaz6mc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WFnCd0rcVEEt/odFMf2gpyideEr77GIml5cfQLTsLiCYeM8MQXFhaNKupknK9+3kXAQSuhxIvP1NJLOCzd1ndoT6kAuwmPt+TQU0V2g55cVE3FMSfJPoHvAdRts7vCkYzF+wJhythrjqCP7H5JV0qxpKG36UJIIb0kH/9rg8354= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=l+8T7Kr/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dP1rIobj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="l+8T7Kr/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dP1rIobj" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66641TAi3615451 for ; Mon, 6 Jul 2026 04:02:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xYD6MPNhjaepPf2j/e7u1phNicmKefuDIWGw2TPtec0=; b=l+8T7Kr/uK4TBVTU Pcq2uNQWgznHCUVF8Qmxsw67O2OAN+nsf6KRaiPXzLCONsxvRKUZ4vI+yl99aJrq tVpZERs5rRgBWlIROjEBXbuTDLMgxDOn7H8npFh/Ymse+K3bomTsmztmn5Rwk73j nkyY38gI8nAyl94Re7RikK+nYVm907iR3A8S+vxeBgIVmbRxLwnTWT3UVB9nurhA 4P4qYnZntKBVE33u8YDID2KTUtFHPJuU2RCkYlyO330kFpDeq5ismBB1OysQ/ATg xEZe5gS8IrSeDF7jyPn64X5Lcbnp9BsHTlpCyvFaLYHAXYdIEBsBBSbK8Ggkm2Bl gsaPcA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6td3c889-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 04:02:18 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2c354050c34so26794235ad.3 for ; Sun, 05 Jul 2026 21:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783310538; x=1783915338; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xYD6MPNhjaepPf2j/e7u1phNicmKefuDIWGw2TPtec0=; b=dP1rIobjLPLaXRzdlfDJaOiK4aqfsoTY6unyX6hIiR4S3/phMBh8wPu+Rq2Hg9yy9l 38pTTtHEV2VpndTv/6JQfnAQRnwLHvQS7rrwT5/MtB63hlqXMLIyFQBNNHvC1nxGbSNq fEBxNHgaiEW4xpcFtVywL913hP/DEVnuYP5khCILcn+nsolJ3+RvzLOG8RE9LPr2Wsrj HEpy5+m/pdi9IMsQSpRkXpQOobG6xToaNjokxnu9FUO/1hrEGx0ZtUFKEYAbiaquayC+ 9Ull9Ly5m4cX18Yava1EJa7V6fYVC1Xi5I87SMlM/OOqo/U9o5LANikJXrJPi2jrZzOH b9eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783310538; x=1783915338; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xYD6MPNhjaepPf2j/e7u1phNicmKefuDIWGw2TPtec0=; b=cqYJonE6GfUPeWJnORYsRl7UcBM2UaD+somTW3KKAQlhqtb9DXLuLanLCLw4jufSXE LIF5yEM4dmYL9Cog4K4wH9TTv5oBoPEuOSk1amT7g20rOetoK2JJZzR0RTQQiys96Tgk S6EPTW28JmFmnTEReU0y8wRah9bTVAM6988ouTZyWpmjCnYc3KV8rtLVulwDhBJaqNgQ Wd3P1O7lqsI2BlHAklJOD+HHuV01dKND6B8CchainfdJovyebaiMsmH1J2KQf8sejne1 27LkDCGO7ajNxqMa5iolWbBlNKED3x5H5IOEzW8DfXUZoKZWRVgondziOL2PfeAUqHi9 ybIQ== X-Forwarded-Encrypted: i=1; AHgh+Roj1ZVVeLZ+xbasQnrcxch2eFT0koK7P74V0QSwZdi8wyeQjvqm5g8xC4af+SG00FOiutiOjp0q0xvOhP8=@vger.kernel.org X-Gm-Message-State: AOJu0YzZI9CIJ7MEGyj0jV+KIEGTp7+zVfBH7zGcAs2EPtKK1UfOxTec 3aS2RzyvlCxfuND8nYLG8irkXHdMXdBoKjgRctRQ5gy9rn2+34FikbiZWnDl8KCUhGzBctjlPQp XdRpj5NxAxvs5Xm4bGSQbSoj14Ttkqq4/8oUxXQx8JEI30GIsMl+0uoHbC9bcGaMfkGVWL03go8 Z8YQ== X-Gm-Gg: AfdE7cmmf5jg4HPc+iVZfSoBsOVUwl7UO+gNue0EKo6GsdGJuKOwxXdwvlcahLzX1Ud nlIR+m1KtQ3+VsREEUgHkMxhB6Lw2Px9mgXwkBO2cvTjgwHypf7BD20IWJRfs7FDo3m1b7r24sr wM3sD1nCBlbQ4pBoimHY2iEuqNur9AbjI/IiEUIs5luu/oKQEnoPBLu9+QUZFKwwckbRjCJHNK5 VLLdXksw0rWhQc/S94dBYb4ggTt95ZgQTBO31dunYzu/UIAJFFr/nvfasJjP+4oeYcngyrF4aKG xKbB75CjCov07khg3Upp2/eBAAwM3Jtpsb1ttZ5SSBFwRmEgJEp+dK9RYCpYprnV//aNCEqWTcM XsUrLnuPAeX13sgHBXlPop4Ar8Mwyy2jjwSIPsW7C5+L68wW1BCv/d5pztvGKZuojnBcFwDrebT qzvw== X-Received: by 2002:a17:902:e78b:b0:2cc:98b4:e7e2 with SMTP id d9443c01a7336-2cc98b4e9b8mr26412335ad.44.1783310538323; Sun, 05 Jul 2026 21:02:18 -0700 (PDT) X-Received: by 2002:a17:902:e78b:b0:2cc:98b4:e7e2 with SMTP id d9443c01a7336-2cc98b4e9b8mr26412065ad.44.1783310537847; Sun, 05 Jul 2026 21:02:17 -0700 (PDT) Received: from ?IPV6:240e:45b:7f94:5e4f:58a7:34e3:be58:6dcf? ([240e:45b:7f94:5e4f:58a7:34e3:be58:6dcf]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cad7765773sm42121215ad.40.2026.07.05.21.02.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jul 2026 21:02:17 -0700 (PDT) Message-ID: <70ef1fd5-ec5f-40e2-b5fc-f8e1978bc87d@oss.qualcomm.com> Date: Mon, 6 Jul 2026 12:02:08 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] cpufreq: apple-soc: Calculate frequency as a 64-bit value To: Sasha Finkelstein , Sven Peter , Janne Grunau , Neal Gompa , "Rafael J. Wysocki" , Viresh Kumar Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, zhongqiu.han@oss.qualcomm.com References: <20260703-cpufreq-64-v1-1-c406c705319a@chaosmail.tech> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <20260703-cpufreq-64-v1-1-c406c705319a@chaosmail.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDAzNiBTYWx0ZWRfX2XlD9xvS67Nu 1QzNx5/kakhTsuiBE0QnpRY6m9fhd650uR0kXAYbywyc3TdiUh6yZ/BGrWJwYTv6dBbTyr9ztdO IbByVlEWwCDBuLLOu72c8EDoEBg1J9M= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDAzNiBTYWx0ZWRfXxJt5p2gd9Nye ihWMJirLdNYunuFGiW6jZN/0LasCIf1xlQU8I5eb8kwXQyNlsQ7QZ+yOp1X/xYCkLA4+1wNJIZn BVjmnGw09G+xhIM9pUGlpkZHo5W3gPyHUOx0bKK2cVFb2R3CCq7XbZsxh/IdRz4K7BiduVIfbGN dXJ3LUDMuC5DrVoczAvsjJxBeLPUHkzB9tEKvsleOwk36egd7+aioj0p5/DUemwVq+cCNHnfIgM PsTy4sXJHjDA6Sco2qIOjfYyFYfUnQWLuy82l00o6cgKDWDOmEiwKT/t/jxcNv1ZlpWGkDHuk5u 0DThhNZN/1/XgnnMqZVVP2iJl03FX/f4psTsA0wCUdZgORSNKChXsyv2eGekh1wfjW/DRFQLLfh b5JqMHaX8u9DAUvKINYnl1LWAr96hkdxV2b/wFk3xOkcU5UnT6C/aBkbvmQQBIR10U53YQE4OiY MXArTfUN0adcelnRqYg== X-Proofpoint-GUID: rV6tmf7NfSCTokriMoMHIaW_FBH7zXzE X-Proofpoint-ORIG-GUID: rV6tmf7NfSCTokriMoMHIaW_FBH7zXzE X-Authority-Analysis: v=2.4 cv=b9GCJNGx c=1 sm=1 tr=0 ts=6a4b28cb cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=xkNotnLeK6pRB5HCSP8A:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060036 On 7/4/2026 2:52 AM, Sasha Finkelstein wrote: > The current frequency calculation is done in 32 bit, causing problems > if run on a future SoC that can boost higher than 4.2GHz. Hi Sasha, > > Signed-off-by: Sasha Finkelstein > --- > drivers/cpufreq/apple-soc-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/apple-soc-cpufreq.c b/drivers/cpufreq/apple-soc-cpufreq.c > index 638e5bf72185..6a0f1d36578f 100644 > --- a/drivers/cpufreq/apple-soc-cpufreq.c > +++ b/drivers/cpufreq/apple-soc-cpufreq.c > @@ -288,7 +288,7 @@ static int apple_soc_cpufreq_init(struct cpufreq_policy *policy) > > /* Get OPP levels (p-state indexes) and stash them in driver_data */ > for (i = 0; freq_table[i].frequency != CPUFREQ_TABLE_END; i++) { > - unsigned long rate = freq_table[i].frequency * 1000 + 999; > + unsigned long rate = freq_table[i].frequency * 1000UL + 999UL; A couple of minor comments: 1. The `999UL` doesn't seem necessary, since the multiplication is already carried out in `unsigned long` due to `1000UL`, and the constant would be promoted automatically. 2. David's point about using `unsigned long` for frequencies is worth considering. That said, the type here is effectively dictated by the OPP API (`dev_pm_opp_find_freq_floor()` takes an `unsigned long *`), and this driver already depends on 64BIT, so the proposed change seems reasonable to me in practice. > struct dev_pm_opp *opp = dev_pm_opp_find_freq_floor(cpu_dev, &rate); > > if (IS_ERR(opp)) { > > --- > base-commit: 4a50a141f05a8d1737661b19ee22ff8455b94409 > change-id: 20260703-cpufreq-64-2a23d7261e09 > > Best regards, > -- > Sasha Finkelstein > > -- Thx and BRs, Zhongqiu Han