From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA58C433E0 for ; Thu, 11 Mar 2021 16:14:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14A6064FE2 for ; Thu, 11 Mar 2021 16:14:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234505AbhCKQOF (ORCPT ); Thu, 11 Mar 2021 11:14:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:50800 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234334AbhCKQNm (ORCPT ); Thu, 11 Mar 2021 11:13:42 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 706A860241; Thu, 11 Mar 2021 16:03:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615478623; bh=dVsP+STyCM204me9sPtkFjD1L6E5GjVrtXP5uVUENU0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=umpZhUA5RdXY7XEyc6DOL4b2RPOtUkL8zrWWG714WEf9Vs9RdRuAFY3z086hP1lth 1HFQQnMEVsTP93TSPOgjIejya3taNlvc28pOJviNGv+JJ0Kwy/1EZ3i6CGxurOzlQS ByIC935VB/FEzpnoMZ7FTcTUF/JIpD8GoemSn7Wc2jTMO7l+DreUranianOlEndlGM cq76Pksfm6ZgZpr/IR7wZbhBNng3iVzzSwr34ZkDOUHnNkyvRR0LY7boung1RCo7ej 2d617j6alGuNAq79E0mFtvHrSsarkcTAH/5+dV+Lpv3+UH2K5XnHHiqMReCfNlJJvX 0vYfSdEClP22Q== Subject: Re: [PATCH] clk: socfpga: fix iomem pointer cast on 64-bit To: Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Arnd Bergmann References: <20210311144833.1313387-1-krzysztof.kozlowski@canonical.com> From: Dinh Nguyen Message-ID: <70efd621-3125-21a2-cd5a-cc01284f0e75@kernel.org> Date: Thu, 11 Mar 2021 10:03:37 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210311144833.1313387-1-krzysztof.kozlowski@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/11/21 8:48 AM, Krzysztof Kozlowski wrote: > Pointers should be cast to unsigned long instead of integer. This fixes > warning when compile testing on ARM64: > > drivers/clk/socfpga/clk-gate.c: In function ‘socfpga_clk_recalc_rate’: > drivers/clk/socfpga/clk-gate.c:102:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/clk/socfpga/clk-gate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/socfpga/clk-gate.c b/drivers/clk/socfpga/clk-gate.c > index 43ecd507bf83..c876523d5d51 100644 > --- a/drivers/clk/socfpga/clk-gate.c > +++ b/drivers/clk/socfpga/clk-gate.c > @@ -99,7 +99,7 @@ static unsigned long socfpga_clk_recalc_rate(struct clk_hw *hwclk, > val = readl(socfpgaclk->div_reg) >> socfpgaclk->shift; > val &= GENMASK(socfpgaclk->width - 1, 0); > /* Check for GPIO_DB_CLK by its offset */ > - if ((int) socfpgaclk->div_reg & SOCFPGA_GPIO_DB_CLK_OFFSET) > + if ((unsigned long) socfpgaclk->div_reg & SOCFPGA_GPIO_DB_CLK_OFFSET) > div = val + 1; > else > div = (1 << val); > Acked-by: Dinh Nguyen