From: Keerthy <j-keerthy@ti.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Nishanth Menon <nm@ti.com>, <linux-omap@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: palmas: Remove *rdev[PALMAS_NUM_REGS] from struct palmas_pmic
Date: Wed, 13 Mar 2019 10:29:27 +0530 [thread overview]
Message-ID: <70f2fbf5-a2cd-3806-6b94-9ce857845616@ti.com> (raw)
In-Reply-To: <20190310150609.5178-1-axel.lin@ingics.com>
On 10/03/19 8:36 PM, Axel Lin wrote:
> This driver is using devm_regulator_register() so it is not necessary
> to save *rdev for clean up. Actually the pmic->rdev[id] is not used now.
Reviewed-by: Keerthy <j-keerthy@ti.com>
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/palmas-regulator.c | 12 ------------
> include/linux/mfd/palmas.h | 1 -
> 2 files changed, 13 deletions(-)
>
> diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
> index 7fb9e8dd834e..f13c7c8b1061 100644
> --- a/drivers/regulator/palmas-regulator.c
> +++ b/drivers/regulator/palmas-regulator.c
> @@ -991,9 +991,6 @@ static int palmas_ldo_registration(struct palmas_pmic *pmic,
> return PTR_ERR(rdev);
> }
>
> - /* Save regulator for cleanup */
> - pmic->rdev[id] = rdev;
> -
> /* Initialise sleep/init values from platform data */
> if (pdata) {
> reg_init = pdata->reg_init[id];
> @@ -1101,9 +1098,6 @@ static int tps65917_ldo_registration(struct palmas_pmic *pmic,
> return PTR_ERR(rdev);
> }
>
> - /* Save regulator for cleanup */
> - pmic->rdev[id] = rdev;
> -
> /* Initialise sleep/init values from platform data */
> if (pdata) {
> reg_init = pdata->reg_init[id];
> @@ -1288,9 +1282,6 @@ static int palmas_smps_registration(struct palmas_pmic *pmic,
> pdev_name);
> return PTR_ERR(rdev);
> }
> -
> - /* Save regulator for cleanup */
> - pmic->rdev[id] = rdev;
> }
>
> return 0;
> @@ -1395,9 +1386,6 @@ static int tps65917_smps_registration(struct palmas_pmic *pmic,
> pdev_name);
> return PTR_ERR(rdev);
> }
> -
> - /* Save regulator for cleanup */
> - pmic->rdev[id] = rdev;
> }
>
> return 0;
> diff --git a/include/linux/mfd/palmas.h b/include/linux/mfd/palmas.h
> index 75e5c8ff85fc..c34d5f0d34d7 100644
> --- a/include/linux/mfd/palmas.h
> +++ b/include/linux/mfd/palmas.h
> @@ -553,7 +553,6 @@ struct palmas_pmic {
> struct palmas *palmas;
> struct device *dev;
> struct regulator_desc desc[PALMAS_NUM_REGS];
> - struct regulator_dev *rdev[PALMAS_NUM_REGS];
> struct mutex mutex;
>
> int smps123;
>
next prev parent reply other threads:[~2019-03-13 4:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-10 15:06 Axel Lin
2019-03-13 4:59 ` Keerthy [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-05-29 11:01 Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70f2fbf5-a2cd-3806-6b94-9ce857845616@ti.com \
--to=j-keerthy@ti.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®