From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Andi Shyti <andi.shyti@samsung.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Sean Young <sean@mess.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Richard Purdie <rpurdie@rpsys.net>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH v3 5/6] Documentation: bindings: add documentation for ir-spi device driver
Date: Thu, 03 Nov 2016 09:32:54 +0100 [thread overview]
Message-ID: <70f4426b-e2e6-1fb7-187a-65ed4bce0668@samsung.com> (raw)
In-Reply-To: <20161102104010.26959-6-andi.shyti@samsung.com>
Hi Andi,
Only DT bindings of LED class drivers should be placed in
Documentation/devicetree/bindings/leds. Please move it to the
media bindings.
Thanks,
Jacek Anaszewski
On 11/02/2016 11:40 AM, Andi Shyti wrote:
> Document the ir-spi driver's binding which is a IR led driven
> through the SPI line.
>
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> ---
> .../devicetree/bindings/leds/spi-ir-led.txt | 29 ++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/spi-ir-led.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/spi-ir-led.txt b/Documentation/devicetree/bindings/leds/spi-ir-led.txt
> new file mode 100644
> index 0000000..896b699
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/spi-ir-led.txt
> @@ -0,0 +1,29 @@
> +Device tree bindings for IR LED connected through SPI bus which is used as
> +remote controller.
> +
> +The IR LED switch is connected to the MOSI line of the SPI device and the data
> +are delivered thourgh that.
> +
> +Required properties:
> + - compatible: should be "ir-spi-led".
> +
> +Optional properties:
> + - duty-cycle: 8 bit balue that represents the percentage of one period
> + in which the signal is active. It can be 50, 60, 70, 75, 80 or 90.
> + - led-active-low: boolean value that specifies whether the output is
> + negated with a NOT gate.
> + - power-supply: specifies the power source. It can either be a regulator
> + or a gpio which enables a regulator, i.e. a regulator-fixed as
> + described in
> + Documentation/devicetree/bindings/regulator/fixed-regulator.txt
> +
> +Example:
> +
> + irled@0 {
> + compatible = "ir-spi-led";
> + reg = <0x0>;
> + spi-max-frequency = <5000000>;
> + power-supply = <&vdd_led>;
> + led-active-low;
> + duty-cycle = /bits/ 8 <60>;
> + };
>
next prev parent reply other threads:[~2016-11-03 8:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 10:40 [PATCH v3 0/6] Add support for IR transmitters Andi Shyti
2016-11-02 10:40 ` [PATCH v3 1/6] [media] rc-main: assign driver type during allocation Andi Shyti
2016-11-02 10:40 ` [PATCH v3 2/6] [media] rc-main: split setup and unregister functions Andi Shyti
2016-11-02 10:40 ` [PATCH v3 3/6] [media] rc-core: add support for IR raw transmitters Andi Shyti
2016-11-02 12:34 ` kbuild test robot
2016-11-02 10:40 ` [PATCH v3 4/6] [media] rc-ir-raw: do not generate any receiving thread for " Andi Shyti
2016-11-02 10:40 ` [PATCH v3 5/6] Documentation: bindings: add documentation for ir-spi device driver Andi Shyti
2016-11-03 8:32 ` Jacek Anaszewski [this message]
2016-11-03 10:10 ` Andi Shyti
2016-11-03 10:39 ` Jacek Anaszewski
2016-11-04 4:28 ` Andi Shyti
2016-11-09 18:26 ` Rob Herring
2016-11-10 7:46 ` Jacek Anaszewski
2016-11-10 10:02 ` Andi Shyti
2016-11-14 16:10 ` Rob Herring
2016-11-02 10:40 ` [PATCH v3 6/6] [media] rc: add support for IR LEDs driven through SPI Andi Shyti
2016-11-02 17:29 ` [PATCH v3 0/6] Add support for IR transmitters Sean Young
2016-11-02 19:57 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70f4426b-e2e6-1fb7-187a-65ed4bce0668@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®