From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE11B3246FE for ; Tue, 10 Feb 2026 12:54:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770728065; cv=none; b=pRqZlKuGosIT9b+8IpQPqUk31j+cacy/0VG5Ql8ZRNgw5+ycIcwMtyTOHVMnmVJVZVRaIx7aOplr98t25npQivXakq1TUoqoDRN4H4+0xMKubz90vBs1AVCJbCWmNf8p0wQSC9dpP+8QNjriLJwLosp2YbbWSETc17CgFLHYxFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770728065; c=relaxed/simple; bh=pGPCKSabZtVcRb+cQEhkI9+5R4QurfYFV9CKilxFkXE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qo4R0tNWnBEb+eG/ceYyPJmBAI0ueKJkxptB2IPCSMbGugvn2aQszJ/gy64qReTmm2iULHMPYxcHoSev8UpPgOOmIlnYkPULHJoUH7DTtCcU9hTfrmrOMj4tmBNdbYSOPMOMDRriqOwT9pfULm5m3oq+ypZ0W5HoDNRQym5zrN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=KOoJ7aSP; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="KOoJ7aSP" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-436e8758b91so1470853f8f.0 for ; Tue, 10 Feb 2026 04:54:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1770728062; x=1771332862; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XYKGsVU3UU4XnIcrvvCMmqsvjzWxEbaMWjZ9cF9jfTw=; b=KOoJ7aSPDG90rcUysVeLEFbhEb+7tBa0Goi6GV0l91sxpGVHY8qNljjr1/Xnhfi+Y5 V/Y/8Z1xbikObsOEk5HkhscbfeyEWwD2NMSzaALr70ZndoYAJZRWS2qpZdLOO47rMyCb 10hoejjZd99Yh5TViI1kiY7vXsnayI2APl9OJXehaX0SRU9Jc214EEBbe7nb6EVKhsQb kdbODeA+MEHe4rcFvWANziXY+zhqIWs923S0kg1zhMEHDtyyYg33170WQLGlhy2MgcHZ wrRgWoIJujn5+LphxVCqfOTw9gd8P++dEx2YJQCtEFv8TQJRmemD1vTctdektlGqgsK8 XfYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770728062; x=1771332862; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XYKGsVU3UU4XnIcrvvCMmqsvjzWxEbaMWjZ9cF9jfTw=; b=Wkqz9851LRfe7R5bHxXtuwMiZ+lNllC+Raj4TsN2Zo1KfCmHira/7JafISTwWLfLW9 QCkyOuYVioDiu0RidlPSbaXnYBo8UlP9ZEcM2qgVYNtZSZg2y8S+Rc7/uLkBBt3xjVxY z+jj6F5pBcDjK0AlvP53e/vqZxvFr0d+42LhPZKC0uoJc21Db2Q1g/znar77hRYSFspJ Qv/MlVPan9eN8An8yuPuvNmYtXVXCr+/CJwz/AxhKp91vaMQYaZR8pgMhnbXOKU7DFoX iuHEc+v9U8mStOVq624Mb+qeizU3lQRbDLC55QIvpX9GHPkXc1Dgpb3O5vT7nj2PbpiB a1RQ== X-Gm-Message-State: AOJu0YxYEje14IkpRdZ/DXlHDBPWKbjzG1648mrNP80+jWOBqoXyEUi2 yX4kvu7L+UgjB5lGqSXq2oouUEMHGVwAk7k9Yzgyu4juupfEF6tCtDU1qmVdDawzGps= X-Gm-Gg: AZuq6aL76Z6POAJH1uvhqZvxBw8QJWclKi917G28DTkodtYVrE+LSMdwsESV2/OX9Vs IOhb2ntZ0TlFlG6yDA1D/wAzyf7CfYTQTHhj7xGOpVuzP5u/mzHDpDo/Cvs5p3rUVhtWe8qOfkb XRYieZWw2j/6UZfDJ+3juf54TRB0kgFz6Zrx5BGMIxnOwccxW6PALBWnONd0Auw53Z/n0W86+4q NXrx+Neen+z5elK9JRshhzUsvUtOxO2KFmhgrMKrjFWQaxmADKi9CF0PWuZT2/oiNx9L5AAKWfy hJmlNN/E65xrlV2aMA30kwZvtDVAAGmeFW7n1ZEWWWAHZkAg7hgKi+y8/YFATTFI3kjDfd2Vhs1 xIATxJJ4UlCuPyZ2F+8FhKZvcL2N+5ZZacWK99o/+jI+Z/AB9oC8LAe8Zlt0biWvrwSZjLBAMsa 7Ru64SPFn51B+2sjfBUMI1IbCDy7ZfIQ0= X-Received: by 2002:a05:6000:2307:b0:435:a7fa:24ae with SMTP id ffacd0b85a97d-4362937835bmr21336456f8f.18.1770728061494; Tue, 10 Feb 2026 04:54:21 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.215]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4376b62b835sm21376916f8f.12.2026.02.10.04.54.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 04:54:20 -0800 (PST) Message-ID: <70f64a42-6adb-40cb-9db1-cca503f42466@tuxon.dev> Date: Tue, 10 Feb 2026 14:54:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] reset: rzg2l-usbphy-ctrl: Check pwrrdy is valid before using it To: p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: linux-kernel@vger.kernel.org, Claudiu Beznea References: <20260204133427.3762840-1-claudiu.beznea.uj@bp.renesas.com> Content-Language: en-US From: Claudiu Beznea In-Reply-To: <20260204133427.3762840-1-claudiu.beznea.uj@bp.renesas.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Philipp, On 2/4/26 15:34, Claudiu wrote: > From: Claudiu Beznea > > The pwrrdy regmap_filed is allocated in rzg2l_usbphy_ctrl_pwrrdy_init() > only if the driver data is set to RZG2L_USBPHY_CTRL_PWRRDY. Check that > pwrrdy is valid before using it to avoid "Unable to handle kernel NULL > pointer dereference at virtual address" errors. > > Fixes: c5b7cd9adefc ("reset: rzg2l-usbphy-ctrl: Add suspend/resume support") > Signed-off-by: Claudiu Beznea If all good for you in with this patch, could you please take it along with the suspend/resume support on this driver to avoid any regression? Thank you, Claudiu > --- > drivers/reset/reset-rzg2l-usbphy-ctrl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/reset/reset-rzg2l-usbphy-ctrl.c b/drivers/reset/reset-rzg2l-usbphy-ctrl.c > index 32bc268c9149..05dd9b4a02df 100644 > --- a/drivers/reset/reset-rzg2l-usbphy-ctrl.c > +++ b/drivers/reset/reset-rzg2l-usbphy-ctrl.c > @@ -136,6 +136,9 @@ static int rzg2l_usbphy_ctrl_set_pwrrdy(struct regmap_field *pwrrdy, > { > u32 val = power_on ? 0 : 1; > > + if (!pwrrdy) > + return 0; > + > /* The initialization path guarantees that the mask is 1 bit long. */ > return regmap_field_update_bits(pwrrdy, 1, val); > }