From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750879AbdE1Qwl (ORCPT ); Sun, 28 May 2017 12:52:41 -0400 Received: from thoth.sbs.de ([192.35.17.2]:40425 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750791AbdE1Qwk (ORCPT ); Sun, 28 May 2017 12:52:40 -0400 Subject: Re: [PATCH v2 6/6] stmmac: pci: Remove setup handler indirection via stmmac_pci_info To: Andy Shevchenko Cc: Giuseppe Cavallaro , Alexandre Torgue , David Miller , netdev , "linux-kernel@vger.kernel.org" References: <6183ce221f01384f4d50b0cfd62beabe337f5b39.1495814872.git.jan.kiszka@siemens.com> From: Jan Kiszka Message-ID: <70fc470e-52e5-cf7d-6003-5e487dfe73f7@siemens.com> Date: Sun, 28 May 2017 18:52:32 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-05-27 15:38, Andy Shevchenko wrote: > On Fri, May 26, 2017 at 7:07 PM, Jan Kiszka wrote: >> By now, stmmac_pci_info only contains a single entry. > > _For now_. > >> Register this >> directly with the PCI device table, removing one indirection. > > I am not sure this patch is needed. > > Next time something comes up we would need to extend this and > effectively revert this change. > So, my vote is to leave it as is for now. Therefore moved this to the end: may the maintainer pick it or not. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux