mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gabriele Monaco <gmonaco@redhat.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org, Ingo Molnar <mingo@redhat.org>
Subject: Re: [RESEND PATCH v13 3/3] selftests/rseq: Add test for mm_cid compaction
Date: Fri, 20 Jun 2025 17:20:38 +0000 (UTC)	[thread overview]
Message-ID: <70fe4209-4a31-4957-a658-727081f8291a@redhat.com> (raw)
In-Reply-To: <2606da6a-3a13-4db6-855e-8dcc61c45b45@linuxfoundation.org>

2025-06-18T21:04:30Z Shuah Khan <skhan@linuxfoundation.org>:

> On 6/13/25 03:12, Gabriele Monaco wrote:
>> A task in the kernel (task_mm_cid_work) runs somewhat periodically to
>> compact the mm_cid for each process. Add a test to validate that it runs
>> correctly and timely.
>> The test spawns 1 thread pinned to each CPU, then each thread, including
>> the main one, runs in short bursts for some time. During this period, the
>> mm_cids should be spanning all numbers between 0 and nproc.
>> At the end of this phase, a thread with high enough mm_cid (>= nproc/2)
>> is selected to be the new leader, all other threads terminate.
>> After some time, the only running thread should see 0 as mm_cid, if that
>> doesn't happen, the compaction mechanism didn't work and the test fails.
>> The test never fails if only 1 core is available, in which case, we
>> cannot test anything as the only available mm_cid is 0.
>> Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
>> Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
>
> Mathieu,
>
> Let me know if you would like me to take this through my tree.
>
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>

Thanks for the Ack, just to add some context: the test is flaky without the previous patches, would it still be alright to pull it before them?

Thanks,
Gabriele


  reply	other threads:[~2025-06-20 17:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-13  9:12 [RESEND PATCH v13 0/3] sched: Restructure task_mm_cid_work for predictability Gabriele Monaco
2025-06-13  9:12 ` [RESEND PATCH v13 1/3] sched: Add prev_sum_exec_runtime support for RT, DL and SCX classes Gabriele Monaco
2025-06-13  9:12 ` [RESEND PATCH v13 2/3] sched: Move task_mm_cid_work to mm work_struct Gabriele Monaco
2025-06-25  8:01   ` kernel test robot
2025-06-25 13:57     ` Mathieu Desnoyers
2025-06-25 15:06       ` Gabriele Monaco
2025-07-02 13:58       ` Gabriele Monaco
2025-06-13  9:12 ` [RESEND PATCH v13 3/3] selftests/rseq: Add test for mm_cid compaction Gabriele Monaco
2025-06-18 21:04   ` Shuah Khan
2025-06-20 17:20     ` Gabriele Monaco [this message]
2025-06-20 17:29       ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70fe4209-4a31-4957-a658-727081f8291a@redhat.com \
    --to=gmonaco@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@redhat.org \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®