From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A894816A95B for ; Tue, 25 Feb 2025 17:36:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740504986; cv=none; b=XEKts28JPEHUbYwEC7DVNCEYpUu8Qxuc1rULK6Gx0U7VE+B37MmFD6TpLqVn4+BCi1tLAKVZqWH8s1Ybo2OC0pfoQ2kFac8Mphf9HFhYNS+cUx4wst76upLDSn6d5J3gj5hdI/8NottkmisFtMynJ1pa/FTC5R+BerkIFjT/zto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740504986; c=relaxed/simple; bh=vMpMt5v73FW7ggM23zoCt5cN9QuMLVUvflsLEKOSyKU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Wh1OWrrOXGsmzu8OmAN3BM1wl5L6KS44LFYi2zTpS5H3zycVTKvgnFe/PczRa8HW+DES3pfJBiAs1iE8UycnZL8ufXphk9h4SwIVQHIM06u1ayc+pSXYG3fT51ai5CvZ/pt5/z4JxBd/OdOi4VIVr6ZyVVhawoo2qse8EF6HKak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=muXSm/zo; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="muXSm/zo" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51P8G4bh031843 for ; Tue, 25 Feb 2025 17:36:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PY156n79dtgyG547BmE7z4tz9qFqyESVtay+ztcM35s=; b=muXSm/zoLUrDUdLv RVO8vy97Q8kxT7j7yu/Oxf/RbYbUb5J1UoUQ11baEgXCYj052Z0KU+zvs7U+1Kpm 04TpRDaSKV263B1BELeKYZCxqpe2fxnPGXQCAhNoWJjzhyKPVFGy9AJziBvCS7aC WiuWqCmaB8mMyU5BGEgoSNq+SZjEO+/0ESiRrW1+q2aAq/7Id1/UZ2lImxej0G+B LMNEHYwZe5Ar5NiP2wrGXh8KMomYG5vDdzl/EfqU5IByni+t9jFQKstNcwPhNTzr NreLpEicJ6hHm+FO5IRCixq49uGX6+Dh8bf1AMh7rVTzvddCzJ7YFYpj3++v8sdc q226Bw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44y6nu1qg0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 25 Feb 2025 17:36:23 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-22126a488d7so130839425ad.2 for ; Tue, 25 Feb 2025 09:36:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740504982; x=1741109782; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PY156n79dtgyG547BmE7z4tz9qFqyESVtay+ztcM35s=; b=wH0zFu5mOJWsYe3giZF/VKQxTQramu9rN0eT2vIPL/5OFM2k2qv+HtRZ4oaq42lKxa ArYS/AHOGS9HwqjjqaoRHU6f9tFKb6yGTfN/BoYIORHVdmDEIu46WAM7tSsU3acgBjlX 1suaiuooFZQ0PFNZopUVa0GYb93W6b6ARoq/USlR9JtDrSd1+heXmRaieVL+6RSilzOu RFF8f0X49PEYQsWzXTf5qFwU7pT7DM8dWIiBRlCR3hQKaAav6CHWy+4T5Hu4wkMxqRLu ANW4hILCznz0ULstQ9W4TMPCezcx1gJ4Nkx7bElHWEPIjAyyj6UeqSXcPyG/bHn8Slkv kzAQ== X-Forwarded-Encrypted: i=1; AJvYcCXFtVxwJEjzvEKYdOeivm1J2IsWsopmZXftGdHW6ljedmwrEmE1HOo/djLRvfRPugXkPubYjhK9A48hBwo=@vger.kernel.org X-Gm-Message-State: AOJu0YySNTw5/c2nnnEB+Q2B1rON3VtKOhKYm9tGYwTD4GgpWvASfdL6 /+h3TOSAEo7y9gyXL+i2YqD7iGrisNlmhn864/y85E9PvaB6cCjo9FyDjVn1m31LxaENuBN9MU1 2GYpFmLvUE9jd3QVDIi8vlSetgRGU2UZ4f3kklBRPWD/Fi0j0Lg61tgmWp0dN04k= X-Gm-Gg: ASbGncs3Tz9/2aZVZSksJ+RxVHnGGZGXA0hMbIM6L7XUyBcfrpAa7yEfHfe1ZhLGh4+ g5TPpEd/ssKcQE1Y0nDxBOt6ZfDHhqEWDAvFZodvoOAkHnEXQhhZaZFBDeEvxJPuEdjOvuZdh+r +AS0wJtiZU8pkAxIdR4MQ5ysPgND9Pv8tThPATJvKTy63FMLBNTduaSGuUZGjrpNGo4DkrRj4cA QmMVwfpdJg+DvL334RTTl891rO/46Uu9eJqkl2fkNvdFRWbjB0Dl/4tzPif5Sl7IqDpd60BHBUN iJpgekLeiKN6o6uNGC5Ad2hS3okf6j9qW1x0sGjP7iViXXrU/HNUNEqCZFZJgG/lDA0OgRE= X-Received: by 2002:a17:902:f68c:b0:21b:d2b6:ca7f with SMTP id d9443c01a7336-22307e6b767mr73470665ad.32.1740504982008; Tue, 25 Feb 2025 09:36:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IFw8TV2N1DWUVbvHR3m0t6e0ifAA4ibMwsVXoLdv9Y7Qb3v7ZoTUZ06wLZmqsF37ryqtGQ7PQ== X-Received: by 2002:a17:902:f68c:b0:21b:d2b6:ca7f with SMTP id d9443c01a7336-22307e6b767mr73470115ad.32.1740504981602; Tue, 25 Feb 2025 09:36:21 -0800 (PST) Received: from [10.227.110.203] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2230a0ad990sm17124675ad.215.2025.02.25.09.36.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Feb 2025 09:36:21 -0800 (PST) Message-ID: <71019e23-f339-4485-8599-c4e40ad979a9@oss.qualcomm.com> Date: Tue, 25 Feb 2025 09:36:19 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: x1e80100-slim7x: Drop incorrect qcom,ath12k-calibration-variant To: Krzysztof Kozlowski , Dmitry Baryshkov Cc: Jeff Johnson , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ath12k@lists.infradead.org References: <20250225093051.58406-1-krzysztof.kozlowski@linaro.org> <7b54e965-3395-4349-8ae7-51a28c759235@linaro.org> <21ad3381-4d65-4c68-892d-9f485bf13735@oss.qualcomm.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Q8gAn-YHBst6Scv1adv7u98LGScS4ZCy X-Proofpoint-GUID: Q8gAn-YHBst6Scv1adv7u98LGScS4ZCy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-25_05,2025-02-25_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxlogscore=999 malwarescore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 bulkscore=0 mlxscore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2502250111 On 2/25/2025 9:07 AM, Krzysztof Kozlowski wrote: > On 25/02/2025 17:44, Jeff Johnson wrote: >>>>> >>>>> But nothing parses such string as 'qcom,ath12k-calibration-variant' (see >>>>> git grep), so how would driver use it? >>>> >>>> That's what I'm asking: is the property redundant or is it correct and >>>> it is a driver that needs to be fixed? >>> >>> I assume driver will need something like that property, but that's not a >>> reason to accept incorrect one in DTS. One cannot add properties to DTS >>> without bindings, so bypassing bindings review, and then claim "but my >>> driver needs them". Send proper patches for driver first which will get >>> a review. >> >> We definitely need a calibration variant entry. >> I've pinged the development team to get the driver patch. > > > The patches were on the lists but were not accepted. Therefore DTS > property cannot get into the kernel. I am sorry, but this is not somehow > fluid or flexible that internal team can squeeze something into the kernel. I see bindings and DTS patches but no driver patch, even in my internal queue. > > Also post factum reasoning is not correct, because this would open the > gate to bypass any sort of review. Just squeeze your stuff into the DTS > and then you can bypass all DT maintainers :/ > > All properties must be documented and bindings must be accepted *before* > DTS patch is applied. There is no intention to bypass DT maintainers. We are just trying to upstream a large amount of downstream code, and in the process some pieces are coming out of order. And there is also confusion if binding, driver, and DTS changes should be in one series or three separate series. We are moving towards an upstream-first model, but we still have to address the existing technical debt. /jeff