mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Randy Dunlap <rdunlap@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] drm: ast: fix double __iomem sparse warning
Date: Wed, 19 Aug 2020 09:17:33 +0200	[thread overview]
Message-ID: <71030cba-99dd-5815-8fac-bfd5de6319f8@suse.de> (raw)
In-Reply-To: <a8185578-a69a-16b0-6fdf-f4e46bc4f61f@infradead.org>


[-- Attachment #1.1: Type: text/plain, Size: 1746 bytes --]

Hi

Am 18.08.20 um 22:28 schrieb Randy Dunlap:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> sparse complains about having 2 "__iomem" attributes on the same line
> where only one is needed since the first one applies to everything
> up to the ending ';'.
> However, to make it clear(er) that both of these pointers are
> "__iomem", use separate lines for them.
> 
> ../drivers/gpu/drm/ast/ast_cursor.c:256:26: CK: warning: duplicate [noderef]
> ../drivers/gpu/drm/ast/ast_cursor.c:256:26: CK: error: multiple address space given: __iomem & __iomem
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> ---
>  drivers/gpu/drm/ast/ast_cursor.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, added to drm-misc-next

Best regards
Thomas

> 
> --- lnx-59-rc1.orig/drivers/gpu/drm/ast/ast_cursor.c
> +++ lnx-59-rc1/drivers/gpu/drm/ast/ast_cursor.c
> @@ -253,7 +253,8 @@ void ast_cursor_show(struct ast_private
>  		     unsigned int offset_x, unsigned int offset_y)
>  {
>  	u8 x_offset, y_offset;
> -	u8 __iomem *dst, __iomem *sig;
> +	u8 __iomem *dst;
> +	u8 __iomem *sig;
>  	u8 jreg;
>  
>  	dst = ast->cursor.vaddr[ast->cursor.next_index];
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]

      parent reply	other threads:[~2020-08-19  7:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 20:28 Randy Dunlap
2020-08-18 23:37 ` kernel test robot
2020-08-19  7:17 ` Thomas Zimmermann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71030cba-99dd-5815-8fac-bfd5de6319f8@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®