Re: [PATCH RFC 2/5] drm/colorop: Export drm_colorop_cleanup() so drivers can extend it

[Louis Chauvet <louis.chauvet@bootlin.com>]

Le 22/08/2025 à 20:36, Nícolas F. R. A. Prado a écrit :
> Export drm_colorop_cleanup() so drivers subclassing drm_colorop can
> reuse this function in subclass cleanup routines.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>

> ---
>   drivers/gpu/drm/drm_colorop.c | 3 ++-
>   include/drm/drm_colorop.h     | 1 +
>   2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_colorop.c b/drivers/gpu/drm/drm_colorop.c
> index d53de1438d23def74a77730cacd3651131e82cbe..8a27861a367ab321d45835099f438ee5e2abd709 100644
> --- a/drivers/gpu/drm/drm_colorop.c
> +++ b/drivers/gpu/drm/drm_colorop.c
> @@ -186,7 +186,7 @@ static int drm_plane_colorop_init(struct drm_device *dev,
>    *
>    * @colorop: The drm_colorop object to be cleaned
>    */
> -static void drm_colorop_cleanup(struct drm_colorop *colorop)
> +void drm_colorop_cleanup(struct drm_colorop *colorop)
>   {
>   	struct drm_device *dev = colorop->dev;
>   	struct drm_mode_config *config = &dev->mode_config;
> @@ -201,6 +201,7 @@ static void drm_colorop_cleanup(struct drm_colorop *colorop)
>   
>   	kfree(colorop->state);
>   }
> +EXPORT_SYMBOL(drm_colorop_cleanup);
>   
>   /**
>    * drm_colorop_pipeline_destroy - Helper for color pipeline destruction
> diff --git a/include/drm/drm_colorop.h b/include/drm/drm_colorop.h
> index 710a6199ebc5498a3f664de39ea07dbc95944eb7..158c2b8f775b99fd0a0efa03f2c019f14a9bc8b3 100644
> --- a/include/drm/drm_colorop.h
> +++ b/include/drm/drm_colorop.h
> @@ -374,6 +374,7 @@ static inline struct drm_colorop *drm_colorop_find(struct drm_device *dev,
>   	return mo ? obj_to_colorop(mo) : NULL;
>   }
>   
> +void drm_colorop_cleanup(struct drm_colorop *colorop);
>   void drm_colorop_pipeline_destroy(struct drm_device *dev);
>   
>   int drm_crtc_colorop_curve_1d_lut_init(struct drm_device *dev, struct drm_colorop *colorop,
> 

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com