From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Zwane Mwaikambo <zwane@linuxpower.ca>,
Linus Torvalds <torvalds@transmeta.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][2.5] avoid scribbling in IDT with high interrupt count.
Date: Mon, 07 Apr 2003 19:31:39 -0700 [thread overview]
Message-ID: <7110000.1049769098@[10.10.2.4]> (raw)
In-Reply-To: <Pine.LNX.4.50.0304071958360.21025-100000@montezuma.mastecende.com>
> My patch skips irq numbers > NR_IRQS and simply return error when we run
> out of vectors, although mainline doesn't assign duplicates and cause
> collisions, it does waste vector space. e.g. for a system with
> NR_IRQS = 224 we have 23 vectors free, 0 collisions and 167 useable irqs
> and assign_irq_vectors states that we're out of vectors.
>
>> In other words, I'm wondering if this simpler patch wouldn't be sufficient
>> instead?
>>
>> Can you please test this, and re-submit (and if you can explain why your
>> patch is better, please do so - I have nothing fundamentally against it, I
>> just want to understand _why_ the complexity is needed).
>
> Your patch booted the system but there are vector collisions resulting in
> lost irq routing when we program the IOAPIC with the duplicated vector. So
> with your patch and NR_IRQS = 224 we have 1 vectors free (0x80), 34 collisions
> and 225 irqs. However that isn't a fault of your patch but a fault with
> the NR_IRQS definition. This is what the vector space looks like on i386
> at present.
>
> 0________0x31__________________________0xef____________0xff
> system io interrupts resvd vectors
>
> 0xef - 0x31 = 190 useable io interrupt vectors
>
> So perhaps we should, apply your patch, add a NR_IRQ_VECTORS define
> and also add commentary in irq_vectors.h how does the following look? I
> had to readd the NR_IRQS checks to protect against overrunning NR_IRQS sized
> arrays and i added nr_assigned to track how many vectors were allocated so
> taht we can bail out when we're out.
>
> Patch has been tested on a 320 interrupt system and had a maximum useable
> irq line of 211 (ethernet).
We're still allocating interrupts to a bunch 'o stuff that isn't actually
being used ... I'd prefer it if we could change that, and allocate them
as they're actually used, rather than (what I believe is) still a fixed
number per IO-APIC. Is there some smart way to do that?
If not, the overflow protection is still (obviously) a good thing to do.
M.
prev parent reply other threads:[~2003-04-08 2:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-07 6:03 Zwane Mwaikambo
2003-04-07 15:27 ` Linus Torvalds
2003-04-08 2:04 ` Zwane Mwaikambo
2003-04-08 2:31 ` Martin J. Bligh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='7110000.1049769098@[10.10.2.4]' \
--to=mbligh@aracnet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®