From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EB71279DCA for ; Tue, 22 Jul 2025 17:37:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753205822; cv=none; b=lNuzRKc2aKLGbCifWa81CdoDP9h8BW5pXhZDpIQp1pYoWJamV3VSLpGDhb5RPmlXndWaduSk95ZiWug9kn6IXHJy0Xtx1478VozDr2HKtzWSb/lggQHzHzPGK4R7oXWCf/FM9EaJWOy+j2a/ZwXpch3McDe7BasoGkVCSHQW52o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753205822; c=relaxed/simple; bh=JjE0VAUs/J0+dJNz1qos9yiUiv2iZz0R8XhEsFlljuM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W09HLLRWNs9MGkpoctuPdWO4+MB4YpBO1iCy+RGkye9wFNWCmK+PuF+ZBs2IuXScJuBsW/QaKb+ZeiFu6wtXYg/E6TO/UqyKn0HKgBYZXc+gwT1zkr4bCuzE/Y0JTLfKrRGJlMxyVC3Re3ZpH7UTZMGyQ2yv4Aht+0xwXtpT6EM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=L6Vct6Px; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="L6Vct6Px" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56MGKOPM012550 for ; Tue, 22 Jul 2025 17:37:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bU7DW70Vq3fqTu0IqRRaBc2dO6wODFlMeXGfXQWsOEs=; b=L6Vct6Pxe+j+SCds VltgIQhYP3L0YIik4WhdDiqM/EfJio6JtRfTKJI8KZNpYnxVROyBPt0OdtGg1aXI rvTB3ZJ3fDiA3U7JkzDtUJvdt/DLZDtEqmM5qp5bd9QDUjcpdawlmFaQYdoyFLaF h5XyS4up7nMObmESBNhFKW58lQQm49Qk5qU1lu/vtmLeAE3kHdox81PE5p7TF0zU pb2m1wdi3Ah5J5N5NAD5umZou14kF4Ay7yoFN8XN1KnPDRywd/6wmJJRpqf6+dR/ i2m8SpStxoWhcd5PDY870tj6Na2CUUFUA9ELA7oqrvICjAM3nkfDDy+y+apYPWZh jgwFbQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 481qh6mn7u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 22 Jul 2025 17:37:00 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7e32b9398e4so718149285a.1 for ; Tue, 22 Jul 2025 10:37:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753205819; x=1753810619; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bU7DW70Vq3fqTu0IqRRaBc2dO6wODFlMeXGfXQWsOEs=; b=Sk63+nC2LRPreNaqIEmVPWlCgJw8Q68ZdIVD+watpfKATJzaTbNmHiL2K7KFNKxkDn SwdjuNGIdteKZkctKKTt752q7TN2ZlCbdc79kz+iX5I2RVkJutS9D3G5HyAGMEHS86lr rYRqx8oRx8QJg0Ew5SS/Fx+quPIw1HVcOfjeb9S0HN+ftgNa9jIQw1DtkojJMqwKAQjg 0tcoifjQY43T57izBUTKHk9hQaePsj2oxiXQOk2O6DqavvJaRvYZ28tcE6RCq35UA4v8 UoqgjlI2VOaVRj5O+nPgPKhEbLMlg9yDpB310eRgYVS9O3aw3gcvdA+18bGzdQsdw5Qc GBDw== X-Forwarded-Encrypted: i=1; AJvYcCVm/am/UqfzF+Rm1i2/xDsh4uQZKyh4snEEbcg2C4gr9TBXO0vdquYmASzkFkdQ4UWGekFbxiVWjySFMrQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwwFAoLbCjzbYJ0LdEKdODpUkEdlqW47PxqicpLRoykuQNSMp6B F2CpcoIe+CuVetFqXhTYhosbDYaUD8V6Zv8RnhukqYk8EGVBYJTQUETVoSlm0Qh+DvDuL1d4MY2 KVfGAG9GQ+UFPc3lJshQ0LDun39YRnOzGvbUa6PhpZrUiSiaa92PgzqgHY2JM5nRXmN8= X-Gm-Gg: ASbGncvnNvA+UHTaJCFY/QAhlAXjfPk38Drck7iiEt4b616Yi3Q8d1L/xJFUoCEl/9F RCATqsMHn0Lbdo7/yeBWW32PzduSraQCV9efkyRmNnVB6S3DWNH3td8yYmlQRTAYI/xA0FoV7Ii JfRZFi9ZA45nGsRL+SdjtNKFliS380aBaPbqrjUaB1Y4NYm4BYcLkewT8e+6us4z4lPiaz/xykW nog17nDJHSY6keOv1VqmIMssqLrjaei4ZyqmcSat5YvpbtJAzhJ71NkieTDxXUMxh96fE3w4Vx4 AaE53ClxKuP7cLvmpTK9/ySGplS/Xqs/mfKwre/8CPiKVfbtGf4n2pWy/34PMBSaYK2kbyh/cI0 Kbe2TTaa1kClCTu3UHfBPZUQe4WdKsuC1zoBXPy2wm5199R2S1e92OVcCpq0B5Gb3OCeab62/yA DPnJWkQj3XvaDI+bWQ5g== X-Received: by 2002:a05:620a:6ccc:b0:7e1:872a:50fc with SMTP id af79cd13be357-7e62a0e0882mr28111285a.15.1753205819219; Tue, 22 Jul 2025 10:36:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHAhb4mNssqROGibAAgQdqvjUpNDDUd7RpqBoP1UdVvRdfzRy3DFb+cKvDrEktkeTKmlmkPew== X-Received: by 2002:a05:620a:6ccc:b0:7e1:872a:50fc with SMTP id af79cd13be357-7e62a0e0882mr28105185a.15.1753205818594; Tue, 22 Jul 2025 10:36:58 -0700 (PDT) Received: from ?IPV6:2001:14bb:119:87b1:24ce:1d7c:ed1:f2d3? (2001-14bb-119-87b1-24ce-1d7c-ed1-f2d3.rev.dnainternet.fi. [2001:14bb:119:87b1:24ce:1d7c:ed1:f2d3]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55a31dafffcsm2000022e87.224.2025.07.22.10.36.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Jul 2025 10:36:57 -0700 (PDT) Message-ID: <7117b159-6743-4db3-9ae5-1cf4ae051601@oss.qualcomm.com> Date: Tue, 22 Jul 2025 20:36:55 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] arm64: dts: qcom: qcs615-ride: add WiFi/BT nodes To: "Yu Zhang(Yuriy)" Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250707-615-v4-0-1a2f74d167d7@oss.qualcomm.com> <20250707-615-v4-2-1a2f74d167d7@oss.qualcomm.com> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=CZ4I5Krl c=1 sm=1 tr=0 ts=687fcc3c cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=yfEDxQUIism5sP7DLRQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: FAZ4OAVZiLDxXiS3KwqohMh3GGEQwraK X-Proofpoint-GUID: FAZ4OAVZiLDxXiS3KwqohMh3GGEQwraK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzIyMDE0OCBTYWx0ZWRfX4gP5RXKfb1DU MjxK5f7WZMBuba+unh3/U8UT03imUowRZKWUmZsJRYa9wbp3xKv9vS+ycqdkoj8QRtejEDjY5Rx 60PC+5cUZoBpPY0y8BUz5lsBKDwfn8qYiW3szxqJgDt2eN0hcxIXK7tDe+mH/9jws77JUFZE6MX yv3tSPDQuG4Ujfq57j0AluPflxvRAk1ho5JhcI/T+dLRrCqB/Q1r657Ho+nm79qv0ieplAGJ5cM Vy3AZttZlyMU1L0jMsy4AinEe1e7jvnLESsa28GYXI5IzxDK2NixAZkc7Z5AMOnK00ijhKbR4dE Ak23XAHjf9TQkNfU6496zuPrqKQEVw6QwITHnJdzIc+J9KSbd+Tkmcc2bE0pLeODf2ITh21m+zG FmNSAHiibZSPFu47sWYG+hUnzyFIaZxe8dTvp3XN39kRoVsSOHkAxr+j+7/0F+Bu/pAVFb9x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-22_02,2025-07-21_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 mlxlogscore=999 impostorscore=0 clxscore=1015 mlxscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507220148 On 22/07/2025 18:58, Yu Zhang(Yuriy) wrote: > > > On 7/19/2025 6:13 PM, Dmitry Baryshkov wrote: >> On Mon, Jul 07, 2025 at 10:51:06AM +0800, Yu Zhang(Yuriy) wrote: >>> Add a node for the PMU module of the WCN6855 present on the qcs615 ride >>> board. Assign its LDO power outputs to the existing WiFi/BT module. >> >> >> What is "existing WiFI/BT module"? There is no module in the DT. Not to >> mention that PMU is a part of the WCN6855. >> >>> >>> Signed-off-by: Yu Zhang(Yuriy) >>> --- >>>   arch/arm64/boot/dts/qcom/qcs615-ride.dts | 135 ++++++++++++++++++++ >>> +++++++++++ >>>   1 file changed, 135 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/ >>> boot/dts/qcom/qcs615-ride.dts >>> index >>> 011f8ae077c256f079ce1b07720374a9bf721488..2df8e7e3c1d3b6d6353a6753b8387c7411edd927 100644 >>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts >>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts >>> @@ -18,6 +18,7 @@ aliases { >>>           mmc0 = &sdhc_1; >>>           mmc1 = &sdhc_2; >>>           serial0 = &uart0; >>> +        serial1 = &uart7; >>>       }; >>>       chosen { >>> @@ -47,6 +48,85 @@ regulator-usb2-vbus { >>>           enable-active-high; >>>           regulator-always-on; >>>       }; >>> + >>> +    vreg_conn_1p8: vreg_conn_1p8 { >> >> No improvement. Please try again. >> > you mean should be "vreg_conn_1p8: vreg-conn-1p8",right? I'll update it, What is the node name for the previous regulator device? Anything preventing you from following the pattern? > thanks.>> +        compatible = "regulator-fixed"; >>> +        regulator-name = "vreg_conn_1p8"; >>> +        startup-delay-us = <4000>; >>> +        enable-active-high; >>> +        gpio = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>; >>> +    }; >>> + >>> +    vreg_conn_pa: vreg_conn_pa { >>> +        compatible = "regulator-fixed"; >>> +        regulator-name = "vreg_conn_pa"; >>> +        startup-delay-us = <4000>; >>> +        enable-active-high; >>> +        gpio = <&pm8150_gpios 6 GPIO_ACTIVE_HIGH>; >>> +    }; >>> + >> > -- With best wishes Dmitry