From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>,
Rob Clark <robdclark@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: <linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
"Bjorn Andersson" <quic_bjorande@quicinc.com>
Subject: Re: [PATCH v2 6/6] drm/msm/dp: Use function arguments for audio operations
Date: Mon, 8 Apr 2024 14:31:45 -0700 [thread overview]
Message-ID: <711e8a6a-a849-3cd3-fde3-d60f756abfa5@quicinc.com> (raw)
In-Reply-To: <20240328-msm-dp-cleanup-v2-6-a5aed9798d32@quicinc.com>
On 3/28/2024 7:40 AM, Bjorn Andersson wrote:
> From: Bjorn Andersson <quic_bjorande@quicinc.com>
>
> The dp_audio read and write operations uses members in struct dp_catalog
> for passing arguments and return values. This adds unnecessary
> complexity to the implementation, as it turns out after detangling the
> logic that no state is actually held in these variables.
>
> Clean this up by using function arguments and return values for passing
> the data.
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
> drivers/gpu/drm/msm/dp/dp_audio.c | 20 +++++--------------
> drivers/gpu/drm/msm/dp/dp_catalog.c | 39 +++++++++++++------------------------
> drivers/gpu/drm/msm/dp/dp_catalog.h | 18 +++++++++--------
> 3 files changed, 28 insertions(+), 49 deletions(-)
>
One quick question, was DP audio re-tested after this patch?
next prev parent reply other threads:[~2024-04-08 21:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 14:39 [PATCH v2 0/6] drm/msm/dp: Spring cleaning Bjorn Andersson
2024-03-28 14:40 ` [PATCH v2 1/6] drm/msm/dp: Drop unused dp_debug struct Bjorn Andersson
2024-03-28 14:58 ` Dmitry Baryshkov
2024-03-28 14:40 ` [PATCH v2 2/6] drm/msm/dp: Removed fixed nvid "support" Bjorn Andersson
2024-03-28 14:40 ` [PATCH v2 3/6] drm/msm/dp: Remove unused defines and members Bjorn Andersson
2024-03-28 14:40 ` [PATCH v2 4/6] drm/msm/dp: Use function arguments for aux writes Bjorn Andersson
2024-03-28 14:40 ` [PATCH v2 5/6] drm/msm/dp: Use function arguments for timing configuration Bjorn Andersson
2024-03-28 14:40 ` [PATCH v2 6/6] drm/msm/dp: Use function arguments for audio operations Bjorn Andersson
2024-04-08 21:31 ` Abhinav Kumar [this message]
2024-04-09 23:18 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=711e8a6a-a849-3cd3-fde3-d60f756abfa5@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_bjorande@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®