From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53E60C433ED for ; Sat, 3 Apr 2021 16:17:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 220AA6124B for ; Sat, 3 Apr 2021 16:17:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236835AbhDCQRo (ORCPT ); Sat, 3 Apr 2021 12:17:44 -0400 Received: from smtprelay0055.hostedemail.com ([216.40.44.55]:36610 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230450AbhDCQRn (ORCPT ); Sat, 3 Apr 2021 12:17:43 -0400 Received: from omf18.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id E4E811843912D; Sat, 3 Apr 2021 16:17:39 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA id F0E622EBFA4; Sat, 3 Apr 2021 16:17:38 +0000 (UTC) Message-ID: <7120836b08b680d54c15fd89b8630ccc67a53116.camel@perches.com> Subject: Re: [PATCH v3 00/30] staging: rtl8723bs: remove RT_TRACE logs in core/* From: Joe Perches To: Fabio Aiuto , gregkh@linuxfoundation.org Cc: dan.carpenter@oracle.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Date: Sat, 03 Apr 2021 09:17:37 -0700 In-Reply-To: <20210403152143.GA1403@agape.jhs> References: <1cd79d781cdcccf621ce8e104a9cdf1e90e7f803.camel@perches.com> <20210403152143.GA1403@agape.jhs> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout02 X-Stat-Signature: cb67t64hhuz36xmx6sthh6axymjb9wwg X-Rspamd-Queue-Id: F0E622EBFA4 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/d0bwAguyxvRO74mFrz/saWwALiEImrkc= X-HE-Tag: 1617466658-753426 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2021-04-03 at 17:21 +0200, Fabio Aiuto wrote: > On Sat, Apr 03, 2021 at 08:02:25AM -0700, Joe Perches wrote: > > On Sat, 2021-04-03 at 11:13 +0200, Fabio Aiuto wrote: > > > This patchset removes all RT_TRACE usages in core/ files. > > > > and hal and include and os_dep > > Hi, > > I was just about to send the second patchset relative to hal/ files. > The whole has been split up in directories in order to reduce the > number of patch per patchset > It's a good idea, but the patches relative to RT_TRACE removal > could be huge That's really not a significant issue. Simplicity in review is also important. Mechanization of patch creation can reduce review efforts. Few people are actively working on this particular codebase. As far as I can tell no logical defect is being corrected here. None of this is likely to be backported. Applying each individual patch has a 'cost' in maintainer time and review effort. Fewer patches create lower overall costs. Good luck...