From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DA8D1C860B for ; Fri, 23 Jan 2026 21:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769202022; cv=none; b=qt9vBKXIxWSSK9zyxnMpz3+M6rxPvW7xKUoDwFBhBoCVlt5DG1JfctbhkRv6TcXv3XbQQw/+/sOel/W8bfB6P/i9uXSh5h7x4UHH9FqrwUZ0pmEG5LWSS32e9Pa0pBPtnG72dfMdY7yysE3i4JnKLeHjBz8X7W1Myums9XQxRxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769202022; c=relaxed/simple; bh=1r2rhfIfNAgeLhcVd3Fth5KFSw3s1U6wlg1lx3h0/WQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uWbfOdluAC3FzbaMTeCjzZOANZX9Tv3muSYgbwOI7p2jpbR2LhX84t3BBab9Ss5PzLXOJAkEXeLHhQ1L1RVERzoJbkObzir7RywJNc5HnTjQZTFFElJi3VBV9c8GWBBufzZL80Ki++EaIG+REuyYYKa/VJXRkf8xZPLSHGmBmrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Ldve9TyS; arc=none smtp.client-ip=209.85.160.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Ldve9TyS" Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-408778a8ec4so1740182fac.0 for ; Fri, 23 Jan 2026 13:00:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1769202020; x=1769806820; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8uNYqV1avZyh+foZ5DUAwLH7I+zAmKYfxKTdgaxSmkU=; b=Ldve9TyS0QCbDpUGtwD85pYHkxCQEH8HRyFPVZQiX//V3F9pFHSlgF+KYeeyez8AFC ULUvjGTX/tVsKJmOr3WmMD0zQPxNgVTeBbANxQlcvCie/zHY9a3Z8e/tHwF4GEoJadAs ehQeWqOeO/to/tJO5K74hVa/O6VNXI86jc5iirQEQqw2/ZRnR9VIETaaGwz7Iy7HCoRp GmCocc9tPyT/7X9u4YdZRZw4B10GNCZfTamrpzm9sDnLm9vkNLuWuWheuMor4Q9MLOoq UUi+yL6a5Oax5/dVjyJ73034mpdZgOl3Hx7kZhRAfnjgKX+H6Xw77OKgwGa7BZcVOR6L nqPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769202020; x=1769806820; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8uNYqV1avZyh+foZ5DUAwLH7I+zAmKYfxKTdgaxSmkU=; b=MoL3++jyMw0M2eNXViVElWU/43XpLnyWicOT7g653qwHOdWxh1wbAn52AX3AyOQbwK /CZJ7MLOme43h8i7ES0Sj9QbrdCn8sAYLKEQ8yo7lXsnv9tbTGoMP7uBWQZz4FPBxSP2 NC1Ecd3WVZxUQCKu0+fQfij/VvelQK1waRRb8k0WfyYPZEqWRSZOhfbjz+0O+336nI6Q 93O+jiS+QeS7dNodzoGWP+SQsB4Rjo/Pn1iDzH6GvOzxqREvj4BPMCnbV7N7dhQm76d9 VT0OfCQch71vqWjG6enMjOuBupHVx980DonxCg5bgtlUp03loH2pdX/bTpqVudyCYrT8 LFnA== X-Forwarded-Encrypted: i=1; AJvYcCXynNukMByJuZLU+IjMcKrK/bDOaXBAz0Ozst8wjkZRTbulTP52ZbPXCYSW2guCiTlIh3emfeFO0O7OBjE=@vger.kernel.org X-Gm-Message-State: AOJu0YwLcc5BI/G5+dtabvM4GbiFRZsCwP8GGuM2H6nf2aJQLCHiyNmh 4KaaHUqe2Xyw0qkPeXy+iC/PLmiDqdfzTyFbnntrZW5x5jnOyvt1FINlU3pSpnjNg5A= X-Gm-Gg: AZuq6aIo7DxCkdS9AEBS0reQPfjABpd1X0Fp+f0yAaRoeSvtrrpU1yolOhlt5LZYorw 0wjHcIBuK+upfKdc+puLx8t+iaURGRqjav+OEoLivgwikIOEFgVrDlICqT1I+4Smp/8VaMY3YL4 yD4YvN+/+5NlsRIJvkmv7sQfIikUarhTzQ1g2XP0nsJdjGrc7VeYSbnddblioQYC3uauOWFgUXo pctYIHtzP4u+IKRoP8mS7PoBMOW/mn7mwFUVjpAayj0WYqMDkrRmuMgqE1DXrB5TCHd3AK5cdjb S8RTbBSAZdWysh3c6Lb1oai1NXQkM2+QZDTTKpZEDioAimGDnw+Tp+Hhacac2SgyEd2DOG3x05R cDhbj8tkJ+MRlfRZCzwk/+bf3svvyupNr/iVkJCRREUm0YQnatq7X1KmhoDoMzESNDUt0G8BMdp vQDro9/rBCAZlKWbD5bla5CdU3P6JxpSCRyKkZj7oXjboyL9rCnX53qfc4SA== X-Received: by 2002:a05:6820:160b:b0:662:b9f0:175a with SMTP id 006d021491bc7-662cab7d3a9mr1810028eaf.59.1769202020243; Fri, 23 Jan 2026 13:00:20 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:198f:2b50:c48:1875? ([2600:8803:e7e4:500:198f:2b50:c48:1875]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-408afba74bfsm2239703fac.13.2026.01.23.13.00.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jan 2026 13:00:19 -0800 (PST) Message-ID: <7126e6f2-c116-40c6-8657-1cddc36903dc@baylibre.com> Date: Fri, 23 Jan 2026 15:00:18 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 18/21] iio: Replace IRQF_ONESHOT with IRQF_NO_THREAD To: Jonathan Cameron , Andy Shevchenko Cc: Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Thomas Gleixner , Lars-Peter Clausen , Michael Hennerich , Puranjay Mohan , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Marcelo Schmitt , Marcus Folkesson , Kent Gustavsson , Gustavo Silva , Nishant Malpani , linux-iio@vger.kernel.org References: <20260123113708.416727-1-bigeasy@linutronix.de> <20260123113708.416727-19-bigeasy@linutronix.de> <20260123164711.0000379c@huawei.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260123164711.0000379c@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/23/26 10:47 AM, Jonathan Cameron wrote: > >>> +++ b/drivers/iio/accel/adxl372.c >> >>> + ret = devm_request_irq(dev, st->irq, >>> + iio_trigger_generic_data_rdy_poll, >>> + IRQF_TRIGGER_RISING | IRQF_NO_THREAD, >>> + indio_dev->name, st->dready_trig); >>> if (ret < 0) >>> return ret; >> >> Interestingly that this driver ignores the flags from firmware... Seems to me >> like a bug (not in your patch, obviously). Ditto for other drivers doing similar >> things. >> > > It's indeed a bug but one of those historic ones we can't fix without > high risk of regressions :( > > Sounds like we should add a "don't copy this because ..." comment while we are touching this.