From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751684AbdHRRlX (ORCPT ); Fri, 18 Aug 2017 13:41:23 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:31052 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbdHRRlV (ORCPT ); Fri, 18 Aug 2017 13:41:21 -0400 X-AuditID: b6c32a37-f79886d000004f16-04-599726bf13cb From: Bartlomiej Zolnierkiewicz To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, Michal Simek , =?ISO-8859-1?Q?S=F6ren?= Brinkmann , linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: constify copied structures Date: Fri, 18 Aug 2017 19:41:16 +0200 Message-id: <7127868.v7Fj1TocLv@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1501664679-10356-1-git-send-email-Julia.Lawall@lip6.fr> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgleLIzCtJLcpLzFFi42LZdlhTV3e/2vRIgzWXuSyWPTjNaLH1lrTF psfXWC1O9H1gtbi8aw6bxbuXERY3d2xmd2D32Lsly2PzknqPz5vkPPZ+/s0SwBLFZZOSmpNZ llqkb5fAlfFl6immgvu8FR1bfRoYH3B3MXJySAiYSCydcZkFwhaTuHBvPVsXIxeHkMAORolz h64wQzifGSV+/5nIAtMx4dAMRojEWkaJHT++QrV8ZZR4P+EAG0gVm4CVxMT2VYwgtoiAukTr hl1gHcwgo1b/W8oKkhAWsJV4NbMNzGYRUJVYc2cJWDOvgKbE8nnLmEBsUQEviS372sFsTgFX iY//FjJC1AhK/Jh8D+wkZgF5iX37p7JC2DoSZ4+tA1smITCZXeL18+XsXYwcQI6sxKYDzBCm i8Sq+9EQ3whLvDq+hR3ClpJofPmQCcKeziix/bcExJjNjBKrdk+AKrKWOHz8ItQuPol3X3tY IWbySnS0CUGYHhIrWiIgqh0lGttmgFULCcxglHh6RXsCo/wsJA/MQvLALCQPLGBkXsUollpQ nJueWmxYYKxXnJhbXJqXrpecn7uJEZw+tMx3MG4453OIUYCDUYmH98XPaZFCrIllxZW5hxgl OJiVRHgFngGFeFMSK6tSi/Lji0pzUosPMUpzsCiJ84qtvxYhJJCeWJKanZpakFoEk2Xi4JRq YPSW+H3xeDKLz+b3Alt/MJT6hj3Y9K/VbQnfsdmrXgWH9Flvm3TJMOmlvqrH40KJLVH5J37l 5p1bKf/pvrPJJJ5DTJf3ZT3w9Hn4cM5fMRaWvIdZQTsnO+g4OcqZRe3/v/ABK6Oj8L1DE6Qd WgIW3/u8an5QgvVXyxnP5O+6nQzwnu/3VGbb72IlluKMREMt5qLiRACpGCDzGwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsVy+t9jQd19atMjDRrXaFgse3Ca0WLrLWmL TY+vsVqc6PvAanF51xw2i3cvIyxu7tjM7sDusXdLlsfmJfUenzfJeez9/JslgCXKzSYjNTEl tUghNS85PyUzL91WKTTETddCSSEvMTfVVilC1zckSEmhLDGnFMgzMkADDs4B7sFK+nYJbhlf pp5iKrjPW9Gx1aeB8QF3FyMnh4SAicSEQzMYIWwxiQv31rOB2EICqxklbj5Q6GLkArK/Mkr8 nvsHrIhNwEpiYvsqMFtEQF2idcMuRpAiZoHPjBIbl+xgAkkIC9hKvJrZxgpiswioSqy5swRs Kq+ApsTyecvAakQFvCS27GsHszkFXCU+/lvICLFtFqNEz6VuFogGQYkfk++B2cwC8hL79k9l hbC1JNbvPM40gRGoGqFsFpKyWUjKFjAyr2IUSy0ozk3PLTYqMNQrTswtLs1L10vOz93ECIyn bYe1/Hcw/jgbfYhRgINRiYf3xc9pkUKsiWXFlbmHGCU4mJVEeAWeAYV4UxIrq1KL8uOLSnNS iw8xmgL9N5FZSjQ5HxjreSXxhiaWRiYGZmaGRgbGZkrivBMCv0QICaQnlqRmp6YWpBbB9DFx cEo1MMYyJqvXZEwKPBgwv4Ol82HDkUkxsTr37WOrn05lubT0adK7u2yFdye7hht0nK5+wewd VqEU8dlihvKmvAtaK7XldsguF1zPksBk0bX7wBJr/m9qh3UYJ2izHFtv2lmyMqBVeuJb5Z/z 1eQ25mdt8fJY/Kef17fS4cpcUdfta07/zS9PmFQXoMRSnJFoqMVcVJwIACpKSty9AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170818174118epcas1p4df3e53100b86a310c091cec62b0e5611 X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170802093008epcas2p48a98827ec2c27fbd6f6de8913d47c02b X-RootMTR: 20170802093008epcas2p48a98827ec2c27fbd6f6de8913d47c02b References: <1501664679-10356-1-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wednesday, August 02, 2017 11:04:39 AM Julia Lawall wrote: > Make const some structures that are only copied into other structures. > > Signed-off-by: Julia Lawall fb_fix_screeninfo and fb_var_screeninfo structures were already const-ified by commit 40445365a43f ("video: xilinxfb: constify fb_fix_screeninfo and fb_var_screeninfo structures") in my -next tree (git://github.com/bzolnier/linux.git fbdev-for-next) so I just applied xilinx_fb_default_pdata part (patch included below for reference). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From: Julia Lawall Subject: [PATCH] video: fbdev: xilinxfb: constify copied structure Make const xilinx_fb_default_pdata structure that is only copied into other structure. Signed-off-by: Julia Lawall Cc: Michal Simek Cc: Soren Brinkmann , [b.zolnierkie: split from a bigger patch] Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/xilinxfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/video/fbdev/xilinxfb.c =================================================================== --- a/drivers/video/fbdev/xilinxfb.c 2017-08-18 19:34:11.383004874 +0200 +++ b/drivers/video/fbdev/xilinxfb.c 2017-08-18 19:34:35.383005478 +0200 @@ -100,7 +100,7 @@ struct xilinxfb_platform_data { /* * Default xilinxfb configuration */ -static struct xilinxfb_platform_data xilinx_fb_default_pdata = { +static const struct xilinxfb_platform_data xilinx_fb_default_pdata = { .xres = 640, .yres = 480, .xvirt = 1024,