From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Frank Rowand <frowand.list@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Sean Anderson <sean.anderson@seco.com>
Subject: Re: [PATCH v4 0/6] reset: gpio: ASoC: shared GPIO resets
Date: Wed, 24 Jan 2024 08:25:16 +0100 [thread overview]
Message-ID: <71290f34-f3e6-4190-af8a-5fea61faedda@linaro.org> (raw)
In-Reply-To: <6c3e4b71-c92f-4f1e-8435-b5cfb7f47117@alliedtelesis.co.nz>
On 23/01/2024 20:28, Chris Packham wrote:
>
> On 24/01/24 03:13, Krzysztof Kozlowski wrote:
>> Hi,
>>
>> Patch #2 (cpufreq: do not open-code of_phandle_args_equal()) and patch #4
>> (reset: Instantiate reset GPIO controller for shared reset-gpios) depend on OF
>> change (patch #1).
>>
>> Changes in v4
>> =============
>> 1. New patches:
>> of: add of_phandle_args_equal() helper
>> cpufreq: do not open-code of_phandle_args_equal()
>>
>> 2. reset-gpio.c:
>> - Drop unneeded comment (Bartosz), add Rb tag.
>> - Do not assign of_node.
>>
>> 3. reset/core.c:
>> - Implement most of Bartosz feedback (I responded to one which I did not
>> implement) and comments from Philipp.
>> - Expect either rcdev->of_args or rcdev->of_node.
>> - Drop __reset_gpios_args_match() and use common helper (Philipp).
>> - Move declarations of automatic-cleanup variables in
>> __reset_add_reset_gpio_lookup() to place of use (Bartosz).
>> - Separate gpio_device_get_label() and kstrdup() (Philipp).
>> - Correct doc for __reset_add_reset_gpio_device(), rewrite few comments.
>> - Drop unneeded "r" variable in __reset_find_rcdev() (Philipp).
>> - Drop of_phandle_args initialization in __of_reset_control_get (Philipp).
>> - Check if CONFIG_RESET_GPIO is enabled before trying to look up reset-gpios.
>>
>> 4. Drop Chris' patch: "i2c: muxes: pca954x: Allow sharing reset GPIO", because
>> discussion is on going.
>
> I actually think it would have been OK as-is with your latest change to
> return NULL when CONFIG_RESET_GPIO is not enabled. But I'm happy to
> submit it independently after this series lands. It'll give me a chance
> to do a bit more testing.
Yeah, I wasn't sure if the concerns are really resolved. I think you can
send your patch separately because there is no clear dependency, so also
no clear benefits of me taking your patch into this patchset.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-01-24 7:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 14:13 Krzysztof Kozlowski
2024-01-23 14:13 ` [PATCH v4 1/6] of: Add of_phandle_args_equal() helper Krzysztof Kozlowski
2024-01-23 14:54 ` Philipp Zabel
2024-01-23 14:13 ` [PATCH v4 2/6] cpufreq: do not open-code of_phandle_args_equal() Krzysztof Kozlowski
2024-01-23 14:55 ` Philipp Zabel
2024-01-24 5:56 ` Viresh Kumar
2024-01-23 14:13 ` [PATCH v4 3/6] reset: gpio: Add GPIO-based reset controller Krzysztof Kozlowski
2024-01-23 14:13 ` [PATCH v4 4/6] reset: Instantiate reset GPIO controller for shared reset-gpios Krzysztof Kozlowski
2024-01-23 15:06 ` Philipp Zabel
2024-01-24 7:28 ` Krzysztof Kozlowski
2024-01-23 15:58 ` Philipp Zabel
2024-01-24 7:29 ` Krzysztof Kozlowski
2024-01-23 14:13 ` [PATCH v4 5/6] ASoC: dt-bindings: qcom,wsa8840: Add reset-gpios for shared line Krzysztof Kozlowski
2024-01-23 14:13 ` [PATCH v4 6/6] ASoC: codecs: wsa884x: Allow sharing reset GPIO Krzysztof Kozlowski
2024-01-23 15:07 ` Philipp Zabel
2024-01-23 19:28 ` [PATCH v4 0/6] reset: gpio: ASoC: shared GPIO resets Chris Packham
2024-01-24 7:25 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71290f34-f3e6-4190-af8a-5fea61faedda@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sean.anderson@seco.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®