mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Xu Yilun <yilun.xu@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
	michal.simek@xilinx.com, git@xilinx.com,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Moritz Fischer <mdf@kernel.org>, Rob Herring <robh@kernel.org>,
	Tom Rix <trix@redhat.com>, Wu Hao <hao.wu@intel.com>,
	Xu Yilun <yilun.xu@intel.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list:FPGA MANAGER FRAMEWORK" <linux-fpga@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: fpga: Also describe clock for gpio
Date: Fri, 13 Jun 2025 12:52:46 +0200	[thread overview]
Message-ID: <712b690d-2fcf-486e-87a1-17e2354d371f@amd.com> (raw)
In-Reply-To: <aEwA/pFuvbP+acSY@yilunxu-OptiPlex-7050>



On 6/13/25 12:44, Xu Yilun wrote:
> On Fri, Jun 13, 2025 at 12:12:52PM +0200, Michal Simek wrote:
>> Axi gpio is going to have clocks as required property that's why it should
>> be also described in bindings which are using axi gpio node.
>>
>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>> ---
>>
>> Changes in v2:
>> - New patch to fix reported as issue by the second patch
>> - https://lore.kernel.org/r/174954437576.4177094.15371626866789542129.robh@kernel.org
>>
>>   Documentation/devicetree/bindings/fpga/fpga-region.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/fpga/fpga-region.yaml b/Documentation/devicetree/bindings/fpga/fpga-region.yaml
>> index 77554885a6c4..7d2d3b7aa4b7 100644
>> --- a/Documentation/devicetree/bindings/fpga/fpga-region.yaml
>> +++ b/Documentation/devicetree/bindings/fpga/fpga-region.yaml
>> @@ -316,6 +316,7 @@ examples:
>>           reg = <0x40000000 0x10000>;
>>           gpio-controller;
>>           #gpio-cells = <2>;
>> +        clocks = <&clk>;
> 
> This file is mainly for fpga-region bindings. So I don't think we have
> to strictly align with the example IP block binding every time it has
> an update.

But Rob's script are reporting issue if they are not. Please take a look at link 
above.

M

  reply	other threads:[~2025-06-13 10:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-13 10:12 Michal Simek
2025-06-13 10:12 ` [PATCH v2 2/2] dt-bindings: gpio: gpio-xilinx: Mark clocks as required property Michal Simek
2025-06-13 11:07   ` Krzysztof Kozlowski
2025-06-13 11:26     ` Michal Simek
2025-06-16  6:41       ` Krzysztof Kozlowski
2025-06-16  6:51         ` Michal Simek
2025-06-16  7:10           ` Krzysztof Kozlowski
2025-06-16  7:13             ` Krzysztof Kozlowski
2025-06-16  7:18               ` Michal Simek
2025-06-16  7:23                 ` Krzysztof Kozlowski
2025-06-13 10:44 ` [PATCH v2 1/2] dt-bindings: fpga: Also describe clock for gpio Xu Yilun
2025-06-13 10:52   ` Michal Simek [this message]
2025-06-16  4:07     ` Xu Yilun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=712b690d-2fcf-486e-87a1-17e2354d371f@amd.com \
    --to=michal.simek@amd.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=git@xilinx.com \
    --cc=hao.wu@intel.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=monstr@monstr.eu \
    --cc=robh@kernel.org \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    --cc=yilun.xu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®