From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0819F430CF4 for ; Fri, 31 Jul 2026 14:45:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785509130; cv=none; b=OduP7RAo8sVkhhY/QHq/uBc3vIcOeuFSmdASUE1d1u/JrpnicRHdJCvFZoXaaUC8Mj/LXxFnWjGtPzXdZc/BEltevdYO0FCIZGKXOxbMgRQQYGQXPpKdyzStcJoW3NJPxE0Eh4660K/lRhqQQtAuJpj9bwtopVQyDGgGFg04ors= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785509130; c=relaxed/simple; bh=E7eJRBrZC7S6Dyl1yr3XZTSVgHOfz9ZEHGWqdMcDUsU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lPPPdjMm1ZOuvVcRrdaf2uU1TD3LZmBCR+lAHUulmZSgKdb6T9PYBfctqPFbZq3WIQTGUaHrt9XZdeCmlDJMi/YNbfxoGJGQzXKQJkMI+BbuNvBpyNd3LUURL/NrWInFP0GmSf1PK7Cs0Ynt+yDIc0vDvY+6sEYkeHXrgffxSFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PblENfWd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GPvSeWTM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PblENfWd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GPvSeWTM" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66VCCAv23778247 for ; Fri, 31 Jul 2026 14:45:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zUUexB7yi2dILgMSCy1Iht2kViTXKPk+CZkKSkRmhf4=; b=PblENfWdzolEPPKm NaHHVyHcnaaL+p03zGEnFLe20xztcSUywPvQ4QREHQIpXrFcWi9WpxKEK6POmr3x qjGDS5VZ6sp8H0STHBjH6eq8opc4Bgu/7TMkzSHzVifE6kG2vC26ve+iSJzf9LMC vGTRg8Pb/u95/J6O9l/Tp6Z2wqOVP4uxLssuhqWdziyAqoreqm2zkj0l032aT71M pJiLwwkyNvjPij0jr1SN5qhsaOxHbsclWkB/aP6gSH3JNrjeVM3Wt+INcZy8ic/b IJ3R+dqIprDJInKKskGfTjKwUsJiqZPaMgAHDgTJr/1SmWMZiYVqVezTbnSX2qzy bKjF1Q== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frugh0n0x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 14:45:28 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51bfe3fa93bso9867481cf.2 for ; Fri, 31 Jul 2026 07:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785509127; x=1786113927; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zUUexB7yi2dILgMSCy1Iht2kViTXKPk+CZkKSkRmhf4=; b=GPvSeWTMQ0KWHO63xo0wW0bl9MYw/xGTj9WqfFnWTmSz/vlLfWUo+H2RLfN6jzKlN5 Gj271glYLGyeCG2ZGGv38U6V2nHvp/ecDZp4nB2c/ehZOf6odwwkP2gpi9D0gk8MnOMm GUKk74H0PewPaOf8CXxUqn7ewq+W55bU2xtT8+fYNsVfFsyRhfYvmhIyEDpimUViAPac diLeOTY2O/RmfhSCDRicBeoeWSYsXXaIlrNEzzdzm6dKha6BKHNMNntDqhlMvzxLO+aY XYBRK6RI5xCMSuy5ghRAsHG7k5nE+SyzjoNUWmLDEupv0XOLDAqyB1B2VzaETqeSfrcy PLSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785509127; x=1786113927; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zUUexB7yi2dILgMSCy1Iht2kViTXKPk+CZkKSkRmhf4=; b=Tsa7zFBBTRlc2ZLwebZj0YTxFsrATQbs6Mmxt/F8xkhagPwt0VC31Fp/fsDc8nqIBZ Da2N8tsKH39KRydU7dCLbyh6b/wZzqgp8U94c9dJHHRVNJ0MCMDGLh/7Bp0r5/nuqV9m Gcu6Ylce9UnlLvzBrYjK6S1iJ7GYg41oswMRdg1HAaHjf/nGXo+3n0ooPPcdZ50aoLJK foWA0t20ODdwmonDTetFFBgLwBq2Plz5nbGKe4lHDAdeDxJzMA6H1dwsXewGK6+gJAa8 jRgDB/u7WSbvwodtMAwYOa4DJxUVhoyzgreLQHGBW2Kd4cBHRecmmCfGUgNzjsmpKW89 cvLg== X-Forwarded-Encrypted: i=1; AHgh+Rp3GbbHM9xiSL5PZfswYO3IX41fSc2eZzxIl8Qb9+1S34qDEJhc3t+h0DOg69lFb6D1219wAKr2zRDZC3Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yzau7qbLTwiMBfyf+3wcJzaxgqkHAgSPhzPvV1zttBLnIpA48z/ SayeKD31j69UXFR495RNgHtfT9cXKDKDYsAOc5eyHiQrVaea/e1m343Q7FttLpd7tg2LimIMkmq l6O+qJwLae7/q3TJOMl8MtxEnJt2Ilz0C9dCIrDa7vciycLRBZLSbhOrkRAAAdR2vuhc= X-Gm-Gg: AR+sD12b9G5PCfLiQMpRusiEZyd+1RMNJEhtu2glRSF58bg7KHJXw4qVT5qY/e0w9DT t2TE/4qU6YC26A+GVmmOaUT6Bg1YNmT/dMn82777SE2vS4h/7ltbTCyxfqfJgWu0YutxW6vnKjU W0wKwc9KFmnYehNrKfPAtXuGyJYdzPVs3JIK8HZLuNei/jXl/jm1mpWjsmYPpvtmwWeZCvjdBIW TlWbjwz+LYhK/Y2NQwuXhQ13jbZiYWC65sCCKx7jd/3TM8EWsfMJE6r8Tv2p1mlh+wb9wDLR4sY /s1NjY30+AqQi5Aol/57ND+4Cfq9A+P2hiLFjyhJgJiFNCX2IMyY4xUFMikBoC91VOsD29DngfJ QeuxrDlnjX5y2F881wXSY7G2BsHRcUwxL X-Received: by 2002:a05:622a:c84:b0:51c:92a0:b2cb with SMTP id d75a77b69052e-52b5682e980mr7805741cf.26.1785509125549; Fri, 31 Jul 2026 07:45:25 -0700 (PDT) X-Received: by 2002:a05:622a:c84:b0:51c:92a0:b2cb with SMTP id d75a77b69052e-52b5682e980mr7801041cf.26.1785509123372; Fri, 31 Jul 2026 07:45:23 -0700 (PDT) Received: from [192.168.1.10] ([122.177.247.168]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2e24564d3sm353641e87.71.2026.07.31.07.45.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 07:45:22 -0700 (PDT) Message-ID: <712f8a14-d2a1-4a90-82f9-05cd694f2658@oss.qualcomm.com> Date: Fri, 31 Jul 2026 20:15:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] dt-bindings: bluetooth: qca: add QCC2072 To: Krzysztof Kozlowski Cc: Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Balakrishna Godavarthi , Rocky Liao , Manivannan Sadhasivam , Bjorn Andersson , Konrad Dybcio , Bartosz Golaszewski , linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, quic_mohamull@quicinc.com, quic_hbandi@quicinc.com, quic_anubhavg@quicinc.com References: <20260727-rb3-industrial-bt-uart-v2-0-2d100f30e202@oss.qualcomm.com> <20260727-rb3-industrial-bt-uart-v2-1-2d100f30e202@oss.qualcomm.com> <20260731-first-righteous-bear-dd72ed@quoll> Content-Language: en-US From: Rahul Samana In-Reply-To: <20260731-first-righteous-bear-dd72ed@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDExMiBTYWx0ZWRfX8JFKuz6PlJH9 WF4SD5gYVHak4va6O7SsM8roD751vhQZEsly41Bvf2p0xhO+aM2urPYFGyuUbtO8LVqJ/WLRBSc YiPKzcRR4SR/vWnAMqVNEDgpQpLyeZDk8HCl6GcPYVRzC/C9u/7zUM4E0QlpCJqrfJyKJ+B9urw 0Ro/MQSZKzslK2hpy9cwWIKOip41pHTDXFkrFejYW0VYKfsFrZtHY4Ng43+1oMOjSZhjjCkW1w8 LNY68UINz+JxxO+WbtlnCS3/PBbdHy7A7IlcOVt5k4pWh+N2qX1FT3AOQKYDlc5/ej0iElrKgin 0OfD0WJ7+V7pS4DXkUB16mERfgWimXyjCzHZxkQHzu4yZTThosl4y3wiq/NVFJVBhFzo1afYXHe 35xSsnErALP6WHU7p6RvSMbd0BU9MDl5bflOksFBqc9mLJMvQACmlHJHf0RwVKPwjCWr24RyyBK +0ilp2FJgjtBbK9zTfQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDExMiBTYWx0ZWRfX/a+RZNc6b5Wk wO1y+OcGMFBG6qfoSYFO5zm1fv2JiYXO4c4dQqXjPAwHrHZ4UDRGHHgOoY8Ees9KIp3CmKVZPwh h9waCkeYLtgWBzb2YIAGEWn8MredrV4= X-Authority-Analysis: v=2.4 cv=U+iiy+ru c=1 sm=1 tr=0 ts=6a6cb508 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=wVA5pQU3D6HtJETKl3oCcQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=ZtkR8tRNVxI1tjOBf7kA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: LTjaekfdnYD7j6F0xTqdCOS7slAwE6UY X-Proofpoint-GUID: LTjaekfdnYD7j6F0xTqdCOS7slAwE6UY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_04,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310112 On 31-07-2026 15:16, Krzysztof Kozlowski wrote: > On Mon, Jul 27, 2026 at 09:15:01PM +0530, Rahul Samana wrote: >> QCC2072 can be used on M.2 E-key cards where the card power resources are >> described by the pcie-m2-e-connector node. In that setup, the M.2 power >> sequencing provider creates the Bluetooth serdev child after matching the >> QCC2072 PCI function. >> >> Integrated non-M.2 designs need board-specific power resources. Document >> only the compatible for now and leave those properties to be added with >> matching driver support. >> >> Document the qcom,qcc2072-bt compatible used for QCC2072 Bluetooth >> controllers connected over UART. >> >> Signed-off-by: Rahul Samana > > NAK, exactly same comments as before. > > Nothing got improved, although what is weird - original SoB is gone, so > this is legally dubious work. > > Best regards, > Krzysztof > Hi Krzysztof, Thanks for the review. For the binding contents, I tried to capture the current scope in the binding description itself. This series supports QCC2072 only as an M.2 E-key card, where the card power resources are described by the pcie-m2-e-connector node and the M.2 pwrseq provider creates the Bluetooth serdev child. The binding also says: Integrated non-M.2 designs require board-specific power resources. Those properties, together with a static devicetree example, should be added when integrated non-M.2 support is added. We do not currently have an integrated non-M.2 QCC2072 design, so I do not have board-specific regulator supplies to document for that topology. Could you please suggest how you would prefer this binding to be handled for the current M.2-only use case? For the authorship concern, I mentioned the earlier QCC2072 contributions in the cover letter, but I understand that is not sufficient. Since this still documents the same qcom,qcc2072-bt compatible introduced by the earlier work, I will carry the earlier authorship / Signed-off-by chain in v3. Regards, Rahul