From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
davem@davemloft.net, "Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Richard Cochran" <richardcochran@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Vadim Fedorenko" <vadim.fedorenko@linux.dev>,
"Alexis Lothoré" <alexis.lothore@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: stmmac: Add a devlink attribute to control timestamping mode
Date: Wed, 29 Oct 2025 07:59:10 +0100 [thread overview]
Message-ID: <71310577-7cea-42ce-8442-49e09e0b958a@bootlin.com> (raw)
In-Reply-To: <20251028151925.12784dca@kernel.org>
Hi Jakub,
On 28/10/2025 23:19, Jakub Kicinski wrote:
> Sorry didn't get to review this in time.
>
> On Fri, 24 Oct 2025 09:07:18 +0200 Maxime Chevallier wrote:
>> + * - ``ts_coarse``
>
> This is not a great name IMHO. Is "coarse" from the PRM?
Yes, it uses "fine/coarse"
> It's the increment that's coarse, right? Not the timestamp
> This naming confuses me greatly.
That is true, the ts_ was added as this configuration is done based
on the timestamping control registers, and is refered to as
"timestamping control fine update" in the register defs :(
So you are correct that in the end the clock frequency is coarsely
adjusted.
The patch was applied, should we revert or add another patch to rename
that parameter ?
>
>> + - Boolean
>> + - runtime
>> + - Enable the Coarse timestamping mode. In Coarse mode, the ptp clock is
>> + expected to be updated through an external PPS input, but the subsecond
>
> I guess the definition of "PPS input" got diluted but technically it
> means Pulse Per Second, right? Here IIUC we need an actual 50MHz clock
> fed in?
For GM, yes indeed. I can update the doc accordingly.
>
>> + increment used for timestamping is set to 1/ptp_clock_rate. In Fine mode
>> + (i.e. Coarse mode == false), the ptp clock frequency is adjusted more
>> + frequently, but the subsecond increment is set to 2/ptp_clock_rate.
>> + Coarse mode is suitable for PTP Grand Master operation. If unsure, leave
>> + the parameter to False.
>
> My understanding based on your previous explanation is that basically
> in one of the modes the frequency cannot be adjusted. It's only usable
> if a very stable reference clock is fed into the device (or otherwise
> we "trust" the clock that's fed in). So that's why Grand Master.
>
> In the other mode we can tweak the frequency more accurately.
> But it comes at a cost of the HW time incrementing 2x larger step.
>
> If that's the case I think we should update the documentation and
> rename the knob to indicate that it's the frequency adjustment that's
> coarse.
That's fine by me, just let me know abut the exact process, I can followup
on that :)
Maxime
next prev parent reply other threads:[~2025-10-29 6:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 7:07 [PATCH net-next v2 0/2] net: stmmac: Add support for coarse timestamping Maxime Chevallier
2025-10-24 7:07 ` [PATCH net-next v2 1/2] net: stmmac: Move subsecond increment configuration in dedicated helper Maxime Chevallier
2025-10-24 12:43 ` Russell King (Oracle)
2025-10-24 7:07 ` [PATCH net-next v2 2/2] net: stmmac: Add a devlink attribute to control timestamping mode Maxime Chevallier
2025-10-24 12:44 ` Russell King (Oracle)
2025-10-28 10:16 ` Kory Maincent
2025-10-28 22:19 ` Jakub Kicinski
2025-10-29 6:59 ` Maxime Chevallier [this message]
2025-10-29 22:50 ` Jakub Kicinski
2025-10-28 14:50 ` [PATCH net-next v2 0/2] net: stmmac: Add support for coarse timestamping patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71310577-7cea-42ce-8442-49e09e0b958a@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alexis.lothore@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®