From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752510AbdHPUDx (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Aug 2017 16:03:53 -0400
Received: from mout.web.de ([212.227.17.11]:65416 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752417AbdHPUDv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Aug 2017 16:03:51 -0400
Subject: Re: pstore: Improve a size determination in three functions
To: Kees Cook <keescook@chromium.org>
Cc: Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>, kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
References: <97737d95-d6aa-d24f-1af0-9d4895ceaed2@users.sourceforge.net>
 <23798ef4-5559-3454-ecf4-e6844b644ff3@users.sourceforge.net>
 <CAGXu5jLdTHJB576tqhpPZb_cV0B4zMnSAVkG=DzTN-dT51iAsw@mail.gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <713573fc-52e8-d7a0-f4c0-2ce514dd1d1f@users.sourceforge.net>
Date: Wed, 16 Aug 2017 22:03:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <CAGXu5jLdTHJB576tqhpPZb_cV0B4zMnSAVkG=DzTN-dT51iAsw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:LlN21TzTeOp59KxJprmOzUNBpyggFsz7odVH+VAPSFscjrhpeu2
 LcFinYivhoHD/VnMDzhJ3v8Ky+kf2rXekH+pB2GSgpcmWs14Ko14el1OBzmK6hMeuQDJmnZ
 Km1gTOpvXhWwA5yMruElTAfd+UeuMidtleMOhwqIBlcu1PvoWYAlkzdNkM/bOW9Q45HAKB1
 yiVdfv0bHw1ktkm29u1hg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:WfkCAL7+444=:w5yChpPcRA3qmzlgDIPdHG
 qPXBt4bzEcmPtg72gAdHw3An4B/MuTV/pDnVYDiSJNistdtdORFEnW758Pbx1ltpmJiECF2UG
 ptgzyJ0f72uTdHO9w1UX1gTzmZf2Wnb7guOJeeW/4KUS8ts6q3plQZfIe6SDeXy33FbBCnvAR
 PnjvnUfqbwUMJOMq65G7kHSNoKiY+idvgbvFEcYGDImLRjAAfTAqOtG6ijzRRGs5hSWoPMFKj
 Zi9SbiPkc9qllLPHIUlNEFQHVIQ5HySCESPemLVljMRlwTJLTeso17k3zxaDZDbAY1y0T42U3
 mhfwXy+jfkNUHfq1VvoZzAJRxTNfB6I3Nf38ddvOjAye9WdaGUBeeXFFvmXV9UoZi8D1r+KHN
 I3FG4VGtBv38Jy90dOwdJt2e4KwUOP8+Cfr4gklfRTc3IErFK9vof5r+UnBE1O/056JUu+hB0
 xDvxf9py4Bqwqtt3a5kx/tX2Uw3mBfwg+sUr2KWYQwNq45LPaDh3E0E+7drObyjjyxeQSe8rT
 SMIben0Q8sjpmWM10quiMy23Aw67MLsNcO7PDDjAkW78huXrjPUw82HerHlqbchahzR1p0Hdq
 G03O+6xnCItmcAcPVnGc0g0T9keG3iwSx+cu5DWFkBgpv3OTsj8TsL3qdZokweOhoK/eZ92VJ
 GxLK3xRj8Bh/Tl34gMS3HwUZ8hS5z5D9hqm83eseGTerq7qmT4/yj4WXcZmLuFfEoc94G7qz9
 FZyD8hwVwSbow9D0gINQuyBDdXVAhmfSAmT28zQgDRYjVDcFEox2cXUNzSAGNsjBGg1bn050+
 hBhDGtNDRxAG1HXsAsLD0seTglbc2u7bIR4XoPixF4wX+ggWk8=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Which script detected this?

* checkpatch.pl

* The following approach for the semantic patch language.

@replacement@
identifier action, var, work;
statement s1, s2;
statement list sl;
type T, X;
@@
 T work(...)
 {
 ... when any
 X* var;
 ... when any
 var = action(...,
              sizeof(
-                    X
+                    *var
                    ),
              ...
             )
 ... when any
 }