From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012045.outbound.protection.outlook.com [40.107.209.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BC4533F364 for ; Wed, 18 Feb 2026 15:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.45 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771429697; cv=fail; b=KaX7SWpaiDp9esf092SrTGNsc2SdzL/7YblH4kfdxjdEwB5HwwF5VIekNyg/0hjgp6K2yRldvJScljKL1ZGIUn8H733HuNWwrI4Wd/rGmlyUMUM2GdSx8MNfsoEhCE11DP2cmYnYbpltbAMPUKnZOTRf3G3f6ddfQzspIttuxzU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771429697; c=relaxed/simple; bh=yZ/d2U/tSpzYvA+eFWWnZo03vjRkFdOJhssqalZmWGA=; h=Message-ID:Date:To:Cc:References:Subject:From:In-Reply-To: Content-Type:MIME-Version; b=su6fbF7Et78MQzcHLoih3VUifWgyP9rKsWRqwPsi/Wha1YvNAHI0Ro45IG0IIDFkD445+Utza907ILtHmWaxnyEyOSO4WEqInayr+QT1fdgQvcHTEQO/qTlP5mrh2aCWAPTvVFlvA93yFsFtFBbQicnXrMEC06DRhwvb6Z/z2IQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com; spf=pass smtp.mailfrom=citrix.com; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b=mE1s1RLe; arc=fail smtp.client-ip=40.107.209.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=citrix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="mE1s1RLe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=U9VL4Xn9/xYeZwFb0Sf2PaWFYfVOYFqe2k41HjyTj6QzWVwcYwh/Hu2MSttivMdVBfPHzRUoENNI99At1UYvQ9HNiMJV1yRMKa61bt0wagwc4h75PEmQ4BN9HwT8SVIc0fXtUR3wOB20YNKu+jAEaQMyKWfzsWM2UBvoTw8KmzCbFSoYa5xn+8FcM0m5k9IjnBodX+ahkkgLWPX7dwFWDHb7orL+VLR61DgVjeq/oxCG+2n2RTtVYHcVA9khjm9/8wYAE8hPIDQ29c1wlb49Luy5icPKtPAUwmHYNAWJf3FkRJy8tChb3HO3vkYgq8Nj2HN28xq3KgnV4uGjkwIGuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yZ/d2U/tSpzYvA+eFWWnZo03vjRkFdOJhssqalZmWGA=; b=StuTs2Kqq3KbBL3a2nTJDwAE/nt4NeHfmWiDHaok6rfxY+DZXELzvTrhpebbluABXBzAEDMJo+o/8NofdWvW9Z3BoTmJebFT0Az5+F9vCr1uM9CoMxgs+VSel1N7fs75Q6D1vFGhp5a2nEbUD5ez9lTz0cviUef3fR/xQZmBGsn+lpdRwbyK+8iUFDjE2LpUcObqFEKWhlvujO7GMtBH4H/4egyGg+Wa38ebXEmRLuC40gpxk858rDQ03hMCS28F99tYoorNHK8hZgEEKqqx8RxD2Ywhm1D07qvt/R7+BYreIn0yTnhxmoynBAQiVvBuwRecgU5OjHGvq6cmHAP0Ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yZ/d2U/tSpzYvA+eFWWnZo03vjRkFdOJhssqalZmWGA=; b=mE1s1RLeM8cfkDSRbU0Bo7IH7E3d93/HDQVZUATfDwOToQyG6WQ4b4LZkIkRnpF3jfYu3fDVfVqYE7e2nf9OXdN9V4N5AsTXy7J4QAOtuJXiTWoR1iWbHcUs73WOsECgPCLnQTNPED/cwIRdxujpud4/DPlv7dmttqil3m9WJkA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Received: from IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) by BN9PR03MB6073.namprd03.prod.outlook.com (2603:10b6:408:136::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.14; Wed, 18 Feb 2026 15:48:11 +0000 Received: from IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599]) by IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599%5]) with mapi id 15.20.9632.010; Wed, 18 Feb 2026 15:48:11 +0000 Message-ID: <7135fe16-25eb-44c2-9b5d-99f4cecea3dc@citrix.com> Date: Wed, 18 Feb 2026 15:48:07 +0000 User-Agent: Mozilla Thunderbird To: jgross@suse.com Cc: Andrew Cooper , bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@kernel.org, x86@kernel.org, xin@zytor.com References: <20260218082133.400602-9-jgross@suse.com> Subject: Re: [PATCH v3 08/16] x86/extable: Add support for immediate form MSR instructions Content-Language: en-GB From: Andrew Cooper In-Reply-To: <20260218082133.400602-9-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0396.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::23) To IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR03MB8288:EE_|BN9PR03MB6073:EE_ X-MS-Office365-Filtering-Correlation-Id: fed1c2bc-0602-43e7-a03d-08de6f051ed1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QlZYY2VIWFZQcG5NQk1XNU5ZSFpuWW1WZzBUZ1BlUDIzb2FEN2l5Sm9Gblc1?= =?utf-8?B?VDZtSGRURjBkc1V3VG02VlA5MWRadXNTVm42NW5ndmt4Mis4cmFsS3kySWda?= =?utf-8?B?UjJYaDRqd0x5MHphTmRHSm1Sb2MycWZVR01DYnFKYm9mSllhd2Y2dTFzMzZi?= =?utf-8?B?ekltOVluSk1kSXFQZklEemxVZzhTVzRQL095VklsYkgzWjZKKzN6S0pkZkFn?= =?utf-8?B?cEdCOThDY3JTcmp6WWlrTWU4VlJmVGRyNXk0Z2hqdmQ3ako0U0RiYlJpY1RR?= =?utf-8?B?amVlWndBVlBwSFVpeGRQTXJKM0lEV1Ixa1hJZEFYZWdDbmNBSEZGYTBRWDJV?= =?utf-8?B?Y3dsdUxQUVhubGkxSG5Rd25XQ21Mb2U0Vm15Z3ZWOXVQMnhvb1I3VnVkOW5w?= =?utf-8?B?WDV2WlZrYXcxRGFXeUJScDBFUWRKUnhQR0pzVWZkZThRa09DYmhNM1NpRDJ6?= =?utf-8?B?ZlNaL21jSmVvalIrL3R6TEdIdE4wN3VKRXd3MUpVY1VJTXlKNklKTEhRNG1P?= =?utf-8?B?SURUMFhCRGp3QWhJb1RzMENwemYzUm1VdDFLZGJwU3FHRlV3OVRzcjdFdnB3?= =?utf-8?B?VHArck93QmZ6WmM0ZzVmUU5pNUtwUXUrQWVZcisxNVJ3eUhKNERwamQ5b0Jo?= =?utf-8?B?a1FzSm82bEJkdnRPZFpaOFhucXNCUzlrd2pvQUNTTTBxNVVaclZpaHpuc2dS?= =?utf-8?B?NDNtWVFrRFM3V0FUQjhJYlpLWHBZUDNPUzZCTWg5YXZMN3BnaWVvQzBSRWZZ?= =?utf-8?B?Z2ZiV0xVbVcwS0wyd0RQSTViYVJ3QVp2R0h0WGJpUHJNN1NZcWthVTVMSHJN?= =?utf-8?B?OUxTbW9zenBadXZhdUFwOWc4Tnh6VzMrMlNaSk40dHEyNHBxNzFxKzA0UzhV?= =?utf-8?B?V1JaQ2grcWx5TWYxUGFLYWRsYkFVb3JFNmJMTkh5THl0Q0xoU3Z6VEw0RFNJ?= =?utf-8?B?UHI3aWo5emNXdVBqalVDRDJnbmx3TEY4MTl4NGdQTTg5TEVTb1RtQjhnblY4?= =?utf-8?B?UExVamxCOEdkZFVIMVJxM0tPRkRFOWRmd08vZ0JRSWhTVG1CYnF1aEpzWmpJ?= =?utf-8?B?Z2dNREhjbUxCNDhBR2c4UUhJdEtVVGZGMC81UEM3S1ZvZElQN0RqdjZydXVy?= =?utf-8?B?UldHbEpnK1RoQjlqbTQ2d2QzakJKN1VleWxpZXh0T1U5enorRGdxNFRWbW54?= =?utf-8?B?ankyTzlPbFk3RTZmeFVTRi9KeVdLZWJDV3duU1E0Qy9GS2Z5cVFXYnFVZDJs?= =?utf-8?B?Wks0MjZBcEFBbHNhWE9vZE9RSGUxc1FUUEhGUFo2bCtQcVg5Y0FrNTZ2VUpV?= =?utf-8?B?Y1ovcmV5NXptc2hmMHZGeWErZG45UnQyeXFzRGNhYzRtQlo1QmZxKzBqNDBm?= =?utf-8?B?TjE2YndMZGN5cGtyQ1ZLZVV3NEgyUXNzMGpYSlhJZWN1UTJUNk9ubEVYRit5?= =?utf-8?B?ZVdTcjE4Q2s4SkJuQkZnQXM1WVdnTWxVNi9NMEJSdjhXVDU4aU9oSU9sbWp0?= =?utf-8?B?MWxOWGM5MUh1d0lFZlh1aklUaVRiVFlqSVk3VHpqd3dpa21nK1RSVXZES0RV?= =?utf-8?B?ZGovY0hLdFZGWi9YS1V5cFVoQ3JHWlNQOGdpQm5WbHU5cWtSNC9nKytEa3Br?= =?utf-8?B?aytqbDRUM1lsQ08zSndpWUx4U3dEazdwcDc4YVdaaWJpTGt4Z3g5Ri9jRXBz?= =?utf-8?B?blNySy95UUZER0NSanB2aGJBTDRxSUdFdmZiM1Eydjg2KzVSK3cyUnZWQTRj?= =?utf-8?B?aHRPUi9FUURYZkxzNWZXNmFmZktHT1graDJoS21ON3lCRVE4RUtWUlNyOFVK?= =?utf-8?B?ckE1SHZUVGE4bDVDMmxJMFp3M09hY3psbzJkRUs5QlFDcDNJMzBhd0VHaWgx?= =?utf-8?B?RjZKbW4yTUw4N1BwNHF6UEE4MHZVcHlZd1B4dVI0eDY3UzRTZjluVkltY3ZP?= =?utf-8?B?QjNQblZMc1EyZk5kYTh4d1p3VlgyMnJTWDFqTHg2N1R2Q09vaTh3RkFDdUFH?= =?utf-8?B?UUVPQWZ0cTR0NzQ4ZzEzRWZZR2dtQlZnZ2NvL29WcFFCd2RqeTh5Zy9iVkVE?= =?utf-8?B?SWgzYTdlRnhrWkhTeUUvMVQxL2dxcWNtR0g5RzJndUwrV2I0OTJFT0lxbDZ5?= =?utf-8?Q?sMZI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR03MB8288.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFJadU50UmtRV3hsQWdnSW1yc1ZtQzZmNE1rQndnd2lITFFiWHdzUEI0YmlR?= =?utf-8?B?a296eGNkdXhGM3pXSWd0Q2JCVW41THVIN29DWFJONFloQ2hHUVBTc0JmWlhL?= =?utf-8?B?S1E1QmlGMzRvQ09MZVVBendSNFFKRjdKRTcrL3VLeEVQcUFrVzRGVHBMeDlE?= =?utf-8?B?UmtMOVpSM1ZjbXdvMkZpV3BJeWtXTHI0SUtDbldlWXU4dE9JeTFTbGEzVENo?= =?utf-8?B?MVlpc1pLVUJlMksyMU5MUHRqOTJDbE5pUW5rVlBjcldobXNsTjh2ZjV6am5M?= =?utf-8?B?YVFBbnllR2hQdjlka2x5bVp3UEV6enpsSzExbEN2Y0hjWFJ3YW04WEEwZVBv?= =?utf-8?B?TkFzYmFjVENnWUl1SWwwbWhzSGJnY3hua1dUMHNhM2hLLytoKzhHY1hNZmlW?= =?utf-8?B?RGxVelJSTlljK0d3Uk5la3dJYVE3YnBDbHJEQ2ErbTliRElLZ05TY25Qb2dW?= =?utf-8?B?UU84dHd2MTRrSG84cEZTQ2x1NSttKytYM21rUlE0c2NFRFhQUHZYOWMvRkFp?= =?utf-8?B?ek1IK1cwbVlBYlVNOGtWd29vUlpFUkdyOFBqTm5rWlo4WVZ3ZFJjQzllbytE?= =?utf-8?B?bUdlcVh5K2JKcEttZU9JZ0FNMFRkYnB3ZzBMYnpJRVpQQkhTS0ZnMW5NN25j?= =?utf-8?B?SzhiUXNzdmkxRUlDVDQvSUhrakxxSGZaRkRESlZOZVp2amhaVTVpdlBaOGVi?= =?utf-8?B?ZzJwSDZMcytIdzA2MzhkNU1sY1daQ0NTeWFRL2twTFdiWkVheUpjSDE3aDVR?= =?utf-8?B?T3Q1dlIzQmIzMTdWM2t6ZllNdUxkUm1sRTZyckJoakpXd1RBaGxjWVM3R00y?= =?utf-8?B?aE5PTWVUY3pPTFRCWW8wcUh6OTNVNUtjU3h4MkFHTW9NS1JDWTBabXRlRDNN?= =?utf-8?B?bVNRblRPNFZUOEhyR3RBZEQ4Vm1MWU5wTHlwT1FaMWZjRklvNHllSFVXNHVO?= =?utf-8?B?YUJWMlFoNlZleGJraEJHRjRiUyt6K0VEVU0vclVsR2JlNkxTUjlTckZVU1Y4?= =?utf-8?B?b2hhV3FnZmdvNWh4akVCM1ZyQU5pMlk2Y1F3dlJEUHA2Wjd1a2VNUnNvZTNH?= =?utf-8?B?WHdMbzU2dGgwUkgyNkZURWYybzR4T01reXJnT3VYNmh5SUtlWHlFdFdFV05k?= =?utf-8?B?b2ZnSVhEUDdhZ1NDMFdJMUYzL0lRUzFxS3Z3Ny9LME9VQmhlemN1Yjg0am5w?= =?utf-8?B?ZTZtMkxjSmkrZGlIeEVnMW9zNU9sOWVvSWNIc3pueXVQZFVvOTQ2VGVVU3lL?= =?utf-8?B?Y3VwczkvM0g2WGdSQzJpd3Q2czJSTmpXOEx0UlF6M2IyMzdOaU1CbXNoZzBQ?= =?utf-8?B?OW9qRy9LTVdmKzYvWVNHb1NiYi9UQW5iblplZDM2NTVhK1JVYlhvcjhod01k?= =?utf-8?B?SGxZejlreGlYdnpIM1cyZ25Fek9NdkgvV2JWUllsd2NpaWcrM0w3UHl3aDVy?= =?utf-8?B?LzJqWkJGU3BWSWdIQ3lIRlZoUzRVckphbGpwOVlmdWxXMEFiejkzOStaYkg3?= =?utf-8?B?WGo0d2J6L1ppR05PbytGaHNENGFBOHNWbWtuZWFOQW5GcHVNU3lwTDMzaWQr?= =?utf-8?B?V2ZMMXl0TWZrM1B5dUp2Z1JITUljQU5lUEVLS0p5REdEbkZvV2VVMno1Skth?= =?utf-8?B?bGJGaDhiVHJuaU5uMEJmelUzMG40VGc1ZlNlVnJ2K0JycFV6YkdZeHhySy9r?= =?utf-8?B?ZC85UUdpMHdJaHpDeUdTZEhsTC9XdTNkZEFmZzg1eEQ3eC8reHZQdEN0LzFS?= =?utf-8?B?eVkva1ZhallGaUxZcTM4N3dnQmN3MW9TeTRsK28zWkR6L2Y3RTE5TEppNklr?= =?utf-8?B?WEgyRGJvVmROUjlhUWhpMGJzRFlyTFpIWkhWamdnSEYwZHhCblo5TWRCWERm?= =?utf-8?B?emcvVWxXL1ZGNTZuRDVaenFrQjFzemFZVStDRFIzUSthZ2RmdjBQQ0tmUDk5?= =?utf-8?B?WDRmTVZhNXZoMjRRVG9YeXVCMzkvUFdYdEN5bHlocEtBSTZ3RU1hTllhVjMz?= =?utf-8?B?QTNNSjFjQ3JoTXNROUVGLzhkR29MQllrVTRjREdZUkJXWk02NEg3QWNOZEN0?= =?utf-8?B?WFpURDVvSExxWHZlc1VYcGtTa2lvK3k5ZVRlTkFsenNhZmhLVVVwMVJmL2lW?= =?utf-8?B?VXI2Ni9kTXVrNDlPSXJyWmZKT01uRVFiZXJkU2tiUWNiSGpkcDM1RW03dmVU?= =?utf-8?B?MG9yWUZ3ZjA2UVJ3M3VSakJ0M2dmaFRlcmd1NDdNYWFhYTRIRlpOdTR3KytL?= =?utf-8?B?SVVUUGhvbU1LeUhaWnlKMXRVTjMwZlFPMGhCS2xkTk52ZVVwTVJVaTFhSGc3?= =?utf-8?B?a0c0Si9wbFhQUTJHWCtreTBUeDRpeStGRmNEeG83bTMzWXRYNWRLQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fed1c2bc-0602-43e7-a03d-08de6f051ed1 X-MS-Exchange-CrossTenant-AuthSource: IA1PR03MB8288.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2026 15:48:11.7341 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 33nOrqL0M2LMYe7NK/MHHYqKHTGpnLnQMtriKraPCnMkq13DubYPAuxRKL9BikcpEa2VgJz74mqAGue2El2fCzJi7wu0zfN5ubFro4wJVUk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6073 Ideally please CC xen-devel on all patches if you've CC'd some, or at least CC me on all patches that you partially send to xen-devel.  Having only 4 patches of the series is very awkward to reply to. > + /* + * To maintain consistency with existing RDMSR and WRMSR(NS) > instructions, + * the register operand for immediate form MSR > instructions is ALWAYS + * encoded as RAX in for reading > or writing the MSR value. + */ + u64 msr_val = regs->ax; This is unsafe.  It assumes that the only source of MSR $IMM instructions anywhere are the wrappers. While this might be the wish of the developers, that doesn't make it true. You've already decoded the instruction and got the ModRM byte, so either check that it really is encoding %rax, or select the proper GPR based on ModRM. ~Andrew