From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C54922F767 for ; Fri, 21 Aug 2026 07:18:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787296714; cv=none; b=FtCVIupL0wn58xTCgTSSbNIMv7YrzTjU2uhtbCULVq/UmUsQTygMnYEkMIBLubjBPEfmxLnS01BtHw779QDyEnCFWb1wvDxYW/mrnc8W16LyBiQRcUum1485ixLoKM8jn+QbI3evABXvv1+ukvZFJ5irRGtBo6clZ+4UMb6zTnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787296714; c=relaxed/simple; bh=mCtJJhD7UgMOBv0lxTBLCEO+2G+dwpHy7Km6h3DX9p0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CSKWU4Uv6LNoAYeDNSJgfDQ9vcya2HUoTk5/WfhP3b1xJsGfNSuYej9y+1Cz2TMpAsgtX7kDU1Q2oJoNwbF6JNniVgXg3ODGtV2zb2D1dlMBMztcHDKJKzAtLaU70m1n+p4UF/xizJ3MbwETsy6DBU1wospAzaI//Hyi6JwAEVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=U4/FH2Qs; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=gbEtvNN7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U4/FH2Qs"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="gbEtvNN7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787296712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6xlKCRyJmUt4oo7s6EMRczgy6MnR0ePY4jhsRQ6cVx4=; b=U4/FH2QsZHDP0lSiMuwRcvu3Xt7fPubgQDTT0fhbmc9pgpWHhuT12xQWMDxKeKAT/4sDZE 0IbOQqpn0ozvE+P73k8g3uisb75XSuumFiCjSjPAP/biPhmaQ+BhD/gXcojMV1So1JNPfN wKC5FkuIb5FUOHGa5//wPjdInv9HQNI= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-349-uLKLAe7PMOu5iEuv_I2vjA-1; Fri, 21 Aug 2026 03:18:26 -0400 X-MC-Unique: uLKLAe7PMOu5iEuv_I2vjA-1 X-Mimecast-MFC-AGG-ID: uLKLAe7PMOu5iEuv_I2vjA_1787296705 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-848d21bbb55so1085347b3a.0 for ; Fri, 21 Aug 2026 00:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787296705; x=1787901505; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6xlKCRyJmUt4oo7s6EMRczgy6MnR0ePY4jhsRQ6cVx4=; b=gbEtvNN7aLAbQ8qD25ebEWETzTv7kkVb3a0gkzLBMC7oYRGz07HVdgi4xffPGT4ZJ0 8VfM8qllO7jWD24vg03L9NH6izWUu29WdxTHTKJABcwE68DZeu5NpvX+ey5g8iY0KnJm B2N1W+sEZq0Jb/8ZYjPK6skFJM5wiSgiDxmkL76is6P3clogM6CJHP08Ka/WXW4sOKM/ AgN5uEYNSstsfZybN6fYc+LtCbXEH8JzNlz1TP6wDi+4mRO6SmW07p9HhZ1gkUO7lN/l w38GenPtxVcCeFPsOmuLv1yY5XaBKnpTStMr/5sp49xTGW0xtiUtiD0cOOC6dV5+QsDL K8xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787296705; x=1787901505; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6xlKCRyJmUt4oo7s6EMRczgy6MnR0ePY4jhsRQ6cVx4=; b=Lp4BTyPuB2ATb0vGys14oY1NrGBuBaS6zYgD7X/27FHqqwb8uzZ+bXViWV4b/lCr1t KJeKZ0594/j5FXAL2YKQusEdnqqjaWGqQW/K/ptDKzlfLtDEuVsqRXFSME5S5uEwMdk2 7ydE1mre1+/gqQT5YGspJG8XvC6TsHrOr9iNJXTEfL9lYOcopcYXxMs70xGSqD6zftWn ZKPbbE0IgTCAYNG2BdKdwfYcxnga8GP/F6qpbsdAJ3bF/4GRXRrV8gH9t9BUkQKeiXCM ajT7ZuU+7CpLjzUd1yJZZNcr+GoG7u8lt17qdf9KyJTbu6GTyaMxq9AHkB/YmkjuNmDR VjLA== X-Forwarded-Encrypted: i=1; AHgh+RrC3EIMVaPb4PZb1mSyrjUyuOP+5a6dzzk6gdcIvbgUoxVibrnguxWGUMQLBAiX9mjrtat2mRQlyhJb1aQ=@vger.kernel.org X-Gm-Message-State: AFuF++kZ20zf2kUEh8j6MpBM+cCRj/xaBVmqIuOVj0yDSWneTZboZt7s uPX7wcpQPYsqyeCMYRkkKg5XeU37IywgUicNDewewP9+4yRlhYyvAQnZWWXKo4FCeArxGbTkmxa 6hZHh/eM9FByR0/hYWXZSDYalbel/aUVsjBJr6ePF93SKyYQouzeNz0p0e+cJsLsb/g== X-Gm-Gg: AR+sD12JtWRuaT1fiEgsX6YGbddVMShfawyaoyio4NUvjxKFzOTiBAd1IPJy1HrG1vI tH7l5IacIIZpjoMl3FFVhpiGKwXeUVUiKiS2h7jO/lLRAdm+Z3vB2CeyZzwCCON5j8r8FzH92yL PabvoGA94EIBxcB2N4fbrs+LtgXrF3b4XHq96OnW1L3VlbYUbmnNF7QQHXWg0ibjtGasD83d42E r/8KrmCJPtJH5NSDQmdxuzwPZCNeT8bEH3jdZiBEZKqDIOPOs9/2ukQOm59wf3h9j+WtQgXS+D6 SHoxYmktgMQHV838ewFXA9xfQQErCYhzvH9b0S8cRxJ1VCk3DUMpn5zbg5IIX4SSJl+rQp3CxDy d8SaRpm2nFaj87TRDLg== X-Received: by 2002:a05:6a00:179a:b0:847:8449:2ba6 with SMTP id d2e1a72fcca58-851f9f66789mr6258577b3a.8.1787296705122; Fri, 21 Aug 2026 00:18:25 -0700 (PDT) X-Received: by 2002:a05:6a00:179a:b0:847:8449:2ba6 with SMTP id d2e1a72fcca58-851f9f66789mr6258522b3a.8.1787296704696; Fri, 21 Aug 2026 00:18:24 -0700 (PDT) Received: from [192.168.1.3] ([122.171.22.116]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851d3361d24sm2509087b3a.5.2026.08.21.00.18.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Aug 2026 00:18:24 -0700 (PDT) Message-ID: <713ab0a0-235d-47cf-a0c2-73249fbc8f74@redhat.com> Date: Fri, 21 Aug 2026 12:48:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] kexec: fix error propagation in kexec_image_probe_default() To: Pratyush Yadav , Philipp Rudo Cc: Catalin Marinas , Will Deacon , Mark Rutland , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Andrew Morton , Baoquan He , Mike Rapoport , Pasha Tatashin , Tao Liu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, kexec@lists.infradead.org References: <20260819-mpilaniy-v2-0-95e929ede0e5@redhat.com> <20260819-mpilaniy-v2-2-95e929ede0e5@redhat.com> <20260820142114.0a36ac78@rotkaeppchen> <2vxzik54zmpp.fsf@kernel.org> Content-Language: en-US From: Mukesh Pilaniya In-Reply-To: <2vxzik54zmpp.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Philipp, On 20/08/26 11:41 pm, Pratyush Yadav wrote: > On Thu, Aug 20 2026, Philipp Rudo wrote: > >> Hi Mukesh, >> Hi Pratyush, >> >> having this patch makes sense. Personally I'd go with having a >> switch-case rather than individual if-blocks. E.g. >> >> switch (ret) { >> case 0: >> image->fops = *fops; >> return 0; >> case -ENOEXEC: >> continue; >> default: >> return ret; >> } >> >> IMHO that is better readable and easier to extend in case other error >> codes need special handling as well. But that is only my personal >> opinion. > > Well, IMO both look roughly the same so I unless Mukesh prefers your > version more, we can keep it as-is. > Thanks for the review. I agree the switch-case reads nicely, but since the current version is functionally equivalent and already reviewed, I'll keep it as-is to avoid re-spinning for a style change. Happy to switch if you or Pratyush feel strongly about it. >> >> Independent on which implementation you use. >> >> Reviewed-by: Philipp Rudo > > Thanks for reviewing! > > One tiny suggestion. Can you please reply in-line the next time around? > It is a bit easier reading this response below the code that it refers > to. > >> >> >> On Wed, 19 Aug 2026 23:17:23 +0530 >> Mukesh Pilaniya wrote: >> >>> kexec_image_probe_default() overwrites ret with each loader's probe >>> return value and returns whatever the last loader returned when no >>> probe matches. The error code reaching userspace depends on whichever >>> loader happens to be last in kexec_file_loaders[]. >>> >>> Only continue to the next loader when a probe returns -ENOEXEC. >>> Propagate any other error such as -ENOMEM immediately. Return -ENOEXEC >>> only when all loaders have been tried and none matched. >>> >>> Suggested-by: Pratyush Yadav >>> Signed-off-by: Mukesh Pilaniya >>> --- >>> kernel/kexec_file.c | 12 +++++++----- >>> 1 file changed, 7 insertions(+), 5 deletions(-) >>> >>> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c >>> index 59fb9d71e9d8..b3060e984ef3 100644 >>> --- a/kernel/kexec_file.c >>> +++ b/kernel/kexec_file.c >>> @@ -68,17 +68,19 @@ int kexec_image_probe_default(struct kimage *image, void *buf, >>> unsigned long buf_len) >>> { >>> const struct kexec_file_ops * const *fops; >>> - int ret = -ENOEXEC; >>> >>> for (fops = &kexec_file_loaders[0]; *fops && (*fops)->probe; ++fops) { >>> - ret = (*fops)->probe(buf, buf_len); >>> - if (!ret) { >>> + int ret = (*fops)->probe(buf, buf_len); >>> + >>> + if (ret == 0) { >>> image->fops = *fops; >>> - return ret; >>> + return 0; >>> } >>> + if (ret != -ENOEXEC) >>> + return ret; >>> } >>> >>> - return ret; >>> + return -ENOEXEC; >>> } >>> >>> static void *kexec_image_load_default(struct kimage *image) >>> >> >